hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Consolidate some "maybe-types" and arguments using them

Browse Source 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-tursoandJanne Savolainen committed 2022-10-26 11:49:55 +03:00
1 parent b93bea359b
commit 244ddf7e64
2 files changed
+5 -3
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/common/utils/composable-responsibilities/orderable/orderable.ts
+3 -1
View File
@@ -9,7 +9,9 @@ export interface Orderable {
readonly orderNumber: number;
}
export const orderByOrderNumber = <T extends Orderable | object>(maybeOrderables: T[]) =>
export type MaybeOrderable = Orderable | object;
export const orderByOrderNumber = <T extends MaybeOrderable>(maybeOrderables: T[]) =>
sortBy(
(orderable) =>
"orderNumber" in orderable
src/common/utils/composable-responsibilities/showable/showable.ts
+2 -2
View File
@@ -10,9 +10,9 @@ export interface Showable {
readonly isShown: IComputedValue<boolean> | boolean;
}
export type MaybeShowable = Partial<Showable>;
export type MaybeShowable = Showable | object;
export const isShown = (showable: Showable | object) => {
export const isShown = (showable: MaybeShowable) => {
if (!("isShown" in showable)) {
return true;
}