Remove Helm release update checker (#420)

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>

dashboard/client/api/endpoints/helm-releases.api.ts

@@ -198,21 +198,4 @@ export class HelmRelease implements ItemObject {
     const chartVersion = versions.find(chartVersion => chartVersion.version === version);
     return chartVersion ? chartVersion.repo : "";
   }
-
-  getLastVersion(): string | null {
-    const chartName = this.getChart();
-    const versions = helmChartStore.versions.get(chartName);
-    if (!versions) {
-      return null; // checking new version state
-    }
-    if (versions.length) {
-      return versions[0].version; // versions already sorted when loaded, the first is latest
-    }
-    return this.getVersion();
-  }
-
-  hasNewVersion() {
-    const lastVersion = this.getLastVersion();
-    return lastVersion && lastVersion !== this.getVersion();
-  }
 }

dashboard/client/components/+apps-releases/release-details.tsx

@@ -19,7 +19,6 @@ import { AceEditor } from "../ace-editor";
 import { Button } from "../button";
 import { releaseStore } from "./release.store";
 import { Notifications } from "../notifications";
-import { Icon } from "../icon";
 import { createUpgradeChartTab } from "../dock/upgrade-chart.store";
 import { getDetailsUrl } from "../../navigation";
 import { _i18n } from "../../i18n";
@@ -190,14 +189,12 @@ export class ReleaseDetails extends Component<Props> {
         <DrawerItem name={<Trans>Chart</Trans>} className="chart">
           <div className="flex gaps align-center">
             <span>{release.getChart()}</span>
-            {release.hasNewVersion() && (
+            <Button
-              <Button
+              primary
-                primary
+              label={_i18n._(t`Upgrade`)}
-                label={_i18n._(t`Upgrade`)}
+              className="box right upgrade"
-                className="box right upgrade"
+              onClick={this.upgradeVersion}
-                onClick={this.upgradeVersion}
+            />
-              />
-            )}
           </div>
         </DrawerItem>
         <DrawerItem name={<Trans>Updated</Trans>}>
@@ -211,12 +208,6 @@ export class ReleaseDetails extends Component<Props> {
             <span>
               {release.getVersion()}
             </span>
-            {!release.getLastVersion() && (
-              <Icon svg="spinner" small/>
-            )}
-            {release.hasNewVersion() && (
-              <span><Trans>New version available:</Trans> <b>{release.getLastVersion()}</b></span>
-            )}
           </div>
         </DrawerItem>
         <DrawerItem name={<Trans>Status</Trans>} className="status" labelsOnly>

dashboard/client/components/+apps-releases/release-menu.tsx

@@ -37,7 +37,6 @@ export class HelmReleaseMenu extends React.Component<Props> {
     const { release, toolbar } = this.props;
     if (!release) return;
     const hasRollback = release && release.getRevision() > 1;
-    const hasNewVersion = release.hasNewVersion();
     return (
       <>
         {hasRollback && (
@@ -46,12 +45,6 @@ export class HelmReleaseMenu extends React.Component<Props> {
             <span className="title"><Trans>Rollback</Trans></span>
           </MenuItem>
         )}
-        {hasNewVersion && (
-          <MenuItem onClick={this.upgrade}>
-            <Icon material="build" interactive={toolbar} title={_i18n._(t`Upgrade`)}/>
-            <span className="title"><Trans>Upgrade</Trans></span>
-          </MenuItem>
-        )}
       </>
     )
   }

dashboard/client/components/+apps-releases/releases.tsx

@@ -5,9 +5,7 @@ import kebabCase from "lodash/kebabCase";
 import { observer } from "mobx-react";
 import { Trans } from "@lingui/macro";
 import { RouteComponentProps } from "react-router";
-import { autobind, interval } from "../../utils";
 import { releaseStore } from "./release.store";
-import { helmChartStore } from "../+apps-helm-charts/helm-chart.store";
 import { IReleaseRouteParams, releaseURL } from "./release.route";
 import { HelmRelease } from "../../api/endpoints/helm-releases.api";
 import { ReleaseDetails } from "./release-details";
@@ -15,9 +13,7 @@ import { ReleaseRollbackDialog } from "./release-rollback-dialog";
 import { navigation } from "../../navigation";
 import { ItemListLayout } from "../item-object-list/item-list-layout";
 import { HelmReleaseMenu } from "./release-menu";
-import { Icon } from "../icon";
 import { secretsStore } from "../+config-secrets/secrets.store";
-import { when } from "mobx";
 
 enum sortBy {
   name = "name",
@@ -33,31 +29,16 @@ interface Props extends RouteComponentProps<IReleaseRouteParams> {
 
 @observer
 export class HelmReleases extends Component<Props> {
-  private versionsWatcher = interval(3600, this.checkVersions);
 
   componentDidMount() {
     // Watch for secrets associated with releases and react to their changes
     releaseStore.watch();
-    this.versionsWatcher.start();
-    when(() => releaseStore.isLoaded, this.checkVersions);
   }
 
   componentWillUnmount() {
     releaseStore.unwatch();
-    this.versionsWatcher.stop();
   }
 
-  // Check all available versions every 1 hour for installed releases.
-  // This required to show "upgrade" icon in the list and upgrade button in the details view.
-  @autobind()
-  checkVersions() {
-    const charts = releaseStore.items.map(release => release.getChart());
-    return charts.reduce((promise, chartName) => {
-      const loadVersions = () => helmChartStore.getVersions(chartName, true);
-      return promise.then(loadVersions, loadVersions);
-    }, Promise.resolve({}))
-  };
-
   get selectedRelease() {
     const { match: { params: { name, namespace } } } = this.props;
     return releaseStore.items.find(release => {
@@ -130,7 +111,6 @@ export class HelmReleases extends Component<Props> {
           ]}
           renderTableContents={(release: HelmRelease) => {
             const version = release.getVersion();
-            const lastVersion = release.getLastVersion();
             return [
               release.getName(),
               release.getNs(),
@@ -138,20 +118,6 @@ export class HelmReleases extends Component<Props> {
               release.getRevision(),
               <>
                 {version}
-                {!lastVersion && (
-                  <Icon
-                    small svg="spinner"
-                    className="checking-update"
-                    tooltip={<Trans>Checking update</Trans>}
-                  />
-                )}
-                {release.hasNewVersion() && (
-                  <Icon
-                    material="new_releases"
-                    className="new-version"
-                    tooltip={<Trans>New version: {lastVersion}</Trans>}
-                  />
-                )}
               </>,
               release.appVersion,
               { title: release.getStatus(), className: kebabCase(release.getStatus()) },