1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Fix typings

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2023-01-09 11:05:40 -05:00
parent 7d25e93655
commit 25482dcb38
8 changed files with 22 additions and 24 deletions

View File

@ -19,6 +19,7 @@ import appNameInjectable from "../../../common/vars/app-name.injectable";
import buildVersionInjectable from "../../vars/build-version/build-version.injectable"; import buildVersionInjectable from "../../vars/build-version/build-version.injectable";
import emitAppEventInjectable from "../../../common/app-event-bus/emit-event.injectable"; import emitAppEventInjectable from "../../../common/app-event-bus/emit-event.injectable";
import statInjectable from "../../../common/fs/stat.injectable"; import statInjectable from "../../../common/fs/stat.injectable";
import createKubeApiInjectable from "../../../common/k8s-api/create-kube-api.injectable";
export interface NodeShellSessionArgs { export interface NodeShellSessionArgs {
websocket: WebSocket; websocket: WebSocket;
@ -45,6 +46,7 @@ const openNodeShellSessionInjectable = getInjectable({
spawnPty: di.inject(spawnPtyInjectable), spawnPty: di.inject(spawnPtyInjectable),
emitAppEvent: di.inject(emitAppEventInjectable), emitAppEvent: di.inject(emitAppEventInjectable),
stat: di.inject(statInjectable), stat: di.inject(statInjectable),
createKubeApi: di.inject(createKubeApiInjectable),
}; };
return async (args) => { return async (args) => {

View File

@ -3,6 +3,8 @@
* Licensed under MIT License. See LICENSE in root directory for more information. * Licensed under MIT License. See LICENSE in root directory for more information.
*/ */
import { getDiForUnitTesting } from "../../getDiForUnitTesting";
import defaultWebsocketApiParamsInjectable from "../default-websocket-api-params.injectable";
import type { WebSocketEvents } from "../websocket-api"; import type { WebSocketEvents } from "../websocket-api";
import { WebSocketApi } from "../websocket-api"; import { WebSocketApi } from "../websocket-api";
@ -16,7 +18,11 @@ describe("WebsocketApi tests", () => {
let api: TestWebSocketApi; let api: TestWebSocketApi;
beforeEach(() => { beforeEach(() => {
api = new TestWebSocketApi({}); const di = getDiForUnitTesting({ doGeneralOverrides: true });
api = new TestWebSocketApi({
defaultParams: di.inject(defaultWebsocketApiParamsInjectable),
}, {});
}); });
describe("before connection", () => { describe("before connection", () => {

View File

@ -6,6 +6,7 @@ import { getInjectable } from "@ogre-tools/injectable";
import assert from "assert"; import assert from "assert";
import loggerInjectable from "../../common/logger.injectable"; import loggerInjectable from "../../common/logger.injectable";
import hostedClusterIdInjectable from "../cluster-frame-context/hosted-cluster-id.injectable"; import hostedClusterIdInjectable from "../cluster-frame-context/hosted-cluster-id.injectable";
import defaultWebsocketApiParamsInjectable from "./default-websocket-api-params.injectable";
import type { TerminalApiDependencies, TerminalApiQuery } from "./terminal-api"; import type { TerminalApiDependencies, TerminalApiQuery } from "./terminal-api";
import { TerminalApi } from "./terminal-api"; import { TerminalApi } from "./terminal-api";
@ -17,6 +18,7 @@ const createTerminalApiInjectable = getInjectable({
const hostedClusterId = di.inject(hostedClusterIdInjectable); const hostedClusterId = di.inject(hostedClusterIdInjectable);
const deps: Omit<TerminalApiDependencies, "hostedClusterId"> = { const deps: Omit<TerminalApiDependencies, "hostedClusterId"> = {
logger: di.inject(loggerInjectable), logger: di.inject(loggerInjectable),
defaultParams: di.inject(defaultWebsocketApiParamsInjectable),
}; };
return (query) => { return (query) => {

View File

@ -42,7 +42,7 @@ const setupKubernetesClusterContextMenuOpenInjectable = getInjectable({
if (result.error) { if (result.error) {
logger.error("[KUBERNETES-CLUSTER]: failed to parse kubeconfig file", result.error); logger.error("[KUBERNETES-CLUSTER]: failed to parse kubeconfig file", result.error);
} else { } else {
openDeleteClusterDialog({ cluster, config: result.config }); openDeleteClusterDialog(result.config, cluster);
} }
}, },
}); });

View File

@ -23,12 +23,7 @@ export class NamespaceStore extends KubeObjectStore<Namespace, NamespaceApi> {
makeObservable(this); makeObservable(this);
autoBind(this); autoBind(this);
this.init(); // initialize allowed namespaces
}
private async init() {
await this.dependencies.storage.whenReady;
const { allowedNamespaces } = this; const { allowedNamespaces } = this;
const selectedNamespaces = this.dependencies.storage.get(); // raw namespaces, undefined on first load const selectedNamespaces = this.dependencies.storage.get(); // raw namespaces, undefined on first load

View File

@ -4,15 +4,13 @@
*/ */
import assert from "assert"; import assert from "assert";
import { getInjectable } from "@ogre-tools/injectable"; import { getInjectable } from "@ogre-tools/injectable";
import { import { kubeObjectStoreInjectionToken } from "../../../common/k8s-api/api-manager/manager.injectable";
kubeObjectStoreInjectionToken, import ingressClassApiInjectable from "../../../common/k8s-api/endpoints/ingress-class.api.injectable";
} from "../../../common/k8s-api/api-manager/manager.injectable";
import ingressClassApiInjectable
from "../../../common/k8s-api/endpoints/ingress-class.api.injectable";
import { IngressClassStore } from "./ingress-class-store"; import { IngressClassStore } from "./ingress-class-store";
import clusterFrameContextForNamespacedResourcesInjectable
from "../../cluster-frame-context/for-namespaced-resources.injectable";
import storesAndApisCanBeCreatedInjectable from "../../stores-apis-can-be-created.injectable"; import storesAndApisCanBeCreatedInjectable from "../../stores-apis-can-be-created.injectable";
import clusterFrameContextForClusterScopedResourcesInjectable from "../../cluster-frame-context/for-cluster-scoped-resources.injectable";
import loggerInjectable from "../../../common/logger.injectable";
const ingressClassStoreInjectable = getInjectable({ const ingressClassStoreInjectable = getInjectable({
id: "ingress-class-store", id: "ingress-class-store",
@ -23,7 +21,8 @@ const ingressClassStoreInjectable = getInjectable({
const api = di.inject(ingressClassApiInjectable); const api = di.inject(ingressClassApiInjectable);
return new IngressClassStore({ return new IngressClassStore({
context: di.inject(clusterFrameContextForNamespacedResourcesInjectable), context: di.inject(clusterFrameContextForClusterScopedResourcesInjectable),
logger: di.inject(loggerInjectable),
}, api); }, api);
}, },

View File

@ -6,7 +6,7 @@
import { DockTabStore } from "../dock-tab-store/dock-tab.store"; import { DockTabStore } from "../dock-tab-store/dock-tab.store";
import type { TabId } from "../dock/store"; import type { TabId } from "../dock/store";
import { logTabDataValidator } from "./log-tab-data.validator"; import { logTabDataValidator } from "./log-tab-data.validator";
import type { CreateStorage } from "../../../utils/create-storage/create-storage"; import type { DockTabStoreDependencies } from "../dock-tab-store/dock-tab.store";
export interface LogTabOwnerRef { export interface LogTabOwnerRef {
/** /**
@ -56,12 +56,8 @@ export interface LogTabData {
showPrevious: boolean; showPrevious: boolean;
} }
interface Dependencies {
createStorage: CreateStorage;
}
export class LogTabStore extends DockTabStore<LogTabData> { export class LogTabStore extends DockTabStore<LogTabData> {
constructor(protected dependencies: Dependencies) { constructor(dependencies: DockTabStoreDependencies) {
super(dependencies, { super(dependencies, {
storageKey: "pod_logs", storageKey: "pod_logs",
}); });

View File

@ -34,8 +34,6 @@ export class PortForwardStore extends ItemStore<PortForwardItem> {
} }
private async init() { private async init() {
await this.dependencies.storage.whenReady;
const savedPortForwards = this.dependencies.storage.get(); // undefined on first load const savedPortForwards = this.dependencies.storage.get(); // undefined on first load
if (Array.isArray(savedPortForwards) && savedPortForwards.length > 0) { if (Array.isArray(savedPortForwards) && savedPortForwards.length > 0) {