From 27871f57b669aed8de90e6c6703df3cceaad74d3 Mon Sep 17 00:00:00 2001 From: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com> Date: Thu, 1 Sep 2022 09:27:31 -0400 Subject: [PATCH] reinstate integration tests on windows (#6152) --- integration/__tests__/app-preferences.tests.ts | 4 +--- integration/__tests__/command-palette.tests.ts | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/integration/__tests__/app-preferences.tests.ts b/integration/__tests__/app-preferences.tests.ts index ed3cc71099..2054a5342d 100644 --- a/integration/__tests__/app-preferences.tests.ts +++ b/integration/__tests__/app-preferences.tests.ts @@ -11,7 +11,6 @@ */ import type { ElectronApplication, Page } from "playwright"; import * as utils from "../helpers/utils"; -import { isWindows } from "../../src/common/vars"; describe("preferences page tests", () => { let window: Page, cleanup: () => Promise; @@ -34,8 +33,7 @@ describe("preferences page tests", () => { await cleanup(); }, 10*60*1000); - // skip on windows due to suspected playwright issue with Electron 14 - utils.itIf(!isWindows)('shows "preferences" and can navigate through the tabs', async () => { + it('shows "preferences" and can navigate through the tabs', async () => { const pages = [ { id: "application", diff --git a/integration/__tests__/command-palette.tests.ts b/integration/__tests__/command-palette.tests.ts index 7073d1d4cc..8356379b60 100644 --- a/integration/__tests__/command-palette.tests.ts +++ b/integration/__tests__/command-palette.tests.ts @@ -5,7 +5,6 @@ import type { ElectronApplication, Page } from "playwright"; import * as utils from "../helpers/utils"; -import { isWindows } from "../../src/common/vars"; describe("Lens command palette", () => { let window: Page, cleanup: () => Promise, app: ElectronApplication; @@ -20,8 +19,7 @@ describe("Lens command palette", () => { }, 10*60*1000); describe("menu", () => { - // skip on windows due to suspected playwright issue with Electron 14 - utils.itIf(!isWindows)("opens command dialog from menu", async () => { + it("opens command dialog from menu", async () => { await app.evaluate(async ({ app }) => { await app.applicationMenu ?.getMenuItemById("view")