hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Don't attempt to sync files larger than 16MiB

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-10-07 12:00:07 -04:00
parent ae96ae7d50
commit 2808565161
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/main/catalog-sources/kubeconfig-sync.ts
View File

@ -26,7 +26,7 @@ import { FSWatcher, watch } from "chokidar";
import fs from "fs"; import fs from "fs";
import path from "path"; import path from "path";
import type stream from "stream"; import type stream from "stream";
import { Disposer, ExtendedObservableMap, iter, Singleton, storedKubeConfigFolder } from "../../common/utils"; import { bytesToUnits, Disposer, ExtendedObservableMap, iter, noop, Singleton, storedKubeConfigFolder } from "../../common/utils";
import logger from "../logger"; import logger from "../logger";
import type { KubeConfig } from "@kubernetes/client-node"; import type { KubeConfig } from "@kubernetes/client-node";
import { loadConfigFromString, splitConfig } from "../../common/kube-helpers"; import { loadConfigFromString, splitConfig } from "../../common/kube-helpers";
@ -228,9 +228,18 @@ export function computeDiff(contents: string, source: RootSource, filePath: stri
}); });
} }
function diffChangedConfig(filePath: string, source: RootSource): Disposer { const maxAllowedFileReadSize = 16 * 1024 * 1024; // 16 MiB
function diffChangedConfig(filePath: string, source: RootSource, stats: fs.Stats): Disposer {
logger.debug(`${logPrefix} file changed`, { filePath }); logger.debug(`${logPrefix} file changed`, { filePath });
if (stats.size >= maxAllowedFileReadSize) {
logger.warn(`${logPrefix} skipping ${filePath}: size=${bytesToUnits(stats.size)} is larger than maxSize=${bytesToUnits(maxAllowedFileReadSize)}`);
source.clear();
return noop;
}
// TODO: replace with an AbortController with fs.readFile when we upgrade to Node 16 (after it comes out) // TODO: replace with an AbortController with fs.readFile when we upgrade to Node 16 (after it comes out)
const fileReader = fs.createReadStream(filePath, { const fileReader = fs.createReadStream(filePath, {
mode: fs.constants.O_RDONLY, mode: fs.constants.O_RDONLY,
@ -294,7 +303,7 @@ function watchFileChanges(filePath: string): [IComputedValue<CatalogEntity[]>, D
}); });
watcher watcher
.on("change", (childFilePath) => { .on("change", (childFilePath, stats) => {
const cleanup = cleanupFns.get(childFilePath); const cleanup = cleanupFns.get(childFilePath);
if (!cleanup) { if (!cleanup) {
@ -303,9 +312,9 @@ function watchFileChanges(filePath: string): [IComputedValue<CatalogEntity[]>, D
} }
cleanup(); cleanup();
cleanupFns.set(childFilePath, diffChangedConfig(childFilePath, rootSource.getOrInsert(childFilePath, observable.map))); cleanupFns.set(childFilePath, diffChangedConfig(childFilePath, rootSource.getOrInsert(childFilePath, observable.map), stats));
}) })
.on("add", (childFilePath) => { .on("add", (childFilePath, stats) => {
if (isFolderSync) { if (isFolderSync) {
const fileName = path.basename(childFilePath); const fileName = path.basename(childFilePath);
@ -316,7 +325,7 @@ function watchFileChanges(filePath: string): [IComputedValue<CatalogEntity[]>, D
} }
} }
cleanupFns.set(childFilePath, diffChangedConfig(childFilePath, rootSource.getOrInsert(childFilePath, observable.map))); cleanupFns.set(childFilePath, diffChangedConfig(childFilePath, rootSource.getOrInsert(childFilePath, observable.map), stats));
}) })
.on("unlink", (childFilePath) => { .on("unlink", (childFilePath) => {
cleanupFns.get(childFilePath)?.(); cleanupFns.get(childFilePath)?.();