From 287afa54836ac4cd523e9b11d92113ba3b96827c Mon Sep 17 00:00:00 2001 From: Iku-turso Date: Wed, 15 Mar 2023 10:24:20 +0200 Subject: [PATCH] Add placeholders for places that should escape code-coverage for a good reason: side-effects Co-authored-by: Janne Savolainen Signed-off-by: Iku-turso --- packages/kata-for-gabriel/jest.config.js | 2 +- packages/kata-for-gabriel/src/cast-die.injectable.ts | 2 ++ .../kata-for-gabriel/src/message-to-player.injectable.ts | 2 ++ .../kata-for-gabriel/src/question-to-player.injectable.ts | 7 ++++++- 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/kata-for-gabriel/jest.config.js b/packages/kata-for-gabriel/jest.config.js index c6074967eb..38d54ab7b6 100644 --- a/packages/kata-for-gabriel/jest.config.js +++ b/packages/kata-for-gabriel/jest.config.js @@ -1 +1 @@ -module.exports = require("@k8slens/jest").monorepoPackageConfig(__dirname).configForNode; +module.exports = require("@k8slens/jest").monorepoPackageConfig(__dirname).configForReact; diff --git a/packages/kata-for-gabriel/src/cast-die.injectable.ts b/packages/kata-for-gabriel/src/cast-die.injectable.ts index 3b78a0fffb..72d8f160dc 100644 --- a/packages/kata-for-gabriel/src/cast-die.injectable.ts +++ b/packages/kata-for-gabriel/src/cast-die.injectable.ts @@ -1,3 +1,5 @@ +/* ignore coverage somehow */ + import { getInjectable } from "@ogre-tools/injectable"; const castDieInjectable = getInjectable({ diff --git a/packages/kata-for-gabriel/src/message-to-player.injectable.ts b/packages/kata-for-gabriel/src/message-to-player.injectable.ts index 9830e04d0b..5580b86300 100644 --- a/packages/kata-for-gabriel/src/message-to-player.injectable.ts +++ b/packages/kata-for-gabriel/src/message-to-player.injectable.ts @@ -1,3 +1,5 @@ +/* ignore coverage somehow */ + import { getInjectable } from "@ogre-tools/injectable"; const messageToPlayerInjectable = getInjectable({ diff --git a/packages/kata-for-gabriel/src/question-to-player.injectable.ts b/packages/kata-for-gabriel/src/question-to-player.injectable.ts index c6b3afdc69..0a5c2beabf 100644 --- a/packages/kata-for-gabriel/src/question-to-player.injectable.ts +++ b/packages/kata-for-gabriel/src/question-to-player.injectable.ts @@ -1,8 +1,13 @@ +/* ignore coverage somehow */ + import { getInjectable } from "@ogre-tools/injectable"; const questionToPlayerInjectable = getInjectable({ id: "question-to-player", - instantiate: () => (question: string) => Promise.resolve(true), + + instantiate: () => (message: string) => + new Promise((resolve) => resolve(window.confirm(message))), + causesSideEffects: true, });