mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Rename old directory for behaviours as "features" to better communicate new intent with new directory structure to organize code and tests around features instead of technicalities (#6033)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
1 parent
36077a9fea
commit
299922c8a7
107 files changed
No files matched your search
@@ -0,0 +1,181 @@
|
||||
/**
|
||||
* Copyright (c) OpenLens Authors. All rights reserved.
|
||||
* Licensed under MIT License. See LICENSE in root directory for more information.
|
||||
*/
|
||||
import type { FakeExtensionData, TestExtension } from "../renderer/components/test-utils/get-renderer-extension-fake";
|
||||
import { getRendererExtensionFakeFor } from "../renderer/components/test-utils/get-renderer-extension-fake";
|
||||
import React from "react";
|
||||
import type { RenderResult } from "@testing-library/react";
|
||||
import { fireEvent } from "@testing-library/react";
|
||||
import isEmpty from "lodash/isEmpty";
|
||||
import queryParametersInjectable from "../renderer/routes/query-parameters.injectable";
|
||||
import currentPathInjectable from "../renderer/routes/current-path.injectable";
|
||||
import type { IComputedValue } from "mobx";
|
||||
import { getApplicationBuilder } from "../renderer/components/test-utils/get-application-builder";
|
||||
|
||||
describe("navigate to extension page", () => {
|
||||
let rendered: RenderResult;
|
||||
let testExtension: TestExtension;
|
||||
let queryParameters: IComputedValue<object>;
|
||||
let currentPath: IComputedValue<string>;
|
||||
|
||||
beforeEach(async () => {
|
||||
const applicationBuilder = getApplicationBuilder();
|
||||
const getRendererExtensionFake = getRendererExtensionFakeFor(applicationBuilder);
|
||||
|
||||
testExtension = getRendererExtensionFake(
|
||||
extensionWithPagesHavingParameters,
|
||||
);
|
||||
|
||||
applicationBuilder.extensions.renderer.enable(testExtension);
|
||||
|
||||
rendered = await applicationBuilder.render();
|
||||
|
||||
const rendererDi = applicationBuilder.dis.rendererDi;
|
||||
|
||||
queryParameters = rendererDi.inject(queryParametersInjectable);
|
||||
currentPath = rendererDi.inject(currentPathInjectable);
|
||||
});
|
||||
|
||||
it("renders", () => {
|
||||
expect(rendered.container).toMatchSnapshot();
|
||||
});
|
||||
|
||||
describe("when extension navigates to route without parameters", () => {
|
||||
beforeEach(() => {
|
||||
testExtension.navigate();
|
||||
});
|
||||
|
||||
it("renders", () => {
|
||||
expect(rendered.container).toMatchSnapshot();
|
||||
});
|
||||
|
||||
it("URL is correct", () => {
|
||||
expect(currentPath.get()).toBe("/extension/some-extension-name");
|
||||
});
|
||||
|
||||
it("query parameters is empty", () => {
|
||||
expect(queryParameters.get()).toEqual({});
|
||||
});
|
||||
|
||||
describe("when changing page parameters", () => {
|
||||
beforeEach(() => {
|
||||
const button = rendered.getByTestId("button-to-change-page-parameters");
|
||||
|
||||
fireEvent.click(button);
|
||||
});
|
||||
|
||||
it("renders", () => {
|
||||
expect(rendered.container).toMatchSnapshot();
|
||||
});
|
||||
|
||||
it("URL is correct", () => {
|
||||
expect(currentPath.get()).toBe("/extension/some-extension-name");
|
||||
});
|
||||
|
||||
it("knows query parameters", () => {
|
||||
expect(queryParameters.get()).toEqual({
|
||||
someStringParameter: "some-changed-string-value",
|
||||
someNumberParameter: "84",
|
||||
someArrayParameter:
|
||||
"some-changed-array-value,some-other-changed-array-value",
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("when extension navigates to route with parameters", () => {
|
||||
beforeEach(() => {
|
||||
testExtension.navigate(undefined, {
|
||||
someStringParameter: "some-string-value-from-navigate",
|
||||
someNumberParameter: 126,
|
||||
someArrayParameter: ["some-array-value-from-navigate"],
|
||||
});
|
||||
});
|
||||
|
||||
it("renders", () => {
|
||||
expect(rendered.container).toMatchSnapshot();
|
||||
});
|
||||
|
||||
it("URL is correct", () => {
|
||||
expect(currentPath.get()).toBe("/extension/some-extension-name");
|
||||
});
|
||||
|
||||
it("knows query parameters", () => {
|
||||
expect(queryParameters.get()).toEqual({
|
||||
someStringParameter: "some-string-value-from-navigate",
|
||||
someNumberParameter: "126",
|
||||
someArrayParameter: "some-array-value-from-navigate",
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("when extension navigates to child route", () => {
|
||||
beforeEach(() => {
|
||||
testExtension.navigate("some-child-page-id");
|
||||
});
|
||||
|
||||
it("renders", () => {
|
||||
expect(rendered.container).toMatchSnapshot();
|
||||
});
|
||||
|
||||
it("URL is correct", () => {
|
||||
expect(currentPath.get()).toBe("/extension/some-extension-name/some-child-page-id");
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
const extensionWithPagesHavingParameters: FakeExtensionData = {
|
||||
id: "some-extension-id",
|
||||
name: "some-extension-name",
|
||||
globalPages: [
|
||||
{
|
||||
components: {
|
||||
Page: ({ params }) => (
|
||||
<div>
|
||||
<ul>
|
||||
<li>{params.someStringParameter.get()}</li>
|
||||
<li>{params.someNumberParameter.get()}</li>
|
||||
<li>{params.someArrayParameter.get().join(",")}</li>
|
||||
</ul>
|
||||
|
||||
<button
|
||||
type="button"
|
||||
data-testid="button-to-change-page-parameters"
|
||||
onClick={() => {
|
||||
params.someStringParameter.set("some-changed-string-value");
|
||||
params.someNumberParameter.set(84);
|
||||
params.someArrayParameter.set([
|
||||
"some-changed-array-value",
|
||||
"some-other-changed-array-value",
|
||||
]);
|
||||
}}
|
||||
>
|
||||
Some button
|
||||
</button>
|
||||
</div>
|
||||
),
|
||||
},
|
||||
|
||||
params: {
|
||||
someStringParameter: "some-string-value",
|
||||
someNumberParameter: {
|
||||
defaultValue: 42,
|
||||
stringify: (value) => value.toString(),
|
||||
parse: (value) => (value ? Number(value) : undefined),
|
||||
},
|
||||
someArrayParameter: {
|
||||
defaultValue: ["some-array-value", "some-other-array-value"],
|
||||
stringify: (value) => value.join(","),
|
||||
parse: (value: string[]) => (!isEmpty(value) ? value : undefined),
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
id: "some-child-page-id",
|
||||
components: {
|
||||
Page: () => <div>Child page</div>,
|
||||
},
|
||||
},
|
||||
],
|
||||
};
|
||||
Reference in new issue
Block a user