diff --git a/src/common/k8s-api/endpoints/nodes.api.ts b/src/common/k8s-api/endpoints/nodes.api.ts index 2705eeb1dd..01571a7d16 100644 --- a/src/common/k8s-api/endpoints/nodes.api.ts +++ b/src/common/k8s-api/endpoints/nodes.api.ts @@ -56,6 +56,21 @@ export interface INodeMetrics { fsSize: T; } +export interface NodeTaint { + key: string; + value?: string; + effect: string; + timeAdded: string; +} + +export function formatNodeTaint(taint: NodeTaint): string { + if (taint.value) { + return `${taint.key}=${taint.value}:${taint.effect}`; + } + + return `${taint.key}:${taint.effect}`; +} + export interface Node { spec: { podCIDR?: string; @@ -65,12 +80,7 @@ export interface Node { * @deprecated see https://issues.k8s.io/61966 */ externalID?: string; - taints?: { - key: string; - value: string; - effect: string; - timeAdded: string; - }[]; + taints?: NodeTaint[]; unschedulable?: boolean; }; status: { diff --git a/src/renderer/components/+nodes/node-details.tsx b/src/renderer/components/+nodes/node-details.tsx index cc858cba46..49823d96ae 100644 --- a/src/renderer/components/+nodes/node-details.tsx +++ b/src/renderer/components/+nodes/node-details.tsx @@ -132,11 +132,7 @@ export class NodeDetails extends React.Component { /> {taints.length > 0 && ( - { - taints.map(({ key, effect, value }) => ( - - )) - } + {taints.map(taint => )} )} {conditions && diff --git a/src/renderer/components/+nodes/nodes.tsx b/src/renderer/components/+nodes/nodes.tsx index 0d701e4ee7..fd0145a00c 100644 --- a/src/renderer/components/+nodes/nodes.tsx +++ b/src/renderer/components/+nodes/nodes.tsx @@ -227,6 +227,7 @@ export class Nodes extends React.Component { ]} renderTableContents={node => { const tooltipId = `node-taints-${node.getId()}`; + const taints = node.getTaints(); return [ , @@ -235,9 +236,9 @@ export class Nodes extends React.Component { this.renderMemoryUsage(node), this.renderDiskUsage(node), <> - {node.getTaints().length} + {taints.length} - {node.getTaints().map(({ key, value, effect }) => `${key}=${value}:${effect}`).join("\n")} + {taints.map(formatNodeTaint).join("\n")} , node.getRoleLabels(),