Remove a lot of usages of legacy globals (#6825)

* Remove all usages of legacy global logger Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global storageClassApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global serviceApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global secretApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global resourceQuotaApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global persistentVolumeClaimApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global nodeApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global networkPolicyApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix formatting Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global configMapApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global jobApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global cronJobApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global podApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global roleApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove exports of NonInjected components - To improve auto-complete Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global catalogEntityRegistry Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add lint against using legacy global works Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint in KubeObject file Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global catalogCategoryRegistry Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global navigation Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global navigate Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove unneeded index file Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global customResourceDefinitionStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global eventStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global podSecurityPolicyStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global storageClassStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global persistentVolumeStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global clusterRoleBindingStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global clusterRoleStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global roleBindingStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Move files around Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global roleStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global serviceAccountStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove usages of legacy global podStore Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove final uses of asLegacyGlobalForExtensionApi in application code Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint rule and start fixing lint errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make listHelmReleases injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make installHelmChart injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make deleteHelmRelease injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make getHelmReleaseValues injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make getHelmReleaseHistory injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make rollbackHelmRelease injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove unnecessary overrides from getDiForUnitTesting Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add global override for logger Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add global override for history Signed-off-by: Sebastian Malton <sebastian@malton.name> * Cleanup typing around getting injectables within jest Signed-off-by: Sebastian Malton <sebastian@malton.name> * Move some more overrides to global if needed Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add global override for forcusWindow Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint in KubeApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint in catalog/index.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove last usages of legacy global getDetailsUrl Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove last usages of legacy global showDetails Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add functions back to extension API Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove all uses of legacy global Notification functions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove no longer existing export Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove unnecessary overrides Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix injecting side effects by using more injectables Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix cluster role binding dialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix cluster role dialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix create service account dialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix history override Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make KubeApi consume its dependencies while not breaking the extension API Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix CephFs tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix user store tests by using override of config Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in hotbar store tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add direct devDep of memfs Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in cluster store tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in router tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in kube auth proxy tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in log resource selector tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in hotbar remove command tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in the select component tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove mock-fs as a dependency Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove no longer necessary mocks Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix namespace select filter tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove use of mockFs in the extension loader tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fixing edit-namespace-from-new-tab test Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix app paths tests by making the tests run in "production" mode Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove last vestiges of isTestEnv and the is* globals Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix delete-cluster-dialog tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix install-helm-chart-from-previously-opened-tab tests - Split out storage initialization to a runnable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove unnecessary override of non side effect injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix disable-kube-object-detail-items-when-cluster-is-not-relevant tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix reactively-hide-kube-object-detail-item tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix sidebar-and-tab-navigation-for-core tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove need to override lensLocalStoragePath in tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace more overrides with global ones Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix typings Signed-off-by: Sebastian Malton <sebastian@malton.name> * Remove no longer needed technical test Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshots Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Sebastian Malton <sebastian@malton.name>
2025-05-20 05:10:56 +00:00 · 2023-01-09 16:15:37 -05:00
1 parent 900a8bbda3
commit 2b33d5eed6
@@ -19,23 +19,23 @@ describe("app-paths", () => {
    builder = getApplicationBuilder();

    const defaultAppPathsStub: AppPaths = {
-      currentApp: "some-current-app",
-      appData: "some-app-data",
-      cache: "some-cache",
-      crashDumps: "some-crash-dumps",
-      desktop: "some-desktop",
-      documents: "some-documents",
-      downloads: "some-downloads",
-      exe: "some-exe",
-      home: "some-home-path",
-      logs: "some-logs",
-      module: "some-module",
-      music: "some-music",
-      pictures: "some-pictures",
-      recent: "some-recent",
-      temp: "some-temp",
-      videos: "some-videos",
-      userData: "some-irrelevant-user-data",
+      currentApp: "/some-current-app",
+      appData: "/some-app-data",
+      cache: "/some-cache",
+      crashDumps: "/some-crash-dumps",
+      desktop: "/some-desktop",
+      documents: "/some-documents",
+      downloads: "/some-downloads",
+      exe: "/some-exe",
+      home: "/some-home-path",
+      logs: "/some-logs",
+      module: "/some-module",
+      music: "/some-music",
+      pictures: "/some-pictures",
+      recent: "/some-recent",
+      temp: "/some-temp",
+      videos: "/some-videos",
+      userData: "/some-irrelevant-user-data",
    };

    builder.beforeApplicationStart((mainDi) => {
@@ -71,23 +71,23 @@ describe("app-paths", () => {
      const actual = windowDi.inject(appPathsInjectable);

      expect(actual).toEqual({
-        currentApp: "some-current-app",
-        appData: "some-app-data",
-        cache: "some-cache",
-        crashDumps: "some-crash-dumps",
-        desktop: "some-desktop",
-        documents: "some-documents",
-        downloads: "some-downloads",
-        exe: "some-exe",
-        home: "some-home-path",
-        logs: "some-logs",
-        module: "some-module",
-        music: "some-music",
-        pictures: "some-pictures",
-        recent: "some-recent",
-        temp: "some-temp",
-        videos: "some-videos",
-        userData: "some-app-data/some-product-name",
+        currentApp: "/some-current-app",
+        appData: "/some-app-data",
+        cache: "/some-cache",
+        crashDumps: "/some-crash-dumps",
+        desktop: "/some-desktop",
+        documents: "/some-documents",
+        downloads: "/some-downloads",
+        exe: "/some-exe",
+        home: "/some-home-path",
+        logs: "/some-logs",
+        module: "/some-module",
+        music: "/some-music",
+        pictures: "/some-pictures",
+        recent: "/some-recent",
+        temp: "/some-temp",
+        videos: "/some-videos",
+        userData: "/some-app-data/some-product-name",
      });
    });

@@ -95,23 +95,23 @@ describe("app-paths", () => {
      const actual = mainDi.inject(appPathsInjectable);

      expect(actual).toEqual({
-        currentApp: "some-current-app",
-        appData: "some-app-data",
-        cache: "some-cache",
-        crashDumps: "some-crash-dumps",
-        desktop: "some-desktop",
-        documents: "some-documents",
-        downloads: "some-downloads",
-        exe: "some-exe",
-        home: "some-home-path",
-        logs: "some-logs",
-        module: "some-module",
-        music: "some-music",
-        pictures: "some-pictures",
-        recent: "some-recent",
-        temp: "some-temp",
-        videos: "some-videos",
-        userData: "some-app-data/some-product-name",
+        currentApp: "/some-current-app",
+        appData: "/some-app-data",
+        cache: "/some-cache",
+        crashDumps: "/some-crash-dumps",
+        desktop: "/some-desktop",
+        documents: "/some-documents",
+        downloads: "/some-downloads",
+        exe: "/some-exe",
+        home: "/some-home-path",
+        logs: "/some-logs",
+        module: "/some-module",
+        music: "/some-music",
+        pictures: "/some-pictures",
+        recent: "/some-recent",
+        temp: "/some-temp",
+        videos: "/some-videos",
+        userData: "/some-app-data/some-product-name",
      });
    });
  });
@@ -123,7 +123,7 @@ describe("app-paths", () => {
      builder.beforeApplicationStart((mainDi) => {
        mainDi.override(
          directoryForIntegrationTestingInjectable,
-          () => "some-integration-testing-app-data",
+          () => "/some-integration-testing-app-data",
        );
      });

@@ -136,8 +136,8 @@ describe("app-paths", () => {
      const { appData, userData } = windowDi.inject(appPathsInjectable);

      expect({ appData, userData }).toEqual({
-        appData: "some-integration-testing-app-data",
-        userData: `some-integration-testing-app-data/some-product-name`,
+        appData: "/some-integration-testing-app-data",
+        userData: "/some-integration-testing-app-data/some-product-name",
      });
    });

@@ -145,8 +145,8 @@ describe("app-paths", () => {
      const { appData, userData } = windowDi.inject(appPathsInjectable);

      expect({ appData, userData }).toEqual({
-        appData: "some-integration-testing-app-data",
-        userData: "some-integration-testing-app-data/some-product-name",
+        appData: "/some-integration-testing-app-data",
+        userData: "/some-integration-testing-app-data/some-product-name",
      });
    });
  });