From 2db2bc78aee6b299fa94fd9373a7b44c96216fd3 Mon Sep 17 00:00:00 2001
From: Roman <ixrock@gmail.com>
Date: Wed, 11 Nov 2020 18:57:58 +0200
Subject: [PATCH] fix: checkPreferredVersion invalid if-condition

Signed-off-by: Roman <ixrock@gmail.com>
---
 src/renderer/api/kube-api.ts | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/renderer/api/kube-api.ts b/src/renderer/api/kube-api.ts
index 994f707f9d..c3c9698cfa 100644
--- a/src/renderer/api/kube-api.ts
+++ b/src/renderer/api/kube-api.ts
@@ -109,17 +109,16 @@ export class KubeApi<T extends KubeObject = any> {
   }
 
   protected async checkPreferredVersion() {
-    if (!this.options.checkPreferredVersion || this.apiVersionPreferred === undefined) {
-      return;
-    }
-    const res = await this.request.get<IKubePreferredVersion>(`${this.apiPrefix}/${this.apiGroup}`);
-    Object.defineProperty(this, "apiVersionPreferred", {
-      value: res?.preferredVersion?.version ?? null,
-    });
+    if (this.options.checkPreferredVersion && this.apiVersionPreferred === undefined) {
+      const res = await this.request.get<IKubePreferredVersion>(`${this.apiPrefix}/${this.apiGroup}`);
+      Object.defineProperty(this, "apiVersionPreferred", {
+        value: res?.preferredVersion?.version ?? null,
+      });
 
-    if (this.apiVersionPreferred) {
-      Object.defineProperty(this, "apiBase", { value: this.getUrl() })
-      apiManager.registerApi(this.apiBase, this);
+      if (this.apiVersionPreferred) {
+        Object.defineProperty(this, "apiBase", { value: this.getUrl() })
+        apiManager.registerApi(this.apiBase, this);
+      }
     }
   }