From 30c14eb6da4e824f48c1746ca8971bf5aaf58a83 Mon Sep 17 00:00:00 2001
From: Alex Andreev <alex.andreev.email@gmail.com>
Date: Fri, 14 Aug 2020 14:39:28 +0300
Subject: [PATCH] Fixing role binding details view without subjects (#688)

Signed-off-by: alexfront <alex.andreev.email@gmail.com>
---
 .../role-binding-details.tsx                  | 53 ++++++++++---------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx b/src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx
index bc1957961b..2839c99dc2 100644
--- a/src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx
+++ b/src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx
@@ -64,6 +64,7 @@ export class RoleBindingDetails extends React.Component<Props> {
     }
     const name = roleBinding.getName();
     const { roleRef } = roleBinding;
+    const subjects = roleBinding.getSubjects();
     return (
       <div className="RoleBindingDetails">
         <KubeObjectMeta object={roleBinding}/>
@@ -83,31 +84,33 @@ export class RoleBindingDetails extends React.Component<Props> {
         </Table>
 
         <DrawerTitle title={<Trans>Bindings</Trans>}/>
-        <Table selectable className="bindings box grow">
-          <TableHead>
-            <TableCell checkbox/>
-            <TableCell className="binding"><Trans>Binding</Trans></TableCell>
-            <TableCell className="type"><Trans>Type</Trans></TableCell>
-            <TableCell className="type"><Trans>Namespace</Trans></TableCell>
-          </TableHead>
-          {
-            roleBinding.getSubjects().map((subject, i) => {
-              const { kind, name, namespace } = subject;
-              const isSelected = selectedSubjects.includes(subject);
-              return (
-                <TableRow
-                  key={i} selected={isSelected}
-                  onClick={prevDefault(() => this.selectSubject(subject))}
-                >
-                  <TableCell checkbox isChecked={isSelected}/>
-                  <TableCell className="binding">{name}</TableCell>
-                  <TableCell className="type">{kind}</TableCell>
-                  <TableCell className="ns">{namespace || "-"}</TableCell>
-                </TableRow>
-              )
-            })
-          }
-        </Table>
+        {subjects.length > 0 && (
+          <Table selectable className="bindings box grow">
+            <TableHead>
+              <TableCell checkbox/>
+              <TableCell className="binding"><Trans>Binding</Trans></TableCell>
+              <TableCell className="type"><Trans>Type</Trans></TableCell>
+              <TableCell className="type"><Trans>Namespace</Trans></TableCell>
+            </TableHead>
+            {
+              subjects.map((subject, i) => {
+                const { kind, name, namespace } = subject;
+                const isSelected = selectedSubjects.includes(subject);
+                return (
+                  <TableRow
+                    key={i} selected={isSelected}
+                    onClick={prevDefault(() => this.selectSubject(subject))}
+                  >
+                    <TableCell checkbox isChecked={isSelected}/>
+                    <TableCell className="binding">{name}</TableCell>
+                    <TableCell className="type">{kind}</TableCell>
+                    <TableCell className="ns">{namespace || "-"}</TableCell>
+                  </TableRow>
+                )
+              })
+            }
+          </Table>
+        )}
 
         <KubeEventDetails object={roleBinding}/>