From 3133c0a6b27659afe77a8155eecc6a2564f057a4 Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Mon, 9 May 2022 09:55:39 +0300 Subject: [PATCH] Tweak more naming Co-authored-by: Mikko Aspiala Signed-off-by: Janne Savolainen --- .../trigger-updating-using-tray.test.ts.snap | 6 +++--- .../update-app/trigger-updating-using-tray.test.ts | 8 ++++---- .../components/test-utils/get-application-builder.tsx | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/behaviours/update-app/__snapshots__/trigger-updating-using-tray.test.ts.snap b/src/behaviours/update-app/__snapshots__/trigger-updating-using-tray.test.ts.snap index fce1a17509..db6628682a 100644 --- a/src/behaviours/update-app/__snapshots__/trigger-updating-using-tray.test.ts.snap +++ b/src/behaviours/update-app/__snapshots__/trigger-updating-using-tray.test.ts.snap @@ -6,19 +6,19 @@ exports[`trigger updating using tray given no update available, when started ren `; -exports[`trigger updating using tray given no update available, when started when an update becomes available renders 1`] = ` +exports[`trigger updating using tray given no update available, when started when an update becomes ready to be installed renders 1`] = `
`; -exports[`trigger updating using tray given no update available, when started when an update becomes available when triggering installation of the update renders 1`] = ` +exports[`trigger updating using tray given no update available, when started when an update becomes ready to be installed when triggering installation of the update renders 1`] = `
`; -exports[`trigger updating using tray given no update available, when started when an update becomes available when update becomes unavailable renders 1`] = ` +exports[`trigger updating using tray given no update available, when started when an update becomes ready to be installed when update becomes unavailable renders 1`] = `
diff --git a/src/behaviours/update-app/trigger-updating-using-tray.test.ts b/src/behaviours/update-app/trigger-updating-using-tray.test.ts index 369cc7a047..db456447fd 100644 --- a/src/behaviours/update-app/trigger-updating-using-tray.test.ts +++ b/src/behaviours/update-app/trigger-updating-using-tray.test.ts @@ -43,9 +43,9 @@ describe("trigger updating using tray", () => { expect(trayItem).toBe(undefined); }); - describe("when an update becomes available", () => { + describe("when an update becomes ready to be installed", () => { beforeEach(() => { - applicationBuilder.applicationUpdater.makeUpdateAvailable(true); + applicationBuilder.applicationUpdater.setUpdateIsReadyToBeInstalled(true); }); it("renders", () => { @@ -78,14 +78,14 @@ describe("trigger updating using tray", () => { describe("when update becomes unavailable", () => { beforeEach(async () => { - applicationBuilder.applicationUpdater.makeUpdateAvailable(false); + applicationBuilder.applicationUpdater.setUpdateIsReadyToBeInstalled(false); }); it("renders", () => { expect(rendered.baseElement).toMatchSnapshot(); }); - it("does not have possibility to trigger installation of the update", () => { + it("does not have possibility to trigger installation of the update anymore", () => { const trayItem = applicationBuilder.tray.get("trigger-application-update"); expect(trayItem).toBe(undefined); diff --git a/src/renderer/components/test-utils/get-application-builder.tsx b/src/renderer/components/test-utils/get-application-builder.tsx index 1e863eacf3..828ef81f27 100644 --- a/src/renderer/components/test-utils/get-application-builder.tsx +++ b/src/renderer/components/test-utils/get-application-builder.tsx @@ -60,7 +60,7 @@ export interface ApplicationBuilder { render: () => Promise; applicationUpdater: { - makeUpdateAvailable: (available: boolean) => void; + setUpdateIsReadyToBeInstalled: (available: boolean) => void; }; tray: { @@ -157,7 +157,7 @@ export const getApplicationBuilder = () => { dis, applicationUpdater: { - makeUpdateAvailable: action((available: boolean) => { + setUpdateIsReadyToBeInstalled: action((available: boolean) => { const updateIsAvailableState = mainDi.inject(updateIsAvailableStateInjectable); updateIsAvailableState.set(available);