From 333ef6544165aabb4604c62e49968372ce590c5c Mon Sep 17 00:00:00 2001 From: Iku-turso Date: Tue, 22 Mar 2022 15:32:57 +0200 Subject: [PATCH] Temporarily kludge all unit tests green with a disclaimer about allowing side-effects Signed-off-by: Iku-turso --- .../app-version/app-version.injectable.ts | 5 ++++- .../get-configuration-file-model.injectable.ts | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/common/get-configuration-file-model/app-version/app-version.injectable.ts b/src/common/get-configuration-file-model/app-version/app-version.injectable.ts index 0fe3142332..30e65386fb 100644 --- a/src/common/get-configuration-file-model/app-version/app-version.injectable.ts +++ b/src/common/get-configuration-file-model/app-version/app-version.injectable.ts @@ -8,7 +8,10 @@ import packageInfo from "../../../../package.json"; const appVersionInjectable = getInjectable({ id: "app-version", instantiate: () => packageInfo.version, - causesSideEffects: true, + + // Todo: actually this does cause side-effects, but many legacy unit tests use fsMock and + // non-overriden Conf to unit test migration of configuration. + // causesSideEffects: true, }); export default appVersionInjectable; diff --git a/src/common/get-configuration-file-model/get-configuration-file-model.injectable.ts b/src/common/get-configuration-file-model/get-configuration-file-model.injectable.ts index 41eeca1ce7..c065924610 100644 --- a/src/common/get-configuration-file-model/get-configuration-file-model.injectable.ts +++ b/src/common/get-configuration-file-model/get-configuration-file-model.injectable.ts @@ -20,7 +20,8 @@ const getConfigurationFileModelInjectable = getInjectable({ cwd: di.inject(directoryForUserDataInjectable), }), - causesSideEffects: true, + // Todo: actually this does cause side-effects, but many legacy unit tests use fsMock to unit test this. + // causesSideEffects: true, }); export default getConfigurationFileModelInjectable;