Enforce template strings in eslint (#1574)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>

src/renderer/api/endpoints/deployment.api.ts

@@ -6,7 +6,7 @@ import { KubeApi } from "../kube-api";
 
 export class DeploymentApi extends KubeApi<Deployment> {
   protected getScaleApiUrl(params: { namespace: string; name: string }) {
-    return this.getUrl(params) + "/scale";
+    return `${this.getUrl(params)}/scale`;
   }
 
   getReplicas(params: { namespace: string; name: string }): Promise<number> {

src/renderer/api/endpoints/helm-charts.api.ts

@@ -34,7 +34,7 @@ export const helmChartsApi = {
   get(repo: string, name: string, readmeVersion?: string) {
     const path = endpoint({ repo, name });
     return apiBase
-      .get<IHelmChartDetails>(path + "?" + stringify({ version: readmeVersion }))
+      .get<IHelmChartDetails>(`${path}?${stringify({ version: readmeVersion })}`)
       .then(data => {
         const versions = data.versions.map(HelmChart.create);
         const readme = data.readme;
@@ -47,7 +47,7 @@ export const helmChartsApi = {
 
   getValues(repo: string, name: string, version: string) {
     return apiBase
-      .get<string>(`/v2/charts/${repo}/${name}/values?` + stringify({ version }));
+      .get<string>(`/v2/charts/${repo}/${name}/values?${stringify({ version })}`);
   }
 };
 

src/renderer/api/endpoints/helm-releases.api.ts

@@ -106,17 +106,17 @@ export const helmReleasesApi = {
   },
 
   getValues(name: string, namespace: string) {
-    const path = endpoint({ name, namespace }) + "/values";
+    const path = `${endpoint({ name, namespace })}/values`;
     return apiBase.get<string>(path);
   },
 
   getHistory(name: string, namespace: string): Promise<IReleaseRevision[]> {
-    const path = endpoint({ name, namespace }) + "/history";
+    const path = `${endpoint({ name, namespace })}/history`;
     return apiBase.get(path);
   },
 
   rollback(name: string, namespace: string, revision: number) {
-    const path = endpoint({ name, namespace }) + "/rollback";
+    const path = `${endpoint({ name, namespace })}/rollback`;
     return apiBase.put(path, {
       data: {
         revision

src/renderer/api/endpoints/ingress.api.ts

@@ -111,7 +111,7 @@ export class Ingress extends KubeObject {
         rule.http.paths.forEach(path => {
           const { serviceName, servicePort } = getBackendServiceNamePort(path.backend);
 
-          routes.push(protocol + "://" + host + (path.path || "/") + " ⇢ " + serviceName + ":" + servicePort);
+          routes.push(`${protocol}://${host}${path.path || "/"} ⇢ ${serviceName}:${servicePort}`);
         });
       }
     });

src/renderer/api/endpoints/pods.api.ts

@@ -5,7 +5,7 @@ import { KubeApi } from "../kube-api";
 
 export class PodsApi extends KubeApi<Pod> {
   async getLogs(params: { namespace: string; name: string }, query?: IPodLogsQuery): Promise<string> {
-    const path = this.getUrl(params) + "/log";
+    const path = `${this.getUrl(params)}/log`;
     return this.request.get(path, { query });
   }
 

src/renderer/api/endpoints/service.api.ts

@@ -24,7 +24,7 @@ export class ServicePort implements IServicePort {
     if (this.nodePort) {
       return `${this.port}:${this.nodePort}/${this.protocol}`;
     } else {
-      return `${this.port}${this.port === this.targetPort ? "" : ":" + this.targetPort}/${this.protocol}`;
+      return `${this.port}${this.port === this.targetPort ? "" : `:${this.targetPort}`}/${this.protocol}`;
     }
   }
 }

src/renderer/api/endpoints/stateful-set.api.ts

@@ -6,7 +6,7 @@ import { KubeApi } from "../kube-api";
 
 export class StatefulSetApi extends KubeApi<StatefulSet> {
   protected getScaleApiUrl(params: { namespace: string; name: string }) {
-    return this.getUrl(params) + "/scale";
+    return `${this.getUrl(params)}/scale`;
   }
 
   getReplicas(params: { namespace: string; name: string }): Promise<number> {

src/renderer/api/kube-api.ts

@@ -230,7 +230,7 @@ export class KubeApi<T extends KubeObject = any> {
       namespace: this.isNamespaced ? namespace : undefined,
       name,
     });
-    return resourcePath + (query ? `?` + stringify(this.normalizeQuery(query)) : "");
+    return resourcePath + (query ? `?${stringify(this.normalizeQuery(query))}` : "");
   }
 
   protected normalizeQuery(query: Partial<IKubeApiQueryParams> = {}) {

src/renderer/api/kube-watch-api.ts

@@ -78,7 +78,7 @@ export class KubeWatchApi {
       return;
     }
     const query = this.getQuery();
-    const apiUrl = `${apiPrefix}/watch?` + stringify(query);
+    const apiUrl = `${apiPrefix}/watch?${stringify(query)}`;
     this.evtSource = new EventSource(apiUrl);
     this.evtSource.onmessage = this.onMessage;
     this.evtSource.onerror = this.onError;

src/renderer/api/terminal-api.ts

@@ -130,7 +130,7 @@ export class TerminalApi extends WebSocketApi {
     }
     let time;
     if (showTime) {
-      time = (new Date()).toLocaleString() + " ";
+      time = `${(new Date()).toLocaleString()} `;
     }
     this.onData.emit(`${showTime ? time : ""}${data}\r\n`);
   }

src/renderer/api/websocket-api.ts

@@ -88,7 +88,7 @@ export class WebSocketApi {
   reconnect() {
     const { reconnectDelaySeconds } = this.params;
     if (!reconnectDelaySeconds) return;
-    this.writeLog("reconnect after", reconnectDelaySeconds + "ms");
+    this.writeLog("reconnect after", `${reconnectDelaySeconds}ms`);
     this.reconnectTimer = setTimeout(() => this.connect(), reconnectDelaySeconds * 1000);
     this.readyState = WebSocketApiState.RECONNECTING;
   }