diff --git a/src/features/cluster/__snapshots__/legacy-extension-adding-cluster-frame-components.test.tsx.snap b/src/features/cluster/__snapshots__/legacy-extension-adding-cluster-frame-components.test.tsx.snap index 7d9748dcbd..cac3136399 100644 --- a/src/features/cluster/__snapshots__/legacy-extension-adding-cluster-frame-components.test.tsx.snap +++ b/src/features/cluster/__snapshots__/legacy-extension-adding-cluster-frame-components.test.tsx.snap @@ -272,7 +272,9 @@ exports[`legacy extension adding cluster frame components given custom component -
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -2485,7 +2493,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
-
+
@@ -2939,7 +2949,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
-
+
@@ -3416,7 +3428,9 @@ exports[`cluster - sidebar and tab navigation for extensions given extension wit
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -919,7 +921,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -1562,7 +1566,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -2274,7 +2280,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -2964,7 +2972,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -3726,7 +3736,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -4490,7 +4502,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -5216,7 +5230,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -5937,7 +5953,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -6649,7 +6667,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -7361,7 +7381,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -8073,7 +8095,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -8620,7 +8644,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -9341,7 +9367,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -9888,7 +9916,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
@@ -10435,7 +10465,9 @@ exports[`cluster/namespaces - edit namespace from new tab when navigating to nam class="TabLayout" data-testid="tab-layout" > -
+
diff --git a/src/features/cluster/namespaces/__snapshots__/edit-namespace-from-previously-opened-tab.test.tsx.snap b/src/features/cluster/namespaces/__snapshots__/edit-namespace-from-previously-opened-tab.test.tsx.snap index f82cbc2e0e..580d1d22d9 100644 --- a/src/features/cluster/namespaces/__snapshots__/edit-namespace-from-previously-opened-tab.test.tsx.snap +++ b/src/features/cluster/namespaces/__snapshots__/edit-namespace-from-previously-opened-tab.test.tsx.snap @@ -298,7 +298,9 @@ exports[`cluster/namespaces - edit namespaces from previously opened tab given t
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -11909,7 +11935,9 @@ exports[`installing helm chart from new tab given tab for installing chart was n
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -946,7 +948,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
@@ -1703,7 +1707,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
@@ -2514,7 +2520,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
@@ -3361,7 +3369,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
@@ -4348,7 +4358,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
@@ -5337,7 +5349,9 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
-
+
diff --git a/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap b/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap index c6c950acf9..f92a9d5742 100644 --- a/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap +++ b/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap @@ -286,7 +286,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -1027,7 +1029,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -1773,7 +1777,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -2697,7 +2703,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -3682,7 +3690,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -4667,7 +4677,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -5897,7 +5909,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -7127,7 +7141,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -8357,7 +8373,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -9404,7 +9422,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -10453,7 +10473,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -11683,7 +11705,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -12668,7 +12692,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -13656,7 +13682,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -14580,7 +14608,9 @@ exports[`showing details for helm release given application is started when navi
-
+
@@ -15565,7 +15595,9 @@ exports[`showing details for helm release given application is started when navi
-
+
diff --git a/src/features/pod-logs/__snapshots__/download-logs.test.tsx.snap b/src/features/pod-logs/__snapshots__/download-logs.test.tsx.snap index 442d92dbe9..33e1deb85d 100644 --- a/src/features/pod-logs/__snapshots__/download-logs.test.tsx.snap +++ b/src/features/pod-logs/__snapshots__/download-logs.test.tsx.snap @@ -273,7 +273,9 @@ exports[`download logs options in logs dock tab opening pod logs when logs avail
-
+
-
+
{ const isMetricHidden = hostedCluster.isMetricHidden(ClusterMetricsResourceType.Cluster); return ( - +
{this.renderClusterOverview(isLoaded, isMetricHidden)}
diff --git a/src/renderer/components/+workloads-overview/overview.tsx b/src/renderer/components/+workloads-overview/overview.tsx index 83a2bf9e84..7c93bd429c 100644 --- a/src/renderer/components/+workloads-overview/overview.tsx +++ b/src/renderer/components/+workloads-overview/overview.tsx @@ -103,7 +103,7 @@ class NonInjectedWorkloadsOverview extends React.Component { render() { return ( - +
Overview
diff --git a/src/renderer/components/item-object-list/item-list-layout.scss b/src/renderer/components/item-object-list/item-list-layout.scss index 254be55936..84427369ad 100644 --- a/src/renderer/components/item-object-list/item-list-layout.scss +++ b/src/renderer/components/item-object-list/item-list-layout.scss @@ -31,7 +31,7 @@ > .items { position: relative; - min-height: 200px; + min-height: 130px; } } diff --git a/src/renderer/components/layout/main-layout.module.scss b/src/renderer/components/layout/main-layout.module.scss index fad743041c..e882310427 100644 --- a/src/renderer/components/layout/main-layout.module.scss +++ b/src/renderer/components/layout/main-layout.module.scss @@ -23,9 +23,7 @@ } .contents { - grid-area: contents; - overflow: auto; - height: calc(100vh - var(--status-bar-height) - var(--main-layout-header)); + overflow: hidden; } .footer { diff --git a/src/renderer/components/layout/siblings-in-tab-layout.tsx b/src/renderer/components/layout/siblings-in-tab-layout.tsx index 04f53c0f85..06e57227e9 100644 --- a/src/renderer/components/layout/siblings-in-tab-layout.tsx +++ b/src/renderer/components/layout/siblings-in-tab-layout.tsx @@ -12,6 +12,7 @@ import type { HierarchicalSidebarItem } from "./sidebar-items.injectable"; interface SiblingTabLayoutProps { children: React.ReactNode; + scrollable?: boolean; } interface Dependencies { @@ -19,13 +20,14 @@ interface Dependencies { } const NonInjectedSiblingsInTabLayout = observer( - ({ tabs, children }: Dependencies & SiblingTabLayoutProps) => { + ({ tabs, children, ...other }: Dependencies & SiblingTabLayoutProps) => { const dereferencedTabs = tabs.get(); if (dereferencedTabs.length) { return ( {children} diff --git a/src/renderer/components/layout/tab-layout-2.tsx b/src/renderer/components/layout/tab-layout-2.tsx index 935e4b9368..7d81c58d34 100644 --- a/src/renderer/components/layout/tab-layout-2.tsx +++ b/src/renderer/components/layout/tab-layout-2.tsx @@ -15,11 +15,13 @@ import type { HierarchicalSidebarItem } from "./sidebar-items.injectable"; export interface TabLayoutProps { tabs?: HierarchicalSidebarItem[]; children?: React.ReactNode; + scrollable?: boolean; } export const TabLayout = observer( ({ tabs = [], + scrollable, children, }: TabLayoutProps) => { const hasTabs = tabs.length > 0; @@ -50,7 +52,7 @@ export const TabLayout = observer( )} -
+
{children} diff --git a/src/renderer/components/layout/tab-layout.scss b/src/renderer/components/layout/tab-layout.scss index c447f77eea..7ab3395e15 100755 --- a/src/renderer/components/layout/tab-layout.scss +++ b/src/renderer/components/layout/tab-layout.scss @@ -11,16 +11,20 @@ > .Tabs { background: var(--layoutTabsBackground); - min-height: 32px; + min-height: 36px; } main { $spacing: $margin * 2; flex-grow: 1; - overflow-y: scroll; // always reserve space for scrollbar (17px) + overflow-y: hidden; overflow-x: auto; margin: $spacing; - margin-right: 0; + + &.scrollable { + overflow-y: scroll; + margin-right: 0; + } } } diff --git a/src/renderer/components/layout/tab-layout.tsx b/src/renderer/components/layout/tab-layout.tsx index 07684ef28d..e12cebd648 100644 --- a/src/renderer/components/layout/tab-layout.tsx +++ b/src/renderer/components/layout/tab-layout.tsx @@ -20,6 +20,7 @@ export interface TabLayoutProps { contentClass?: IClassName; tabs?: TabLayoutRoute[]; children?: ReactNode; + scrollable?: boolean; } export interface TabLayoutRoute { @@ -31,7 +32,7 @@ export interface TabLayoutRoute { default?: boolean; // initial tab to open with provided `url, by default tabs[0] is used } -export const TabLayout = observer(({ className, contentClass, tabs = [], children }: TabLayoutProps) => { +export const TabLayout = observer(({ className, contentClass, tabs = [], scrollable, children }: TabLayoutProps) => { const currentLocation = navigation.location.pathname; const hasTabs = tabs.length > 0; const startTabUrl = hasTabs ? (tabs.find(tab => tab.default) || tabs[0])?.url : null; @@ -50,7 +51,7 @@ export const TabLayout = observer(({ className, contentClass, tabs = [], childre ))} )} -
+
{hasTabs && ( diff --git a/src/renderer/components/table/table.scss b/src/renderer/components/table/table.scss index 982c896101..a76f9c116f 100644 --- a/src/renderer/components/table/table.scss +++ b/src/renderer/components/table/table.scss @@ -14,6 +14,10 @@ overflow: auto; } + &.scrollable.virtual { + overflow: unset; + } + &.selectable { .TableHead, .TableRow { padding: 0 $padding; diff --git a/src/renderer/frames/cluster-frame/__snapshots__/cluster-frame.test.tsx.snap b/src/renderer/frames/cluster-frame/__snapshots__/cluster-frame.test.tsx.snap index d629d85798..eb8b67f8ff 100644 --- a/src/renderer/frames/cluster-frame/__snapshots__/cluster-frame.test.tsx.snap +++ b/src/renderer/frames/cluster-frame/__snapshots__/cluster-frame.test.tsx.snap @@ -786,7 +786,7 @@ exports[` given cluster with list nodes and namespaces permissio class="TabLayout" >
given cluster without list nodes, but with namespaces
-
+