From 36544f22aae050f1a8162fd27173011254f4a711 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Wed, 27 Apr 2022 12:38:54 -0400 Subject: [PATCH] make Select snapshots deterministic Signed-off-by: Sebastian Malton --- .../closing-preferences.test.tsx.snap | 48 +++++++++---------- ...on-to-application-preferences.test.ts.snap | 24 +++++----- ...igation-to-editor-preferences.test.ts.snap | 36 +++++++------- ...tension-specific-preferences.test.tsx.snap | 48 +++++++++---------- ...ion-to-kubernetes-preferences.test.ts.snap | 36 +++++++------- ...vigation-to-proxy-preferences.test.ts.snap | 24 +++++----- ...ion-to-telemetry-preferences.test.tsx.snap | 48 +++++++++---------- ...ation-to-terminal-preferences.test.ts.snap | 30 ++++++------ ...gation-using-application-menu.test.ts.snap | 24 +++++----- src/renderer/components/select/select.tsx | 11 +++-- 10 files changed, 166 insertions(+), 163 deletions(-) diff --git a/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap b/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap index eafa941325..cb4973203d 100644 --- a/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap +++ b/src/behaviours/preferences/__snapshots__/closing-preferences.test.tsx.snap @@ -124,7 +124,7 @@ exports[`preferences - closing-preferences given accessing preferences directly >
Select...
@@ -150,7 +150,7 @@ exports[`preferences - closing-preferences given accessing preferences directly >
Select...
@@ -235,7 +235,7 @@ exports[`preferences - closing-preferences given accessing preferences directly >
Select...
@@ -370,7 +370,7 @@ exports[`preferences - closing-preferences given accessing preferences directly >
Select...
@@ -455,7 +455,7 @@ exports[`preferences - closing-preferences given accessing preferences directly >
Select...
@@ -848,7 +848,7 @@ exports[`preferences - closing-preferences given already in a page and then navi >
Select...
@@ -933,7 +933,7 @@ exports[`preferences - closing-preferences given already in a page and then navi >
Select...
@@ -1068,7 +1068,7 @@ exports[`preferences - closing-preferences given already in a page and then navi >
Select...
@@ -1153,7 +1153,7 @@ exports[`preferences - closing-preferences given already in a page and then navi >
Select...
@@ -340,7 +340,7 @@ exports[`preferences - navigation to application preferences given in some child >
Select...
@@ -425,7 +425,7 @@ exports[`preferences - navigation to application preferences given in some child >
Select...
@@ -560,7 +560,7 @@ exports[`preferences - navigation to application preferences given in some child >
Select...
@@ -645,7 +645,7 @@ exports[`preferences - navigation to application preferences given in some child >
Select...
@@ -138,7 +138,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -223,7 +223,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -358,7 +358,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -443,7 +443,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -689,7 +689,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -773,7 +773,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh >
Select...
@@ -138,7 +138,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -223,7 +223,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -358,7 +358,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -443,7 +443,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -678,7 +678,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -763,7 +763,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -898,7 +898,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -983,7 +983,7 @@ exports[`preferences - navigation to extension specific preferences given in pre >
Select...
@@ -138,7 +138,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Select...
@@ -223,7 +223,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Select...
@@ -358,7 +358,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Select...
@@ -443,7 +443,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Download mirror for kubectl
@@ -685,7 +685,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Repositories
@@ -866,7 +866,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences >
Select...
@@ -138,7 +138,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe >
Select...
@@ -223,7 +223,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe >
Select...
@@ -358,7 +358,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe >
Select...
@@ -443,7 +443,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe >
Select...
@@ -326,7 +326,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -411,7 +411,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -546,7 +546,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -631,7 +631,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -866,7 +866,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -951,7 +951,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -1086,7 +1086,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -1171,7 +1171,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences, >
Select...
@@ -138,7 +138,7 @@ exports[`preferences - navigation to terminal preferences given in preferences, >
Select...
@@ -223,7 +223,7 @@ exports[`preferences - navigation to terminal preferences given in preferences, >
Select...
@@ -358,7 +358,7 @@ exports[`preferences - navigation to terminal preferences given in preferences, >
Select...
@@ -443,7 +443,7 @@ exports[`preferences - navigation to terminal preferences given in preferences, >
Select...
@@ -710,7 +710,7 @@ exports[`preferences - navigation to terminal preferences given in preferences, >
Select...
@@ -140,7 +140,7 @@ exports[`preferences - navigation using application menu when navigating to pref >
Select...
@@ -225,7 +225,7 @@ exports[`preferences - navigation using application menu when navigating to pref >
Select...
@@ -360,7 +360,7 @@ exports[`preferences - navigation using application menu when navigating to pref >
Select...
@@ -445,7 +445,7 @@ exports[`preferences - navigation using application menu when navigating to pref > ( typeof option === "string" @@ -193,6 +195,7 @@ class NonInjectedSelect< }), ...styles, }} + instanceId={inputId} inputId={inputId} filterOption={defaultFilter} // This is done because the default filter crashes on symbols isMulti={isMulti} @@ -204,10 +207,10 @@ class NonInjectedSelect< onChange={action(onChange)} // This is done so that all changes are actionable components={{ ...components, - Menu: props => ( + Menu: ({ className, ...props }) => ( ), }}