From 36caecb1c68f670859e22a2412b6c73dbba85b0b Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Thu, 5 Jan 2023 11:03:13 -0500
Subject: [PATCH] Fix sidebar-and-tab-navigation-for-core tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 ...-and-tab-navigation-for-core.test.tsx.snap | 24 +++++++++++++++++--
 ...debar-and-tab-navigation-for-core.test.tsx |  9 ++-----
 2 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/src/features/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap b/src/features/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
index 3e2fc55502..3f79b3e219 100644
--- a/src/features/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
+++ b/src/features/cluster/__snapshots__/sidebar-and-tab-navigation-for-core.test.tsx.snap
@@ -2824,12 +2824,32 @@ exports[`cluster - sidebar and tab navigation for core given core registrations
               >
                 <span
                   class="icon"
-                  data-icon-name="keyboard_arrow_down"
+                  data-icon-name="keyboard_arrow_up"
                 >
-                  keyboard_arrow_down
+                  keyboard_arrow_up
                 </span>
               </i>
             </a>
+            <ul
+              class="subMenu"
+            >
+              <div
+                class="SidebarItem"
+                data-is-active-test="false"
+                data-parent-id-test="some-parent-id"
+                data-testid="sidebar-item-some-child-id"
+              >
+                <a
+                  class="navItem"
+                  data-testid="sidebar-item-link-for-some-child-id"
+                  href="/"
+                >
+                  <span>
+                    Some child
+                  </span>
+                </a>
+              </div>
+            </ul>
           </div>
           <div
             class="SidebarItem"
diff --git a/src/features/cluster/sidebar-and-tab-navigation-for-core.test.tsx b/src/features/cluster/sidebar-and-tab-navigation-for-core.test.tsx
index 90dfc500b2..26f0bb253b 100644
--- a/src/features/cluster/sidebar-and-tab-navigation-for-core.test.tsx
+++ b/src/features/cluster/sidebar-and-tab-navigation-for-core.test.tsx
@@ -21,7 +21,6 @@ import writeJsonFileInjectable from "../../common/fs/write-json-file.injectable"
 import pathExistsInjectable from "../../common/fs/path-exists.injectable";
 import readJsonFileInjectable from "../../common/fs/read-json-file.injectable";
 import { navigateToRouteInjectionToken } from "../../common/front-end-routing/navigate-to-route-injection-token";
-import sidebarStorageInjectable from "../../renderer/components/layout/sidebar-storage/sidebar-storage.injectable";
 import { advanceFakeTime, testUsingFakeTime } from "../../common/test-utils/use-fake-time";
 import storageSaveDelayInjectable from "../../renderer/utils/create-storage/storage-save-delay.injectable";
 import { flushPromises } from "../../common/test-utils/flush-promises";
@@ -94,9 +93,9 @@ describe("cluster - sidebar and tab navigation for core", () => {
     describe("given state for expanded sidebar items already exists, when rendered", () => {
       beforeEach(async () => {
         builder.beforeWindowStart(async (windowDi) => {
-          const writeJsonFileFake = windowDi.inject(writeJsonFileInjectable);
+          const writeJsonFile = windowDi.inject(writeJsonFileInjectable);
 
-          await writeJsonFileFake(
+          await writeJsonFile(
             "/some-directory-for-lens-local-storage/some-cluster-id.json",
             {
               sidebar: {
@@ -105,10 +104,6 @@ describe("cluster - sidebar and tab navigation for core", () => {
               },
             },
           );
-
-          const sidebarStorage = windowDi.inject(sidebarStorageInjectable);
-
-          await sidebarStorage.whenReady;
         });
 
         rendered = await builder.render();