From 37318cab4e14e4c52c9d0c1f8ac536bed4e3aae6 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Thu, 1 Sep 2022 12:52:55 +0300 Subject: [PATCH] Fix: align sidebar menu items (#6138) * Introduce sitebar-items.module.scss Signed-off-by: Alex Andreev * Adjust sidebar item styles Signed-off-by: Alex Andreev * Use classnames from a scss module Signed-off-by: Alex Andreev * Set sidebar min width to 150px to keep readability Signed-off-by: Alex Andreev * Break words in long links Signed-off-by: Alex Andreev * Adjust navigation paddings Signed-off-by: Alex Andreev * Remove unused scss file Signed-off-by: Alex Andreev * Updating bunch of snapshots Signed-off-by: Alex Andreev Signed-off-by: Alex Andreev --- .../order-of-sidebar-items.test.tsx.snap | 160 +-- ...-and-tab-navigation-for-core.test.tsx.snap | 430 +++---- ...ab-navigation-for-extensions.test.tsx.snap | 520 +++----- .../visibility-of-sidebar-items.test.tsx.snap | 112 +- ...when-cluster-is-not-relevant.test.tsx.snap | 150 +-- ...when-cluster-is-not-relevant.test.tsx.snap | 156 +-- ...when-cluster-is-not-relevant.test.tsx.snap | 150 +-- ...when-cluster-is-not-relevant.test.tsx.snap | 150 +-- ...how-status-for-a-kube-object.test.tsx.snap | 300 ++--- ...when-cluster-is-not-relevant.test.tsx.snap | 150 +-- .../edit-namespace-from-new-tab.test.tsx.snap | 896 +++++--------- ...e-from-previously-opened-tab.test.tsx.snap | 112 +- ...when-cluster-is-not-relevant.test.tsx.snap | 150 +-- ...lling-helm-chart-from-new-tab.test.ts.snap | 1050 ++++++----------- ...rt-from-previously-opened-tab.test.ts.snap | 100 +- ...tab-for-installing-helm-chart.test.ts.snap | 400 +++---- ...wing-details-for-helm-release.test.ts.snap | 800 +++++-------- .../components/layout/main-layout.tsx | 2 +- .../components/layout/sidebar-item.scss | 97 -- .../components/layout/sidebar-item.tsx | 16 +- .../layout/sidebar-items.module.scss | 63 + .../components/layout/sidebar.module.scss | 1 - .../__snapshots__/cluster-frame.test.tsx.snap | 192 ++- 23 files changed, 2219 insertions(+), 3938 deletions(-) delete mode 100644 src/renderer/components/layout/sidebar-item.scss create mode 100644 src/renderer/components/layout/sidebar-items.module.scss diff --git a/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap b/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap index b9d854220c..7f76811494 100644 --- a/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap +++ b/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap @@ -39,7 +39,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` > @@ -87,9 +85,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` list - + Config @@ -100,17 +96,15 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` data-testid="sidebar-item-some-parent-id" > @@ -178,9 +170,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` storage - + Storage @@ -191,13 +181,11 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` data-testid="sidebar-item-some-another-parent-id" > - + Some another parent @@ -208,7 +196,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` data-testid="sidebar-item-helm" > @@ -256,9 +242,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` security - + Access Control @@ -269,7 +253,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = ` data-testid="sidebar-item-custom-resources" > - + Some other parent @@ -619,7 +599,7 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded > @@ -667,9 +645,7 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded list - + Config @@ -680,17 +656,15 @@ exports[`cluster - order of sidebar items when rendered when parent is expanded data-testid="sidebar-item-some-parent-id" >