1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Remove unnecessary overloading.

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This commit is contained in:
Panu Horsmalahti 2021-11-17 10:28:20 +02:00
parent 57c8c7b9a0
commit 38181f7b45

View File

@ -68,19 +68,4 @@ export class CatalogEntityStore extends ItemStore<CatalogEntityItem<CatalogEntit
// concurrency is true to fix bug if catalog filter is removed and added at the same time // concurrency is true to fix bug if catalog filter is removed and added at the same time
return this.loadItems(() => this.entities, undefined, true); return this.loadItems(() => this.entities, undefined, true);
} }
/**
* Override ItemStore::loadItems, the only difference is that
* if isLoading is true, we await for it to be false and then continue
* loading.
* This avoids a bug where if there were two or more concurrent loadItems() calls,
* only the first one would complete.
*/
protected loadItems(
request: (() => Promise<CatalogEntityItem<CatalogEntity>[] | any>) | (() => CatalogEntityItem<CatalogEntity>[] | any),
sortItems = true,
concurrency = false,
) {
return super.loadItems(request, sortItems, concurrency);
}
} }