Fix tar file being removed before extension install (#2689)

This commit is contained in:
Sebastian Malton authored and GitHub committed 2021-05-03 16:56:09 -04:00
1 parent bf0dc84c22
commit 38593e4609
1 file changed
+2 -4
@@ -166,15 +166,13 @@ async function validatePackage(filePath: string): Promise<LensExtensionManifest>
return manifest;
}
async function createTempFilesAndValidate({ fileName, dataP }: InstallRequest, disposer: ExtendableDisposer): Promise<InstallRequestValidated | null> {
async function createTempFilesAndValidate({ fileName, dataP }: InstallRequest): Promise<InstallRequestValidated | null> {
// copy files to temp
await fse.ensureDir(getExtensionPackageTemp());
// validate packages
const tempFile = getExtensionPackageTemp(fileName);
disposer.push(() => fse.unlink(tempFile));
try {
const data = await dataP;
@@ -317,7 +315,7 @@ export async function attemptInstallByInfo({ name, version, requireConfirmation
async function attemptInstall(request: InstallRequest, d?: ExtendableDisposer): Promise<void> {
const dispose = disposer(ExtensionInstallationStateStore.startPreInstall(), d);
const validatedRequest = await createTempFilesAndValidate(request, dispose);
const validatedRequest = await createTempFilesAndValidate(request);
if (!validatedRequest) {
return dispose();