hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix tar file being removed before extension install (#2689)

Browse Source
This commit is contained in:
Sebastian Malton 2021-05-03 16:56:09 -04:00 committed by GitHub
parent bf0dc84c22
commit 38593e4609
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderer/components/+extensions/extensions.tsx
View File

@ -166,15 +166,13 @@ async function validatePackage(filePath: string): Promise<LensExtensionManifest>
return manifest; return manifest;
} }
async function createTempFilesAndValidate({ fileName, dataP }: InstallRequest, disposer: ExtendableDisposer): Promise<InstallRequestValidated | null> { async function createTempFilesAndValidate({ fileName, dataP }: InstallRequest): Promise<InstallRequestValidated | null> {
// copy files to temp // copy files to temp
await fse.ensureDir(getExtensionPackageTemp()); await fse.ensureDir(getExtensionPackageTemp());
// validate packages // validate packages
const tempFile = getExtensionPackageTemp(fileName); const tempFile = getExtensionPackageTemp(fileName);
disposer.push(() => fse.unlink(tempFile));
try { try {
const data = await dataP; const data = await dataP;
@ -317,7 +315,7 @@ export async function attemptInstallByInfo({ name, version, requireConfirmation
async function attemptInstall(request: InstallRequest, d?: ExtendableDisposer): Promise<void> { async function attemptInstall(request: InstallRequest, d?: ExtendableDisposer): Promise<void> {
const dispose = disposer(ExtensionInstallationStateStore.startPreInstall(), d); const dispose = disposer(ExtensionInstallationStateStore.startPreInstall(), d);
const validatedRequest = await createTempFilesAndValidate(request, dispose); const validatedRequest = await createTempFilesAndValidate(request);
if (!validatedRequest) { if (!validatedRequest) {
return dispose(); return dispose();