mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Upgrade to latest for all linting deps (#4755)
* Upgrade to eslint latest Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix OOM error Signed-off-by: Sebastian Malton <sebastian@malton.name> * resolve PR comments Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
1 parent
2ad78c2a86
commit
38790eb886
35 files changed
+284
-470
No files matched your search
@@ -5,8 +5,7 @@
|
||||
|
||||
import "./icon.scss";
|
||||
|
||||
import React, { ReactNode } from "react";
|
||||
import { findDOMNode } from "react-dom";
|
||||
import React, { createRef, ReactNode } from "react";
|
||||
import { NavLink } from "react-router-dom";
|
||||
import type { LocationDescriptor } from "history";
|
||||
import { boundMethod, cssNames } from "../../utils";
|
||||
@@ -31,6 +30,8 @@ export interface IconProps extends React.HTMLAttributes<any>, TooltipDecoratorPr
|
||||
|
||||
@withTooltip
|
||||
export class Icon extends React.PureComponent<IconProps> {
|
||||
private readonly ref = createRef<HTMLAnchorElement>();
|
||||
|
||||
static defaultProps: IconProps = {
|
||||
focusable: true,
|
||||
};
|
||||
@@ -59,10 +60,7 @@ export class Icon extends React.PureComponent<IconProps> {
|
||||
|
||||
// fallthrough
|
||||
case "Enter": {
|
||||
// eslint-disable-next-line react/no-find-dom-node
|
||||
const icon = findDOMNode(this) as HTMLElement;
|
||||
|
||||
setTimeout(() => icon.click());
|
||||
this.ref.current?.click();
|
||||
evt.preventDefault();
|
||||
break;
|
||||
}
|
||||
@@ -123,16 +121,16 @@ export class Icon extends React.PureComponent<IconProps> {
|
||||
const { className, children } = iconProps;
|
||||
|
||||
return (
|
||||
<NavLink className={className} to={link}>
|
||||
<NavLink className={className} to={link} ref={this.ref}>
|
||||
{children}
|
||||
</NavLink>
|
||||
);
|
||||
}
|
||||
|
||||
if (href) {
|
||||
return <a {...iconProps} href={href}/>;
|
||||
return <a {...iconProps} href={href} ref={this.ref}/>;
|
||||
}
|
||||
|
||||
return <i {...iconProps} />;
|
||||
return <i {...iconProps} ref={this.ref} />;
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user