From 3a7f53f400532515e6bd0c7773bb5ed807b1aad2 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Fri, 23 Apr 2021 11:37:04 -0400
Subject: [PATCH] Add default getId and getName impls

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 .../catalog-entities/kubernetes-cluster.ts       | 12 ------------
 src/common/catalog-entities/web-link.ts          | 14 +-------------
 src/common/catalog/catalog-entity.ts             | 16 ++++++++++++----
 3 files changed, 13 insertions(+), 29 deletions(-)

diff --git a/src/common/catalog-entities/kubernetes-cluster.ts b/src/common/catalog-entities/kubernetes-cluster.ts
index d4949be70a..747e042efd 100644
--- a/src/common/catalog-entities/kubernetes-cluster.ts
+++ b/src/common/catalog-entities/kubernetes-cluster.ts
@@ -19,14 +19,6 @@ export class KubernetesCluster extends CatalogEntity<CatalogEntityMetadata, Kube
   public readonly apiVersion = "entity.k8slens.dev/v1alpha1";
   public readonly kind = "KubernetesCluster";
 
-  getId() {
-    return this.metadata.uid;
-  }
-
-  getName() {
-    return this.metadata.name;
-  }
-
   async onRun(context: CatalogEntityActionContext) {
     context.navigate(`/cluster/${this.metadata.uid}`);
   }
@@ -108,10 +100,6 @@ export class KubernetesClusterCategory extends CatalogCategory {
       });
     });
   }
-
-  getId() {
-    return `${this.spec.group}/${this.spec.names.kind}`;
-  }
 }
 
 catalogCategoryRegistry.add(new KubernetesClusterCategory());
diff --git a/src/common/catalog-entities/web-link.ts b/src/common/catalog-entities/web-link.ts
index b8180010eb..24a1893c19 100644
--- a/src/common/catalog-entities/web-link.ts
+++ b/src/common/catalog-entities/web-link.ts
@@ -13,14 +13,6 @@ export class WebLink extends CatalogEntity<CatalogEntityMetadata, WebLinkStatus,
   public readonly apiVersion = "entity.k8slens.dev/v1alpha1";
   public readonly kind = "KubernetesCluster";
 
-  getId() {
-    return this.metadata.uid;
-  }
-
-  getName() {
-    return this.metadata.name;
-  }
-
   async onRun() {
     window.open(this.spec.url, "_blank");
   }
@@ -33,7 +25,7 @@ export class WebLink extends CatalogEntity<CatalogEntityMetadata, WebLinkStatus,
     return;
   }
 
-  public onContextMenuOpen() {
+  public onContextMenuOpen(): void {
     return;
   }
 }
@@ -57,10 +49,6 @@ export class WebLinkCategory extends CatalogCategory {
       kind: "WebLink"
     }
   };
-
-  getId() {
-    return `${this.spec.group}/${this.spec.names.kind}`;
-  }
 }
 
 catalogCategoryRegistry.add(new WebLinkCategory());
diff --git a/src/common/catalog/catalog-entity.ts b/src/common/catalog/catalog-entity.ts
index 141df3b7b3..fdd443ae54 100644
--- a/src/common/catalog/catalog-entity.ts
+++ b/src/common/catalog/catalog-entity.ts
@@ -35,7 +35,9 @@ export abstract class CatalogCategory extends EventEmitter {
   };
   abstract spec: CatalogCategorySpec;
 
-  public abstract getId(): string;
+  public getId(): string {
+    return `${this.spec.group}/${this.spec.names.kind}`;
+  }
 }
 
 export interface CatalogEntityMetadata {
@@ -126,9 +128,15 @@ export abstract class CatalogEntity<
     this.spec = data.spec;
   }
 
-  public abstract getId(): string;
-  public abstract getName(): string;
-  public abstract onRun(context: CatalogEntityActionContext): void | Promise<void>;
+  public getId(): string {
+    return this.metadata.uid;
+  }
+
+  public getName(): string {
+    return this.metadata.name;
+  }
+
+  public abstract onRun?(context: CatalogEntityActionContext): void | Promise<void>;
   public abstract onDetailsOpen(context: CatalogEntityActionContext): void | Promise<void>;
   public abstract onContextMenuOpen(context: CatalogEntityContextMenuContext): void | Promise<void>;
   public abstract onSettingsOpen(context: CatalogEntitySettingsContext): void | Promise<void>;