diff --git a/extensions/support-page/main.ts b/extensions/support-page/main.ts index 7ef5683c8f..333411ec16 100644 --- a/extensions/support-page/main.ts +++ b/extensions/support-page/main.ts @@ -1,4 +1,4 @@ -import { LensMainExtension, Navigation } from "@k8slens/extensions"; +import { LensMainExtension } from "@k8slens/extensions"; import { supportPageURL } from "./src/support.route"; export default class SupportPageMainExtension extends LensMainExtension { @@ -6,8 +6,8 @@ export default class SupportPageMainExtension extends LensMainExtension { { parentId: "help", label: "Support", - click() { - Navigation.navigate(supportPageURL()); + click: () => { + this.navigate(supportPageURL()); } } ] diff --git a/extensions/support-page/package-lock.json b/extensions/support-page/package-lock.json index f67bf34b5f..a93741c0aa 100644 --- a/extensions/support-page/package-lock.json +++ b/extensions/support-page/package-lock.json @@ -26,6 +26,12 @@ "integrity": "sha512-3c+yGKvVP5Y9TYBEibGNR+kLtijnj7mYrXRg+WpFb2X9xm04g/DXYkfg4hmzJQosc9snFNUPkbYIhu+KAm6jJw==", "dev": true }, + "@types/node": { + "version": "14.14.7", + "resolved": "https://registry.npmjs.org/@types/node/-/node-14.14.7.tgz", + "integrity": "sha512-Zw1vhUSQZYw+7u5dAwNbIA9TuTotpzY/OF7sJM9FqPOF3SPjKnxrjoTktXDZgUjybf4cWVBP7O8wvKdSaGHweg==", + "dev": true + }, "@types/prop-types": { "version": "15.7.3", "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.3.tgz", diff --git a/src/extensions/core-api/index.ts b/src/extensions/core-api/index.ts index 77a85de0dc..1c4432cc57 100644 --- a/src/extensions/core-api/index.ts +++ b/src/extensions/core-api/index.ts @@ -8,13 +8,11 @@ import * as EventBus from "./event-bus" import * as Store from "./stores" import * as Util from "./utils" import * as ClusterFeature from "./cluster-feature" -import * as Navigation from "./navigation" export { App, EventBus, ClusterFeature, - Navigation, Store, Util, } diff --git a/src/extensions/core-api/navigation.ts b/src/extensions/core-api/navigation.ts deleted file mode 100644 index f480ea58ba..0000000000 --- a/src/extensions/core-api/navigation.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { ipcMain } from "electron"; -import { WindowManager } from "../../main/window-manager"; -import { navigate as navRenderer } from "../../renderer/navigation"; -export { hideDetails, showDetails, getDetailsUrl } from "../../renderer/navigation" -export { RouteProps } from "react-router" -export { IURLParams } from "../../common/utils/buildUrl"; - -export async function navigate(location: string) { - if (ipcMain) { - await WindowManager.getInstance().navigate(location) - } else { - navRenderer(location) - } -} diff --git a/src/extensions/lens-main-extension.ts b/src/extensions/lens-main-extension.ts index 8e300bda77..5e5aa073f3 100644 --- a/src/extensions/lens-main-extension.ts +++ b/src/extensions/lens-main-extension.ts @@ -1,7 +1,12 @@ import type { MenuRegistration } from "./registries/menu-registry"; import { observable } from "mobx"; import { LensExtension } from "./lens-extension" +import { WindowManager } from "../main/window-manager"; export class LensMainExtension extends LensExtension { @observable.shallow appMenus: MenuRegistration[] = [] + + async navigate(location: string, frameId?: number) { + await WindowManager.getInstance().navigate(location, frameId) + } } diff --git a/src/extensions/renderer-api/index.ts b/src/extensions/renderer-api/index.ts index 89f5c10e1a..6fe7c2bbdc 100644 --- a/src/extensions/renderer-api/index.ts +++ b/src/extensions/renderer-api/index.ts @@ -3,8 +3,10 @@ // APIs import * as Component from "./components" import * as K8sApi from "./k8s-api" +import * as Navigation from "./navigation" export { Component, K8sApi, + Navigation }