From 3e7315a2c83f75f15147126f7f2118584d553c0d Mon Sep 17 00:00:00 2001 From: Lauri Nevala Date: Wed, 2 Dec 2020 10:51:50 +0200 Subject: [PATCH] Fix getExtensionPageUrl on Windows Signed-off-by: Lauri Nevala --- src/extensions/registries/page-registry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/extensions/registries/page-registry.ts b/src/extensions/registries/page-registry.ts index 188a6aa8b3..08200c6d3a 100644 --- a/src/extensions/registries/page-registry.ts +++ b/src/extensions/registries/page-registry.ts @@ -44,7 +44,7 @@ export function getExtensionPageUrl

({ extensionId, pageId = "" const extensionBaseUrl = compile(`/extension/:name`)({ name: sanitizeExtensionName(extensionId), // compile only with extension-id first and define base path }); - const extPageRoutePath = path.join(extensionBaseUrl, pageId); // page-id might contain route :param-s, so don't compile yet + const extPageRoutePath = path.join(extensionBaseUrl, pageId).replace(/\\/g, "/"); // path.join returns \ as separator on Windows and needs to be replaced with / if (params) { return compile(extPageRoutePath)(params); // might throw error when required params not passed