hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

do not assume that bitnami is guanteed to be in the helm repo list (#1960)

Browse Source 
* do not assume that bitnami is guanteed to be in the helm repo list

* more robust test by checking for added helm repos

Co-authored-by: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2021-01-18 11:23:50 -05:00 committed by GitHub
parent 487338269a
commit 41e012d83f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
integration/__tests__/app.tests.ts
View File

@ -5,8 +5,11 @@
cluster and vice versa. cluster and vice versa.
*/ */
import { Application } from "spectron"; import { Application } from "spectron";
import * as util from "../helpers/utils"; import * as utils from "../helpers/utils";
import { spawnSync } from "child_process"; import { spawnSync, exec } from "child_process";
import * as util from "util";
export const promiseExec = util.promisify(exec);
jest.setTimeout(60000); jest.setTimeout(60000);
@ -16,7 +19,7 @@ describe("Lens integration tests", () => {
const BACKSPACE = "\uE003"; const BACKSPACE = "\uE003";
let app: Application; let app: Application;
const appStart = async () => { const appStart = async () => {
app = util.setup(); app = utils.setup();
await app.start(); await app.start();
// Wait for splash screen to be closed // Wait for splash screen to be closed
while (await app.client.getWindowCount() > 1); while (await app.client.getWindowCount() > 1);
@ -71,7 +74,7 @@ describe("Lens integration tests", () => {
afterAll(async () => { afterAll(async () => {
if (app?.isRunning()) { if (app?.isRunning()) {
await util.tearDown(app); await utils.tearDown(app);
} }
}); });
@ -93,7 +96,10 @@ describe("Lens integration tests", () => {
}); });
it("ensures helm repos", async () => { it("ensures helm repos", async () => {
await app.client.waitUntilTextExists("div.repos #message-bitnami", "bitnami"); // wait for the helm-cli to fetch the bitnami repo const { stdout: reposJson } = await promiseExec("helm repo list -o json");
const repos = JSON.parse(reposJson);
await app.client.waitUntilTextExists("div.repos #message-bitnami", repos[0].name); // wait for the helm-cli to fetch the repo(s)
await app.client.click("#HelmRepoSelect"); // click the repo select to activate the drop-down await app.client.click("#HelmRepoSelect"); // click the repo select to activate the drop-down
await app.client.waitUntilTextExists("div.Select__option", ""); // wait for at least one option to appear (any text) await app.client.waitUntilTextExists("div.Select__option", ""); // wait for at least one option to appear (any text)
}); });
@ -105,12 +111,12 @@ describe("Lens integration tests", () => {
}); });
}); });
util.describeIf(ready)("workspaces", () => { utils.describeIf(ready)("workspaces", () => {
beforeAll(appStart, 20000); beforeAll(appStart, 20000);
afterAll(async () => { afterAll(async () => {
if (app && app.isRunning()) { if (app && app.isRunning()) {
return util.tearDown(app); return utils.tearDown(app);
} }
}); });
@ -169,7 +175,7 @@ describe("Lens integration tests", () => {
await app.client.waitUntilTextExists("span.link-text", "Cluster"); await app.client.waitUntilTextExists("span.link-text", "Cluster");
}; };
util.describeIf(ready)("cluster tests", () => { utils.describeIf(ready)("cluster tests", () => {
let clusterAdded = false; let clusterAdded = false;
const addCluster = async () => { const addCluster = async () => {
await clickWhatsNew(app); await clickWhatsNew(app);
@ -184,7 +190,7 @@ describe("Lens integration tests", () => {
afterAll(async () => { afterAll(async () => {
if (app && app.isRunning()) { if (app && app.isRunning()) {
return util.tearDown(app); return utils.tearDown(app);
} }
}); });
@ -207,7 +213,7 @@ describe("Lens integration tests", () => {
afterAll(async () => { afterAll(async () => {
if (app && app.isRunning()) { if (app && app.isRunning()) {
return util.tearDown(app); return utils.tearDown(app);
} }
}); });
@ -489,7 +495,7 @@ describe("Lens integration tests", () => {
afterEach(async () => { afterEach(async () => {
if (app && app.isRunning()) { if (app && app.isRunning()) {
return util.tearDown(app); return utils.tearDown(app);
} }
}); });
@ -523,7 +529,7 @@ describe("Lens integration tests", () => {
afterEach(async () => { afterEach(async () => {
if (app && app.isRunning()) { if (app && app.isRunning()) {
return util.tearDown(app); return utils.tearDown(app);
} }
}); });