Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

src/renderer/components/kube-object-menu/__snapshots__/kube-object-menu.test.tsx.snap

@@ -2,10 +2,6 @@
 
 exports[`kube-object-menu given kube object renders 1`] = `
 <body>
-  <div
-    class="terminal-init"
-    style="position: absolute; top: 0px; left: 0px; height: 0px; visibility: hidden; overflow: hidden;"
-  />
   <div>
     <div>
       <ul
@@ -22,8 +18,8 @@ exports[`kube-object-menu given kube object renders 1`] = `
         >
           <i
             class="Icon material interactive focusable"
-            id="tooltip_target_2"
             tabindex="0"
+            tooltip="Delete"
           >
             <span
               class="icon"
@@ -31,7 +27,6 @@ exports[`kube-object-menu given kube object renders 1`] = `
             >
               delete
             </span>
-            <div />
           </i>
           <span
             class="title"
@@ -46,20 +41,11 @@ exports[`kube-object-menu given kube object renders 1`] = `
     class="Animate opacity-scale Dialog flex center ConfirmDialog modal"
     style="--enter-duration: 100ms; --leave-duration: 100ms;"
   />
-  <div
-    class="Tooltip narrow invisible formatter"
-  >
-    Delete
-  </div>
 </body>
 `;
 
 exports[`kube-object-menu given kube object when removing kube object renders 1`] = `
 <body>
-  <div
-    class="terminal-init"
-    style="position: absolute; top: 0px; left: 0px; height: 0px; visibility: hidden; overflow: hidden;"
-  />
   <div>
     <div>
       <ul
@@ -76,8 +62,8 @@ exports[`kube-object-menu given kube object when removing kube object renders 1`
         >
           <i
             class="Icon material interactive focusable"
-            id="tooltip_target_4"
             tabindex="0"
+            tooltip="Delete"
           >
             <span
               class="icon"
@@ -85,7 +71,6 @@ exports[`kube-object-menu given kube object when removing kube object renders 1`
             >
               delete
             </span>
-            <div />
           </i>
           <span
             class="title"
@@ -153,20 +138,11 @@ exports[`kube-object-menu given kube object when removing kube object renders 1`
       </div>
     </div>
   </div>
-  <div
-    class="Tooltip narrow invisible formatter"
-  >
-    Delete
-  </div>
 </body>
 `;
 
 exports[`kube-object-menu given kube object with namespace when removing kube object, renders confirmation dialog with namespace 1`] = `
 <body>
-  <div
-    class="terminal-init"
-    style="position: absolute; top: 0px; left: 0px; height: 0px; visibility: hidden; overflow: hidden;"
-  />
   <div>
     <div>
       <ul
@@ -183,8 +159,8 @@ exports[`kube-object-menu given kube object with namespace when removing kube ob
         >
           <i
             class="Icon material interactive focusable"
-            id="tooltip_target_12"
             tabindex="0"
+            tooltip="Delete"
           >
             <span
               class="icon"
@@ -192,7 +168,6 @@ exports[`kube-object-menu given kube object with namespace when removing kube ob
             >
               delete
             </span>
-            <div />
           </i>
           <span
             class="title"
@@ -260,20 +235,11 @@ exports[`kube-object-menu given kube object with namespace when removing kube ob
       </div>
     </div>
   </div>
-  <div
-    class="Tooltip narrow invisible formatter"
-  >
-    Delete
-  </div>
 </body>
 `;
 
 exports[`kube-object-menu given kube object without namespace when removing kube object, renders confirmation dialog without namespace 1`] = `
 <body>
-  <div
-    class="terminal-init"
-    style="position: absolute; top: 0px; left: 0px; height: 0px; visibility: hidden; overflow: hidden;"
-  />
   <div>
     <div>
       <ul
@@ -290,8 +256,8 @@ exports[`kube-object-menu given kube object without namespace when removing kube
         >
           <i
             class="Icon material interactive focusable"
-            id="tooltip_target_17"
             tabindex="0"
+            tooltip="Delete"
           >
             <span
               class="icon"
@@ -299,7 +265,6 @@ exports[`kube-object-menu given kube object without namespace when removing kube
             >
               delete
             </span>
-            <div />
           </i>
           <span
             class="title"
@@ -367,20 +332,11 @@ exports[`kube-object-menu given kube object without namespace when removing kube
       </div>
     </div>
   </div>
-  <div
-    class="Tooltip narrow invisible formatter"
-  >
-    Delete
-  </div>
 </body>
 `;
 
 exports[`kube-object-menu given no kube object, renders 1`] = `
 <body>
-  <div
-    class="terminal-init"
-    style="position: absolute; top: 0px; left: 0px; height: 0px; visibility: hidden; overflow: hidden;"
-  />
   <div>
     <ul
       class="Animate opacity Menu MenuActions flex KubeObjectMenu toolbar gaps right bottom"

src/renderer/components/kube-object-menu/kube-object-menu.test.tsx

@@ -42,6 +42,9 @@ import type { ApiManager } from "../../../common/k8s-api/api-manager";
 import apiManagerInjectable from "./dependencies/api-manager.injectable";
 import { KubeObjectMenu } from "./index";
 
+// TODO: Make tooltips free of side effects by making it deterministic
+jest.mock("../tooltip");
+
 describe("kube-object-menu", () => {
   let di: ConfigurableDependencyInjectionContainer;
   let render: DiRender;
@@ -66,8 +69,7 @@ describe("kube-object-menu", () => {
       getStore: api => undefined,
     }) as ApiManager);
 
-    di.override(hideDetailsInjectable, () => () => {
-    });
+    di.override(hideDetailsInjectable, () => () => {});
 
     di.override(editResourceTabInjectable, () => () => ({
       id: "irrelevant",