hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Consolidate discovery of HTML elements in some tests

Browse Source 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-10-17 14:59:34 +03:00
parent beb0103427
commit 4249ae1f7d
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
23 changed files with 349 additions and 181 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/features/preferences/__snapshots__/navigation-to-application-preferences.test.ts.snap
View File

@ -86,13 +86,15 @@ exports[`preferences - navigation to application preferences given in some child
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -150,6 +156,7 @@ exports[`preferences - navigation to application preferences given in some child
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -161,14 +168,15 @@ exports[`preferences - navigation to application preferences given in some child
class="content" class="content"
> >
<section <section
data-preference-page-test="proxy"
id="proxy" id="proxy"
> >
<h2
data-testid="proxy-header"
>
Proxy
</h2>
<section> <section>
<h2
data-testid="proxy-header"
>
Proxy
</h2>
<div <div
class="SubTitle" class="SubTitle"
> >
@ -224,11 +232,7 @@ exports[`preferences - navigation to application preferences given in some child
<small <small
class="hint" class="hint"
> >
This will make Lens to trust ANY certificate authority without any validations. This will make Lens to trust ANY certificate authority without any validations. Needed with some corporate proxies that do certificate re-writing. Does not affect cluster communications!
Needed with some corporate proxies that do certificate re-writing.
Does not affect cluster communications!
</small> </small>
</section> </section>
</section> </section>
@ -419,13 +423,15 @@ exports[`preferences - navigation to application preferences given in some child
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -437,7 +443,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -449,7 +456,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -461,7 +469,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -473,7 +482,8 @@ exports[`preferences - navigation to application preferences given in some child
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -483,6 +493,7 @@ exports[`preferences - navigation to application preferences given in some child
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -494,6 +505,7 @@ exports[`preferences - navigation to application preferences given in some child
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2

52
src/features/preferences/__snapshots__/navigation-to-editor-preferences.test.ts.snap
View File

@ -86,13 +86,15 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -150,6 +156,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -161,6 +168,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -743,13 +751,15 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -761,7 +771,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -773,7 +784,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -785,7 +797,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -797,7 +810,8 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -807,6 +821,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -818,6 +833,7 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
class="content" class="content"
> >
<section <section
data-preference-page-test="editor"
id="editor" id="editor"
> >
<h2 <h2
@ -825,13 +841,13 @@ exports[`preferences - navigation to editor preferences given in preferences, wh
> >
Editor configuration Editor configuration
</h2> </h2>
<div
class="SubTitle"
>
Minimap
</div>
<section> <section>
<div
class="SubTitle"
>
Minimap
</div>
<div <div
class="flex gaps justify-space-between" class="flex gaps justify-space-between"
> >

50
src/features/preferences/__snapshots__/navigation-to-kubernetes-preferences.test.ts.snap
View File

@ -86,13 +86,15 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -150,6 +156,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -161,6 +168,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -743,13 +751,15 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -761,7 +771,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -773,7 +784,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -785,7 +797,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -797,7 +810,8 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -807,6 +821,7 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -818,16 +833,17 @@ exports[`preferences - navigation to kubernetes preferences given in preferences
class="content" class="content"
> >
<section <section
data-preference-page-test="kubernetes"
id="kubernetes" id="kubernetes"
> >
<h2
data-testid="kubernetes-header"
>
Kubernetes
</h2>
<section <section
id="kubectl" id="kubectl"
> >
<h2
data-testid="kubernetes-header"
>
Kubernetes
</h2>
<section> <section>
<div <div
class="SubTitle" class="SubTitle"

56
src/features/preferences/__snapshots__/navigation-to-proxy-preferences.test.ts.snap
View File

@ -86,13 +86,15 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -150,6 +156,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -161,6 +168,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -743,13 +751,15 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -761,7 +771,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -773,7 +784,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -785,7 +797,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -797,7 +810,8 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -807,6 +821,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -818,14 +833,15 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
class="content" class="content"
> >
<section <section
data-preference-page-test="proxy"
id="proxy" id="proxy"
> >
<h2
data-testid="proxy-header"
>
Proxy
</h2>
<section> <section>
<h2
data-testid="proxy-header"
>
Proxy
</h2>
<div <div
class="SubTitle" class="SubTitle"
> >
@ -881,11 +897,7 @@ exports[`preferences - navigation to proxy preferences given in preferences, whe
<small <small
class="hint" class="hint"
> >
This will make Lens to trust ANY certificate authority without any validations. This will make Lens to trust ANY certificate authority without any validations. Needed with some corporate proxies that do certificate re-writing. Does not affect cluster communications!
Needed with some corporate proxies that do certificate re-writing.
Does not affect cluster communications!
</small> </small>
</section> </section>
</section> </section>

106
src/features/preferences/__snapshots__/navigation-to-telemetry-preferences.test.tsx.snap
View File

@ -74,7 +74,7 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
/> />
<div <div
class="SettingLayout showNavigation Preferences" class="SettingLayout showNavigation Preferences"
data-testid="telemetry-preferences-page" data-testid="terminal-preferences-page"
> >
<nav <nav
class="sidebarRegion" class="sidebarRegion"
@ -86,13 +86,15 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -152,7 +158,8 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-telemetry" data-preference-tab-link-test="telemetry"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -162,6 +169,7 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
Telemetry Telemetry
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -173,6 +181,7 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
class="content" class="content"
> >
<section <section
data-preference-page-test="telemetry"
id="telemetry" id="telemetry"
> >
<h2 <h2
@ -180,7 +189,7 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
> >
Telemetry Telemetry
</h2> </h2>
<section <div
class="small" class="small"
data-testid="telemetry-preferences-for-automatic-error-reporting" data-testid="telemetry-preferences-for-automatic-error-reporting"
id="sentry" id="sentry"
@ -213,10 +222,7 @@ exports[`preferences - navigation to telemetry preferences given URL for Sentry
Automatic error reports provide vital information about issues and application crashes. It is highly recommended to keep this feature enabled to ensure fast turnaround for issues you might encounter. Automatic error reports provide vital information about issues and application crashes. It is highly recommended to keep this feature enabled to ensure fast turnaround for issues you might encounter.
</span> </span>
</div> </div>
</section> </div>
<hr
class="small"
/>
</section> </section>
</div> </div>
<div <div
@ -405,13 +411,15 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -423,7 +431,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -435,7 +444,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -447,7 +457,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -459,7 +470,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -469,6 +481,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -480,6 +493,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -1062,13 +1076,15 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -1080,7 +1096,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -1092,7 +1109,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -1104,7 +1122,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -1116,7 +1135,8 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -1126,18 +1146,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
Terminal Terminal
</div> </div>
</div> </div>
<div <hr />
class="Tab flex gaps align-center"
data-testid="tab-link-for-telemetry"
role="tab"
tabindex="0"
>
<div
class="label"
>
Telemetry
</div>
</div>
</div> </div>
</div> </div>
</nav> </nav>
@ -1149,6 +1158,7 @@ exports[`preferences - navigation to telemetry preferences given in preferences,
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -2026,7 +2036,7 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
/> />
<div <div
class="SettingLayout showNavigation Preferences" class="SettingLayout showNavigation Preferences"
data-testid="telemetry-preferences-page" data-testid="terminal-preferences-page"
> >
<nav <nav
class="sidebarRegion" class="sidebarRegion"
@ -2038,13 +2048,15 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -2056,7 +2068,8 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -2068,7 +2081,8 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -2080,7 +2094,8 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -2092,7 +2107,8 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -2102,6 +2118,7 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -2113,6 +2130,7 @@ exports[`preferences - navigation to telemetry preferences given no URL for Sent
class="content" class="content"
> >
<section <section
data-preference-page-test="telemetry"
id="telemetry" id="telemetry"
> >
<h2 <h2

48
src/features/preferences/__snapshots__/navigation-to-terminal-preferences.test.ts.snap
View File

@ -86,13 +86,15 @@ exports[`preferences - navigation to terminal preferences given in preferences,
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -104,7 +106,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -116,7 +119,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -128,7 +132,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -140,7 +145,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -150,6 +156,7 @@ exports[`preferences - navigation to terminal preferences given in preferences,
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -161,6 +168,7 @@ exports[`preferences - navigation to terminal preferences given in preferences,
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2
@ -743,13 +751,15 @@ exports[`preferences - navigation to terminal preferences given in preferences,
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -761,7 +771,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -773,7 +784,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -785,7 +797,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -797,7 +810,8 @@ exports[`preferences - navigation to terminal preferences given in preferences,
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -807,6 +821,7 @@ exports[`preferences - navigation to terminal preferences given in preferences,
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -817,8 +832,13 @@ exports[`preferences - navigation to terminal preferences given in preferences,
<div <div
class="content" class="content"
> >
<section> <section
<h2> data-preference-page-test="terminal"
id="terminal"
>
<h2
data-testid="terminal-header"
>
Terminal Terminal
</h2> </h2>
<section <section

20
src/features/preferences/__snapshots__/navigation-using-application-menu.test.ts.snap
View File

@ -304,13 +304,15 @@ exports[`preferences - navigation using application menu when navigating to pref
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -322,7 +324,8 @@ exports[`preferences - navigation using application menu when navigating to pref
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -334,7 +337,8 @@ exports[`preferences - navigation using application menu when navigating to pref
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -346,7 +350,8 @@ exports[`preferences - navigation using application menu when navigating to pref
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -358,7 +363,8 @@ exports[`preferences - navigation using application menu when navigating to pref
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -368,6 +374,7 @@ exports[`preferences - navigation using application menu when navigating to pref
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -379,6 +386,7 @@ exports[`preferences - navigation using application menu when navigating to pref
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2

20
src/features/preferences/__snapshots__/navigation-using-tray.test.ts.snap
View File

@ -307,13 +307,15 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
class="Tabs flex column" class="Tabs flex column"
> >
<div <div
class="header" class="header flex items-center"
data-testid="general-tab-group"
> >
Preferences Preferences
</div> </div>
<div <div
class="Tab flex gaps align-center active" class="Tab flex gaps align-center active"
data-testid="tab-link-for-application" data-preference-tab-link-test="app"
data-testid="application-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -325,7 +327,8 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-proxy" data-preference-tab-link-test="proxy"
data-testid="proxy-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -337,7 +340,8 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-kubernetes" data-preference-tab-link-test="kubernetes"
data-testid="kubernetes-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -349,7 +353,8 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-editor" data-preference-tab-link-test="editor"
data-testid="editor-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -361,7 +366,8 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
</div> </div>
<div <div
class="Tab flex gaps align-center" class="Tab flex gaps align-center"
data-testid="tab-link-for-terminal" data-preference-tab-link-test="terminal"
data-testid="terminal-preferences-page"
role="tab" role="tab"
tabindex="0" tabindex="0"
> >
@ -371,6 +377,7 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
Terminal Terminal
</div> </div>
</div> </div>
<hr />
</div> </div>
</div> </div>
</nav> </nav>
@ -382,6 +389,7 @@ exports[`show-about-using-tray when navigating using tray renders 1`] = `
class="content" class="content"
> >
<section <section
data-preference-page-test="application"
id="application" id="application"
> >
<h2 <h2

14
src/features/preferences/navigation-to-application-preferences.test.ts
View File

@ -6,6 +6,7 @@ import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import navigateToProxyPreferencesInjectable from "./common/navigate-to-proxy-preferences.injectable"; import navigateToProxyPreferencesInjectable from "./common/navigate-to-proxy-preferences.injectable";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to application preferences", () => { describe("preferences - navigation to application preferences", () => {
let builder: ApplicationBuilder; let builder: ApplicationBuilder;
@ -32,14 +33,17 @@ describe("preferences - navigation to application preferences", () => {
}); });
it("does not show application preferences yet", () => { it("does not show application preferences yet", () => {
const page = rendered.queryByTestId("application-preferences-page"); const page = querySingleElement(
"preference-page",
"application",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
describe("when navigating to application preferences using navigation", () => { describe("when navigating to application preferences using navigation", () => {
beforeEach(() => { beforeEach(() => {
builder.preferences.navigation.click("application"); builder.preferences.navigation.click("app");
}); });
it("renders", () => { it("renders", () => {
@ -47,10 +51,14 @@ describe("preferences - navigation to application preferences", () => {
}); });
it("shows application preferences", () => { it("shows application preferences", () => {
const page = rendered.getByTestId("application-preferences-page"); const page = getSingleElement(
"preference-page",
"application",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });
}); });
}); });
}); });

12
src/features/preferences/navigation-to-editor-preferences.test.ts
View File

@ -5,6 +5,7 @@
import type { RenderResult } from "@testing-library/react"; import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to editor preferences", () => { describe("preferences - navigation to editor preferences", () => {
let applicationBuilder: ApplicationBuilder; let applicationBuilder: ApplicationBuilder;
@ -27,9 +28,11 @@ describe("preferences - navigation to editor preferences", () => {
it("renders", () => { it("renders", () => {
expect(rendered.container).toMatchSnapshot(); expect(rendered.container).toMatchSnapshot();
}); });
it("does not show editor preferences yet", () => { it("does not show editor preferences yet", () => {
const page = rendered.queryByTestId("editor-preferences-page"); const page = querySingleElement(
"preference-page",
"editor",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
@ -44,7 +47,10 @@ describe("preferences - navigation to editor preferences", () => {
}); });
it("shows editor preferences", () => { it("shows editor preferences", () => {
const page = rendered.getByTestId("editor-preferences-page"); const page = getSingleElement(
"preference-page",
"editor",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });

11
src/features/preferences/navigation-to-kubernetes-preferences.test.ts
View File

@ -7,6 +7,7 @@ import type { ApplicationBuilder } from "../../renderer/components/test-utils/ge
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import callForPublicHelmRepositoriesInjectable from "../helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable"; import callForPublicHelmRepositoriesInjectable from "../helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/public-helm-repositories/call-for-public-helm-repositories.injectable";
import getActiveHelmRepositoriesInjectable from "../../main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable"; import getActiveHelmRepositoriesInjectable from "../../main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to kubernetes preferences", () => { describe("preferences - navigation to kubernetes preferences", () => {
let builder: ApplicationBuilder; let builder: ApplicationBuilder;
@ -42,7 +43,10 @@ describe("preferences - navigation to kubernetes preferences", () => {
}); });
it("does not show kubernetes preferences yet", () => { it("does not show kubernetes preferences yet", () => {
const page = rendered.queryByTestId("kubernetes-preferences-page"); const page = querySingleElement(
"preference-page",
"kubernetes",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
@ -57,7 +61,10 @@ describe("preferences - navigation to kubernetes preferences", () => {
}); });
it("shows kubernetes preferences", () => { it("shows kubernetes preferences", () => {
const page = rendered.getByTestId("kubernetes-preferences-page"); const page = getSingleElement(
"preference-page",
"kubernetes",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });

11
src/features/preferences/navigation-to-proxy-preferences.test.ts
View File

@ -5,6 +5,7 @@
import type { RenderResult } from "@testing-library/react"; import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to proxy preferences", () => { describe("preferences - navigation to proxy preferences", () => {
let applicationBuilder: ApplicationBuilder; let applicationBuilder: ApplicationBuilder;
@ -29,7 +30,10 @@ describe("preferences - navigation to proxy preferences", () => {
}); });
it("does not show proxy preferences yet", () => { it("does not show proxy preferences yet", () => {
const page = rendered.queryByTestId("proxy-preferences-page"); const page = querySingleElement(
"preference-page",
"proxy",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
@ -44,7 +48,10 @@ describe("preferences - navigation to proxy preferences", () => {
}); });
it("shows proxy preferences", () => { it("shows proxy preferences", () => {
const page = rendered.getByTestId("proxy-preferences-page"); const page = getSingleElement(
"preference-page",
"proxy",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });

11
src/features/preferences/navigation-to-telemetry-preferences.test.tsx
View File

@ -9,6 +9,7 @@ import { getApplicationBuilder } from "../../renderer/components/test-utils/get-
import navigateToTelemetryPreferencesInjectable from "./common/navigate-to-telemetry-preferences.injectable"; import navigateToTelemetryPreferencesInjectable from "./common/navigate-to-telemetry-preferences.injectable";
import sentryDataSourceNameInjectable from "../../common/vars/sentry-dsn-url.injectable"; import sentryDataSourceNameInjectable from "../../common/vars/sentry-dsn-url.injectable";
import type { FakeExtensionOptions } from "../../renderer/components/test-utils/get-extension-fake"; import type { FakeExtensionOptions } from "../../renderer/components/test-utils/get-extension-fake";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to telemetry preferences", () => { describe("preferences - navigation to telemetry preferences", () => {
let builder: ApplicationBuilder; let builder: ApplicationBuilder;
@ -33,7 +34,10 @@ describe("preferences - navigation to telemetry preferences", () => {
}); });
it("does not show telemetry preferences yet", () => { it("does not show telemetry preferences yet", () => {
const page = rendered.queryByTestId("telemetry-preferences-page"); const page = querySingleElement(
"preference-page",
"telemetry",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
@ -71,7 +75,10 @@ describe("preferences - navigation to telemetry preferences", () => {
}); });
it("shows telemetry preferences", () => { it("shows telemetry preferences", () => {
const page = rendered.getByTestId("telemetry-preferences-page"); const page = getSingleElement(
"preference-page",
"telemetry",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });

12
src/features/preferences/navigation-to-terminal-preferences.test.ts
View File

@ -5,6 +5,7 @@
import type { RenderResult } from "@testing-library/react"; import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation to terminal preferences", () => { describe("preferences - navigation to terminal preferences", () => {
let applicationBuilder: ApplicationBuilder; let applicationBuilder: ApplicationBuilder;
@ -29,7 +30,10 @@ describe("preferences - navigation to terminal preferences", () => {
}); });
it("does not show terminal preferences yet", () => { it("does not show terminal preferences yet", () => {
const page = rendered.queryByTestId("terminal-preferences-page"); const page = querySingleElement(
"preference-page",
"terminal",
)(rendered);
expect(page).toBeNull(); expect(page).toBeNull();
}); });
@ -43,8 +47,12 @@ describe("preferences - navigation to terminal preferences", () => {
expect(rendered.container).toMatchSnapshot(); expect(rendered.container).toMatchSnapshot();
}); });
it("shows terminal preferences", () => { it("shows terminal preferences", () => {
const page = rendered.getByTestId("terminal-preferences-page"); const page = getSingleElement(
"preference-page",
"terminal",
)(rendered);
expect(page).not.toBeNull(); expect(page).not.toBeNull();
}); });

19
src/features/preferences/navigation-using-application-menu.test.ts
View File

@ -6,6 +6,7 @@
import type { RenderResult } from "@testing-library/react"; import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("preferences - navigation using application menu", () => { describe("preferences - navigation using application menu", () => {
let applicationBuilder: ApplicationBuilder; let applicationBuilder: ApplicationBuilder;
@ -21,10 +22,13 @@ describe("preferences - navigation using application menu", () => {
expect(rendered.container).toMatchSnapshot(); expect(rendered.container).toMatchSnapshot();
}); });
it("does not show application preferences page yet", () => { it("does not show application preferences yet", () => {
const actual = rendered.queryByTestId("application-preferences-page"); const page = querySingleElement(
"preference-page",
"application",
)(rendered);
expect(actual).toBeNull(); expect(page).toBeNull();
}); });
describe("when navigating to preferences using application menu", () => { describe("when navigating to preferences using application menu", () => {
@ -36,10 +40,13 @@ describe("preferences - navigation using application menu", () => {
expect(rendered.container).toMatchSnapshot(); expect(rendered.container).toMatchSnapshot();
}); });
it("shows application preferences page", () => { it("shows application preferences", () => {
const actual = rendered.getByTestId("application-preferences-page"); const page = getSingleElement(
"preference-page",
"application",
)(rendered);
expect(actual).not.toBeNull(); expect(page).not.toBeNull();
}); });
}); });
}); });

19
src/features/preferences/navigation-using-tray.test.ts
View File

@ -5,6 +5,7 @@
import type { RenderResult } from "@testing-library/react"; import type { RenderResult } from "@testing-library/react";
import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import type { ApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder"; import { getApplicationBuilder } from "../../renderer/components/test-utils/get-application-builder";
import { getSingleElement, querySingleElement } from "../../renderer/components/test-utils/discovery-of-html-elements";
describe("show-about-using-tray", () => { describe("show-about-using-tray", () => {
let applicationBuilder: ApplicationBuilder; let applicationBuilder: ApplicationBuilder;
@ -20,10 +21,13 @@ describe("show-about-using-tray", () => {
expect(rendered.baseElement).toMatchSnapshot(); expect(rendered.baseElement).toMatchSnapshot();
}); });
it("does not show application preferences page yet", () => { it("does not show application preferences yet", () => {
const actual = rendered.queryByTestId("application-preferences-page"); const page = querySingleElement(
"preference-page",
"application",
)(rendered);
expect(actual).toBeNull(); expect(page).toBeNull();
}); });
describe("when navigating using tray", () => { describe("when navigating using tray", () => {
@ -35,10 +39,13 @@ describe("show-about-using-tray", () => {
expect(rendered.baseElement).toMatchSnapshot(); expect(rendered.baseElement).toMatchSnapshot();
}); });
it("shows application preferences page", () => { it("shows application preferences", () => {
const actual = rendered.getByTestId("application-preferences-page"); const page = getSingleElement(
"preference-page",
"application",
)(rendered);
expect(actual).not.toBeNull(); expect(page).not.toBeNull();
}); });
}); });
}); });

2
src/features/preferences/renderer/preference-items/application/application-preference-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const ApplicationPreferencePage: PreferenceItemComponent = ({ children }) => ( export const ApplicationPreferencePage: PreferenceItemComponent = ({ children }) => (
<section id="application"> <section id="application" data-preference-page-test="application">
<h2 data-testid="application-header">Application</h2> <h2 data-testid="application-header">Application</h2>
{children} {children}

2
src/features/preferences/renderer/preference-items/editor/editor-preference-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const EditorPreferencePage: PreferenceItemComponent = ({ children }) => ( export const EditorPreferencePage: PreferenceItemComponent = ({ children }) => (
<section id="editor"> <section id="editor" data-preference-page-test="editor">
<h2 data-testid="editor-configuration-header">Editor configuration</h2> <h2 data-testid="editor-configuration-header">Editor configuration</h2>
{children} {children}

2
src/features/preferences/renderer/preference-items/kubernetes/kubernetes-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const KubernetesPage: PreferenceItemComponent = ({ children }) => ( export const KubernetesPage: PreferenceItemComponent = ({ children }) => (
<section id="kubernetes"> <section id="kubernetes" data-preference-page-test="kubernetes">
<h2 data-testid="kubernetes-header">Kubernetes</h2> <h2 data-testid="kubernetes-header">Kubernetes</h2>
{children} {children}

2
src/features/preferences/renderer/preference-items/proxy/proxy-preference-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const ProxyPreferencePage: PreferenceItemComponent = ({ children }) => ( export const ProxyPreferencePage: PreferenceItemComponent = ({ children }) => (
<section id="proxy"> <section id="proxy" data-preference-page-test="proxy">
<h2 data-testid="proxy-header">Proxy</h2> <h2 data-testid="proxy-header">Proxy</h2>
{children} {children}

2
src/features/preferences/renderer/preference-items/telemetry/telemetry-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const TelemetryPage: PreferenceItemComponent = ({ children }) => ( export const TelemetryPage: PreferenceItemComponent = ({ children }) => (
<section id="telemetry"> <section id="telemetry" data-preference-page-test="telemetry">
<h2 data-testid="telemetry-header">Telemetry</h2> <h2 data-testid="telemetry-header">Telemetry</h2>
{children} {children}

2
src/features/preferences/renderer/preference-items/terminal/terminal-page.tsx
View File

@ -6,7 +6,7 @@ import React from "react";
import type { PreferenceItemComponent } from "../preference-item-injection-token"; import type { PreferenceItemComponent } from "../preference-item-injection-token";
export const TerminalPage: PreferenceItemComponent = ({ children }) => ( export const TerminalPage: PreferenceItemComponent = ({ children }) => (
<section id="terminal"> <section id="terminal" data-preference-page-test="terminal">
<h2 data-testid="terminal-header">Terminal</h2> <h2 data-testid="terminal-header">Terminal</h2>
{children} {children}

1
src/features/preferences/renderer/preference-navigation/preferences-navigation-tab.tsx
View File

@ -26,6 +26,7 @@ const NonInjectedPreferencesNavigationTab = observer(({ navigateToTab, tabIsActi
data-testid={tab.testId} data-testid={tab.testId}
active={tabIsActive.get()} active={tabIsActive.get()}
label={tab.label} label={tab.label}
data-preference-tab-link-test={tab.pathId}
/> />
)); ));