Turn on several TSC options

- noUnusedLocals
- noImplicitReturns
- importsNotUsedAsValues: error

Signed-off-by: Sebastian Malton <sebastian@malton.name>

integration/__tests__/app.tests.ts

@@ -8,7 +8,7 @@
   TEST_NAMESPACE namespace. This is done to minimize destructive impact of the cluster tests on an existing minikube
   cluster and vice versa.
 */
-import { Application } from "spectron";
+import type { Application } from "spectron";
 import * as utils from "../helpers/utils";
 import { listHelmRepositories } from "../helpers/utils";
 import { fail } from "assert";

integration/__tests__/cluster-pages.tests.ts

@@ -4,7 +4,7 @@
   TEST_NAMESPACE namespace. This is done to minimize destructive impact of the cluster tests on an existing minikube
   cluster and vice versa.
 */
-import { Application } from "spectron";
+import type { Application } from "spectron";
 import * as utils from "../helpers/utils";
 import { minikubeReady, waitForMinikubeDashboard } from "../helpers/minikube";
 import { exec } from "child_process";

integration/__tests__/command-palette.tests.ts

@@ -1,4 +1,4 @@
-import { Application } from "spectron";
+import type { Application } from "spectron";
 import * as utils from "../helpers/utils";
 
 jest.setTimeout(60000);

integration/helpers/minikube.ts

@@ -1,5 +1,5 @@
 import { spawnSync } from "child_process";
-import { Application } from "spectron";
+import type { Application } from "spectron";
 
 export function minikubeReady(testNamespace: string): boolean {
   // determine if minikube is running

src/common/base-store.ts

@@ -21,7 +21,7 @@
 
 import path from "path";
 import Config from "conf";
-import { Options as ConfOptions } from "conf/dist/source/types";
+import type { Options as ConfOptions } from "conf/dist/source/types";
 import { app, ipcMain, IpcMainEvent, ipcRenderer, IpcRendererEvent, remote } from "electron";
 import { IReactionOptions, observable, reaction, runInAction, when } from "mobx";
 import Singleton from "./utils/singleton";

src/common/catalog/catalog-entity-registry.ts

@@ -20,7 +20,7 @@
  */
 
 import { action, computed, observable, IComputedValue, IObservableArray } from "mobx";
-import { CatalogEntity } from "./catalog-entity";
+import type { CatalogEntity } from "./catalog-entity";
 import { iter } from "../utils";
 
 export class CatalogEntityRegistry {

src/common/cluster-ipc.ts

@@ -34,11 +34,9 @@ export const clusterKubectlApplyAllHandler = "cluster:kubectl-apply-all";
 
 if (ipcMain) {
   handleRequest(clusterActivateHandler, (event, clusterId: ClusterId, force = false) => {
-    const cluster = ClusterStore.getInstance().getById(clusterId);
+    return ClusterStore.getInstance()
-
+      .getById(clusterId)
-    if (cluster) {
+      ?.activate(force);
-      return cluster.activate(force);
-    }
   });
 
   handleRequest(clusterSetFrameIdHandler, (event: IpcMainInvokeEvent, clusterId: ClusterId) => {
@@ -46,15 +44,14 @@ if (ipcMain) {
 
     if (cluster) {
       clusterFrameMap.set(cluster.id, { frameId: event.frameId, processId: event.processId });
-
+      cluster.pushState();
-      return cluster.pushState();
     }
   });
 
   handleRequest(clusterRefreshHandler, (event, clusterId: ClusterId) => {
-    const cluster = ClusterStore.getInstance().getById(clusterId);
+    return ClusterStore.getInstance()
-
+      .getById(clusterId)
-    if (cluster) return cluster.refresh({ refreshMetadata: true });
+      ?.refresh({ refreshMetadata: true });
   });
 
   handleRequest(clusterDisconnectHandler, (event, clusterId: ClusterId) => {

src/common/cluster-store.ts

@@ -30,9 +30,9 @@ import logger from "../main/logger";
 import { appEventBus } from "./event-bus";
 import { dumpConfigYaml } from "./kube-helpers";
 import { saveToAppFiles } from "./utils/saveToAppFiles";
-import { KubeConfig } from "@kubernetes/client-node";
+import type { KubeConfig } from "@kubernetes/client-node";
 import { handleRequest, requestMain, subscribeToBroadcast, unsubscribeAllFromBroadcast } from "./ipc";
-import { ResourceType } from "../renderer/components/cluster-settings/components/cluster-metrics-setting";
+import type { ResourceType } from "../renderer/components/cluster-settings/components/cluster-metrics-setting";
 import { disposer, noop } from "./utils";
 
 export interface ClusterIconUpload {

src/common/event-emitter.ts

@@ -53,12 +53,11 @@ export class EventEmitter<D extends [...any[]]> {
 
   emit(...data: D) {
     [...this.listeners].every(([callback, options]) => {
-      if (options.once) this.removeListener(callback);
+      if (options.once) {
-      const result = callback(...data);
+        this.removeListener(callback);
+      }
 
-      if (result === false) return; // break cycle
+      return callback(...data) !== false;
-
-      return true;
     });
   }
 }

src/common/ipc/type-enforced-ipc.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { EventEmitter } from "events";
+import type { EventEmitter } from "events";
 import logger from "../../main/logger";
 
 export type HandlerEvent<EM extends EventEmitter> = Parameters<Parameters<EM["on"]>[1]>[0];

src/common/ipc/update-available.ipc.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { UpdateInfo } from "electron-updater";
+import type { UpdateInfo } from "electron-updater";
 
 export const UpdateAvailableChannel = "update-available";
 export const AutoUpdateLogPrefix = "[UPDATE-CHECKER]";

src/common/kube-helpers.ts

@@ -230,7 +230,7 @@ export function getNodeWarningConditions(node: V1Node) {
  *
  * Note: This function returns an error instead of throwing it, returning `undefined` if the validation passes
  */
-export function validateKubeConfig(config: KubeConfig, contextName: string, validationOpts: KubeConfigValidationOpts = {}): Error | undefined {
+export function validateKubeConfig(config: KubeConfig, contextName: string, validationOpts: KubeConfigValidationOpts = {}): Error | void {
   try {
     // we only receive a single context, cluster & user object here so lets validate them as this
     // will be called when we add a new cluster to Lens

src/common/protocol-handler/error.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import Url from "url-parse";
+import type Url from "url-parse";
 
 export enum RoutingErrorType {
   INVALID_PROTOCOL = "invalid-protocol",
@@ -52,6 +52,8 @@ export class RoutingError extends Error {
         return "no extension ID";
       case RoutingErrorType.MISSING_EXTENSION:
         return "extension not found";
+      default:
+        return `unknown error: ${this.type}`;
     }
   }
 }

src/common/protocol-handler/router.ts

@@ -24,12 +24,12 @@ import { countBy } from "lodash";
 import { Singleton } from "../utils";
 import { pathToRegexp } from "path-to-regexp";
 import logger from "../../main/logger";
-import Url from "url-parse";
+import type Url from "url-parse";
 import { RoutingError, RoutingErrorType } from "./error";
 import { ExtensionsStore } from "../../extensions/extensions-store";
 import { ExtensionLoader } from "../../extensions/extension-loader";
-import { LensExtension } from "../../extensions/lens-extension";
+import type { LensExtension } from "../../extensions/lens-extension";
-import { RouteHandler, RouteParams } from "../../extensions/registries/protocol-handler-registry";
+import type { RouteHandler, RouteParams } from "../../extensions/registries/protocol-handler-registry";
 
 // IPC channel for protocol actions. Main broadcasts the open-url events to this channel.
 export const ProtocolHandlerIpcPrefix = "protocol-handler";

src/common/utils/delay.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { AbortController } from "abort-controller";
+import type { AbortController } from "abort-controller";
 
 /**
  * Return a promise that will be resolved after at least `timeout` ms have

src/common/utils/iter.ts

@@ -19,6 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
+export type Falsey = false | 0 | "" | null | undefined;
+
 /**
  * Create a new type safe empty Iterable
  * @returns An `Iterable` that yields 0 items
@@ -57,6 +59,36 @@ export function* map<T, U>(src: Iterable<T>, fn: (from: T) => U): Iterable<U> {
   }
 }
 
+/**
+ * The single layer flattening of an iterator, discarding `Falsey` values.
+ * @param src A type that can be iterated over
+ * @param fn The function that returns either an iterable over items that should be filtered out or a `Falsey` value indicating that it should be ignored
+ */
+export function* filterFlatMap<T, U>(src: Iterable<T>, fn: (from: T) => Iterable<U | Falsey> | Falsey): Iterable<U> {
+  for (const from of src) {
+    if (!from) {
+      continue;
+    }
+
+    const mapping = fn(from);
+
+    if (!mapping) {
+      continue;
+    }
+
+    for (const mapped of mapping) {
+      if (mapped) {
+        yield mapped;
+      }
+    }
+  }
+}
+
+/**
+ * Returns a new iterator that yields the items that each call to `fn` would produce
+ * @param src A type that can be iterated over
+ * @param fn A function that returns an iterator
+ */
 export function* flatMap<T, U>(src: Iterable<T>, fn: (from: T) => Iterable<U>): Iterable<U> {
   for (const from of src) {
     yield* fn(from);
@@ -83,7 +115,7 @@ export function* filter<T>(src: Iterable<T>, fn: (from: T) => any): Iterable<T>
  * @param src A type that can be iterated over
  * @param fn The function that is called for each value
  */
-export function* filterMap<T, U>(src: Iterable<T>, fn: (from: T) => U): Iterable<U> {
+export function* filterMap<T, U>(src: Iterable<T>, fn: (from: T) => U | Falsey): Iterable<U> {
   for (const from of src) {
     const res = fn(from);
 
@@ -99,7 +131,7 @@ export function* filterMap<T, U>(src: Iterable<T>, fn: (from: T) => U): Iterable
  * @param src A type that can be iterated over
  * @param fn The function that is called for each value
  */
-export function* filterMapStrict<T, U>(src: Iterable<T>, fn: (from: T) => U): Iterable<U> {
+export function* filterMapStrict<T, U>(src: Iterable<T>, fn: (from: T) => U | null | undefined): Iterable<U> {
   for (const from of src) {
     const res = fn(from);
 

src/common/utils/saveToAppFiles.ts

@@ -23,7 +23,7 @@
 import path from "path";
 import { app, remote } from "electron";
 import { ensureDirSync, writeFileSync } from "fs-extra";
-import { WriteFileOptions } from "fs";
+import type { WriteFileOptions } from "fs";
 
 export function saveToAppFiles(filePath: string, contents: any, options?: WriteFileOptions): string {
   const absPath = path.resolve((app || remote.app).getPath("userData"), filePath);

src/extensions/__tests__/extension-loader.test.ts

@@ -77,6 +77,8 @@ jest.mock(
             ],
           ];
         }
+
+        return [];
       }),
       on: jest.fn(
         (channel: string, listener: (event: any, ...args: any[]) => void) => {

src/extensions/cluster-feature.ts

@@ -24,7 +24,7 @@ import path from "path";
 import hb from "handlebars";
 import { observable } from "mobx";
 import { ResourceApplier } from "../main/resource-applier";
-import { KubernetesCluster } from "./core-api/catalog";
+import type { KubernetesCluster } from "./core-api/catalog";
 import logger from "../main/logger";
 import { app } from "electron";
 import { requestMain } from "../common/ipc";

src/extensions/extension-loader.ts

@@ -325,6 +325,8 @@ export class ExtensionLoader extends Singleton {
     } catch (error) {
       logger.error(`${logModule}: can't load extension main at ${extAbsolutePath}: ${error}`, { extension, error });
     }
+
+    return null;
   }
 
   getExtension(extId: LensExtensionId): InstalledExtension {

src/extensions/extension-store.ts

@@ -21,7 +21,7 @@
 
 import { BaseStore } from "../common/base-store";
 import * as path from "path";
-import { LensExtension } from "./lens-extension";
+import type { LensExtension } from "./lens-extension";
 
 export abstract class ExtensionStore<T> extends BaseStore<T> {
   protected extension: LensExtension;

src/extensions/lens-extension.ts

@@ -23,7 +23,7 @@ import type { InstalledExtension } from "./extension-discovery";
 import { action, observable, reaction } from "mobx";
 import { FilesystemProvisionerStore } from "../main/extension-filesystem";
 import logger from "../main/logger";
-import { ProtocolHandlerRegistration } from "./registries/protocol-handler-registry";
+import type { ProtocolHandlerRegistration } from "./registries/protocol-handler-registry";
 
 export type LensExtensionId = string; // path to manifest (package.json)
 export type LensExtensionConstructor = new (...args: ConstructorParameters<typeof LensExtension>) => LensExtension;

src/extensions/lens-main-extension.ts

@@ -24,7 +24,7 @@ import { LensExtension } from "./lens-extension";
 import { WindowManager } from "../main/window-manager";
 import { getExtensionPageUrl } from "./registries/page-registry";
 import { CatalogEntity, catalogEntityRegistry } from "../common/catalog";
-import { IObservableArray } from "mobx";
+import type { IObservableArray } from "mobx";
 
 export class LensMainExtension extends LensExtension {
   appMenus: MenuRegistration[] = [];

src/extensions/lens-renderer-extension.ts

@@ -26,8 +26,8 @@ import type {
 import type { Cluster } from "../main/cluster";
 import { LensExtension } from "./lens-extension";
 import { getExtensionPageUrl } from "./registries/page-registry";
-import { CommandRegistration } from "./registries/command-registry";
+import type { CommandRegistration } from "./registries/command-registry";
-import { EntitySettingRegistration } from "./registries/entity-setting-registry";
+import type { EntitySettingRegistration } from "./registries/entity-setting-registry";
 
 export class LensRendererExtension extends LensExtension {
   globalPages: PageRegistration[] = [];

src/extensions/registries/entity-setting-registry.ts

@@ -20,7 +20,7 @@
  */
 
 import type React from "react";
-import { CatalogEntity } from "../../common/catalog";
+import type { CatalogEntity } from "../../common/catalog";
 import { BaseRegistry } from "./base-registry";
 
 export interface EntitySettingViewProps {

src/extensions/registries/kube-object-detail-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectDetailComponents {

src/extensions/registries/kube-object-menu-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectMenuComponents {

src/extensions/registries/kube-object-status-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { KubeObject, KubeObjectStatus } from "../renderer-api/k8s-api";
+import type { KubeObject, KubeObjectStatus } from "../renderer-api/k8s-api";
 import { BaseRegistry } from "./base-registry";
 
 export interface KubeObjectStatusRegistration {

src/extensions/registries/page-registry.ts

@@ -25,7 +25,7 @@ import React from "react";
 import { observer } from "mobx-react";
 import { BaseRegistry } from "./base-registry";
 import { LensExtension, sanitizeExtensionName } from "../lens-extension";
-import { PageParam, PageParamInit } from "../../renderer/navigation/page-param";
+import type { PageParam, PageParamInit } from "../../renderer/navigation/page-param";
 import { createPageParam } from "../../renderer/navigation/helpers";
 
 export interface PageRegistration {
@@ -119,9 +119,9 @@ export class PageRegistry extends BaseRegistry<PageRegistration, RegisteredPage>
     return components;
   }
 
-  protected normalizeParams(params?: PageParams<string | ExtensionPageParamInit>): PageParams<PageParam> {
+  protected normalizeParams(params?: PageParams<string | ExtensionPageParamInit>): PageParams<PageParam> | undefined {
     if (!params) {
-      return;
+      return undefined;
     }
     Object.entries(params).forEach(([name, value]) => {
       const paramInit: PageParamInit = typeof value === "object"

src/extensions/registries/status-bar-registry.ts

@@ -21,7 +21,7 @@
 
 // Extensions API -> Status bar customizations
 
-import React from "react";
+import type React from "react";
 import { BaseRegistry } from "./base-registry";
 
 interface StatusBarComponents {

src/main/__test__/kube-auth-proxy.test.ts

@@ -56,7 +56,7 @@ import { ChildProcess, spawn } from "child_process";
 import { bundledKubectlPath, Kubectl } from "../kubectl";
 import { mock, MockProxy } from "jest-mock-extended";
 import { waitUntilUsed } from "tcp-port-used";
-import { Readable } from "stream";
+import type { Readable } from "stream";
 import { UserStore } from "../../common/user-store";
 import { Console } from "console";
 import { stdout, stderr } from "process";

src/main/__test__/kubeconfig-manager.test.ts

@@ -47,7 +47,7 @@ jest.mock("winston", () => ({
 import { KubeconfigManager } from "../kubeconfig-manager";
 import mockFs from "mock-fs";
 import { Cluster } from "../cluster";
-import { ContextHandler } from "../context-handler";
+import type { ContextHandler } from "../context-handler";
 import fse from "fs-extra";
 import { loadYaml } from "@kubernetes/client-node";
 import { Console } from "console";

src/main/catalog-pusher.ts

@@ -21,9 +21,9 @@
 
 import { reaction, toJS } from "mobx";
 import { broadcastMessage, subscribeToBroadcast, unsubscribeFromBroadcast } from "../common/ipc";
-import { CatalogEntityRegistry} from "../common/catalog";
+import type { CatalogEntityRegistry} from "../common/catalog";
 import "../common/catalog-entities/kubernetes-cluster";
-import { Disposer } from "../common/utils";
+import type { Disposer } from "../common/utils";
 
 export class CatalogPusher {
   static init(catalog: CatalogEntityRegistry) {

src/main/catalog-sources/__test__/kubeconfig-sync.test.ts

@@ -20,9 +20,9 @@
  */
 
 import { ObservableMap } from "mobx";
-import { CatalogEntity } from "../../../common/catalog";
+import type { CatalogEntity } from "../../../common/catalog";
 import { loadFromOptions } from "../../../common/kube-helpers";
-import { Cluster } from "../../cluster";
+import type { Cluster } from "../../cluster";
 import { computeDiff, configToModels } from "../kubeconfig-sync";
 import mockFs from "mock-fs";
 import fs from "fs";

src/main/catalog-sources/kubeconfig-sync.ts

@@ -24,10 +24,10 @@ import { CatalogEntity, catalogEntityRegistry } from "../../common/catalog";
 import { watch } from "chokidar";
 import fs from "fs";
 import fse from "fs-extra";
-import stream from "stream";
+import type stream from "stream";
 import { Disposer, ExtendedObservableMap, iter, Singleton } from "../../common/utils";
 import logger from "../logger";
-import { KubeConfig } from "@kubernetes/client-node";
+import type { KubeConfig } from "@kubernetes/client-node";
 import { loadConfigFromString, splitConfig, validateKubeConfig } from "../../common/kube-helpers";
 import { Cluster } from "../cluster";
 import { catalogEntityFromCluster } from "../cluster-manager";

src/main/cluster-detectors/base-cluster-detector.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { RequestPromiseOptions } from "request-promise-native";
+import type { RequestPromiseOptions } from "request-promise-native";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { k8sRequest } from "../k8s-request";
 
 export type ClusterDetectionResult = {

src/main/cluster-detectors/detector-registry.ts

@@ -20,9 +20,9 @@
  */
 
 import { observable } from "mobx";
-import { ClusterMetadata } from "../../common/cluster-store";
+import type { ClusterMetadata } from "../../common/cluster-store";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
-import { BaseClusterDetector, ClusterDetectionResult } from "./base-cluster-detector";
+import type { BaseClusterDetector, ClusterDetectionResult } from "./base-cluster-detector";
 import { ClusterIdDetector } from "./cluster-id-detector";
 import { DistributionDetector } from "./distribution-detector";
 import { LastSeenDetector } from "./last-seen-detector";

src/main/cluster-manager.ts

@@ -24,7 +24,7 @@ import type http from "http";
 import { ipcMain } from "electron";
 import { action, autorun, reaction, toJS } from "mobx";
 import { ClusterStore, getClusterIdFromHost } from "../common/cluster-store";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 import logger from "./logger";
 import { apiKubePrefix } from "../common/vars";
 import { Singleton } from "../common/utils";

src/main/context-handler.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import type { PrometheusProvider, PrometheusService } from "./prometheus/provider-registry";
+import type { PrometheusService } from "./prometheus/provider-registry";
 import type { ClusterPrometheusPreferences } from "../common/cluster-store";
 import type { Cluster } from "./cluster";
 import type httpProxy from "http-proxy";
@@ -75,16 +75,15 @@ export class ContextHandler {
     return prometheusProviders.find(p => p.id === this.prometheusProvider);
   }
 
-  async getPrometheusService(): Promise<PrometheusService> {
+  async getPrometheusService(): Promise<PrometheusService | void> {
     const providers = this.prometheusProvider ? prometheusProviders.filter(provider => provider.id == this.prometheusProvider) : prometheusProviders;
-    const prometheusPromises: Promise<PrometheusService>[] = providers.map(async (provider: PrometheusProvider): Promise<PrometheusService> => {
+    const prometheusPromises: Promise<PrometheusService | void>[] = providers.map(async provider => {
       const apiClient = (await this.cluster.getProxyKubeconfig()).makeApiClient(CoreV1Api);
 
-      return await provider.getPrometheusService(apiClient);
+      return provider.getPrometheusService(apiClient);
     });
-    const resolvedPrometheusServices = await Promise.all(prometheusPromises);
 
-    return resolvedPrometheusServices.filter(n => n)[0];
+    return (await Promise.all(prometheusPromises)).find(Boolean);
   }
 
   async getPrometheusPath(): Promise<string> {

src/main/extension-filesystem.ts

@@ -26,7 +26,7 @@ import fse from "fs-extra";
 import { action, observable, toJS } from "mobx";
 import path from "path";
 import { BaseStore } from "../common/base-store";
-import { LensExtensionId } from "../extensions/lens-extension";
+import type { LensExtensionId } from "../extensions/lens-extension";
 
 interface FSProvisionModel {
   extensions: Record<string, string>; // extension names to paths

src/main/helm/__mocks__/helm-chart-manager.ts

@@ -22,7 +22,7 @@
 import { HelmRepo, HelmRepoManager } from "../helm-repo-manager";
 
 export class HelmChartManager {
-  private cache: any = {};
+  cache: any = {};
   private repo: HelmRepo;
 
   constructor(repo: HelmRepo){

src/main/helm/helm-release-manager.ts

@@ -24,7 +24,7 @@ import fse from "fs-extra";
 import * as yaml from "js-yaml";
 import { promiseExec} from "../promise-exec";
 import { helmCli } from "./helm-cli";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { toCamelCase } from "../../common/utils/camelCase";
 
 export async function listReleases(pathToKubeconfig: string, namespace?: string) {

src/main/helm/helm-service.ts

@@ -20,11 +20,11 @@
  */
 
 import semver from "semver";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import logger from "../logger";
 import { HelmRepoManager } from "./helm-repo-manager";
 import { HelmChartManager } from "./helm-chart-manager";
-import { HelmChartList, RepoHelmChartList } from "../../renderer/api/endpoints/helm-charts.api";
+import type { HelmChartList, RepoHelmChartList } from "../../renderer/api/endpoints/helm-charts.api";
 import { deleteRelease, getHistory, getRelease, getValues, installChart, listReleases, rollback, upgradeRelease } from "./helm-release-manager";
 
 class HelmService {

src/main/k8s-request.ts

@@ -21,9 +21,9 @@
 
 import request, { RequestPromiseOptions } from "request-promise-native";
 import { apiKubePrefix } from "../common/vars";
-import { IMetricsReqParams } from "../renderer/api/endpoints/metrics.api";
+import type { IMetricsReqParams } from "../renderer/api/endpoints/metrics.api";
 import { LensProxy } from "./proxy/lens-proxy";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 
 export async function k8sRequest<T = any>(cluster: Cluster, path: string, options: RequestPromiseOptions = {}): Promise<T> {
   const kubeProxyUrl = `http://localhost:${LensProxy.getInstance().port}${apiKubePrefix}`;

src/main/lens-binary.ts

@@ -25,7 +25,7 @@ import request from "request";
 import { ensureDir, pathExists } from "fs-extra";
 import * as tar from "tar";
 import { isWindows } from "../common/vars";
-import winston from "winston";
+import type winston from "winston";
 
 export type LensBinaryOpts = {
   version: string;
@@ -204,7 +204,7 @@ export class LensBinary {
       throw(error);
     });
 
-    return new Promise((resolve, reject) => {
+    return new Promise<void>((resolve, reject) => {
       file.on("close", () => {
         this.logger.debug(`${this.originalBinaryName} binary download closed`);
         if (!this.tarPath) fs.chmod(binaryPath, 0o755, (err) => {

src/main/menu.ts

@@ -21,7 +21,7 @@
 
 import { app, BrowserWindow, dialog, ipcMain, IpcMainEvent, Menu, MenuItem, MenuItemConstructorOptions, webContents, shell } from "electron";
 import { autorun } from "mobx";
-import { WindowManager } from "./window-manager";
+import type { WindowManager } from "./window-manager";
 import { appName, isMac, isWindows, isTestEnv, docsUrl, supportUrl, productName } from "../common/vars";
 import { addClusterURL } from "../renderer/components/+add-cluster/add-cluster.route";
 import { preferencesURL } from "../renderer/components/+preferences/preferences.route";

src/main/prometheus/helm.ts

@@ -20,8 +20,8 @@
  */
 
 import { PrometheusLens } from "./lens";
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { CoreV1Api } from "@kubernetes/client-node";
-import { PrometheusService } from "./provider-registry";
+import type { PrometheusService } from "./provider-registry";
 import logger from "../logger";
 
 export class PrometheusHelm extends PrometheusLens {
@@ -29,7 +29,7 @@ export class PrometheusHelm extends PrometheusLens {
   name = "Helm";
   rateAccuracy = "5m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     const labelSelector = "app=prometheus,component=server,heritage=Helm";
 
     try {

src/main/prometheus/lens.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { CoreV1Api } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusLens implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusLens implements PrometheusProvider {
   name = "Lens";
   rateAccuracy = "1m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       const resp = await client.readNamespacedService("prometheus", "lens-metrics");
       const service = resp.body;
@@ -44,7 +44,7 @@ export class PrometheusLens implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/prometheus/operator.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api, V1Service } from "@kubernetes/client-node";
+import type { CoreV1Api, V1Service } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusOperator implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusOperator implements PrometheusProvider {
   id = "operator";
   name = "Prometheus Operator";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       let service: V1Service;
 
@@ -54,7 +54,7 @@ export class PrometheusOperator implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/prometheus/provider-registry.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { CoreV1Api } from "@kubernetes/client-node";
 
 export type PrometheusClusterQuery = {
   memoryUsage: string;
@@ -83,8 +83,8 @@ export type PrometheusService = {
 export interface PrometheusProvider {
   id: string;
   name: string;
-  getQueries(opts: PrometheusQueryOpts): PrometheusQuery;
+  getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void;
-  getPrometheusService(client: CoreV1Api): Promise<PrometheusService>;
+  getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void>;
 }
 
 export type PrometheusProviderList = {

src/main/prometheus/stacklight.ts

@@ -19,8 +19,8 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
+import type { PrometheusProvider, PrometheusQueryOpts, PrometheusQuery, PrometheusService } from "./provider-registry";
-import { CoreV1Api } from "@kubernetes/client-node";
+import type { CoreV1Api } from "@kubernetes/client-node";
 import logger from "../logger";
 
 export class PrometheusStacklight implements PrometheusProvider {
@@ -28,7 +28,7 @@ export class PrometheusStacklight implements PrometheusProvider {
   name = "Stacklight";
   rateAccuracy = "1m";
 
-  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService> {
+  public async getPrometheusService(client: CoreV1Api): Promise<PrometheusService | void> {
     try {
       const resp = await client.readNamespacedService("prometheus-server", "stacklight");
       const service = resp.body;
@@ -44,7 +44,7 @@ export class PrometheusStacklight implements PrometheusProvider {
     }
   }
 
-  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery {
+  public getQueries(opts: PrometheusQueryOpts): PrometheusQuery | void {
     switch(opts.category) {
       case "cluster":
         return {

src/main/protocol-handler/router.ts

@@ -22,7 +22,7 @@
 import logger from "../logger";
 import * as proto from "../../common/protocol-handler";
 import Url from "url-parse";
-import { LensExtension } from "../../extensions/lens-extension";
+import type { LensExtension } from "../../extensions/lens-extension";
 import { broadcastMessage } from "../../common/ipc";
 import { observable, when } from "mobx";
 

src/main/proxy/lens-proxy.ts

@@ -20,13 +20,13 @@
  */
 
 import net from "net";
-import http from "http";
+import type http from "http";
 import spdy from "spdy";
 import httpProxy from "http-proxy";
 import url from "url";
 import { apiPrefix, apiKubePrefix } from "../../common/vars";
 import { Router } from "../router";
-import { ContextHandler } from "../context-handler";
+import type { ContextHandler } from "../context-handler";
 import logger from "../logger";
 import { Singleton } from "../../common/utils";
 import { ClusterManager } from "../cluster-manager";
@@ -205,13 +205,13 @@ export class LensProxy extends Singleton {
     return proxy;
   }
 
-  protected async getProxyTarget(req: http.IncomingMessage, contextHandler: ContextHandler): Promise<httpProxy.ServerOptions> {
+  protected async getProxyTarget(req: http.IncomingMessage, contextHandler: ContextHandler): Promise<httpProxy.ServerOptions | void> {
     if (req.url.startsWith(apiKubePrefix)) {
       delete req.headers.authorization;
       req.url = req.url.replace(apiKubePrefix, "");
       const isWatchRequest = req.url.includes("watch=");
 
-      return await contextHandler.getApiTarget(isWatchRequest);
+      return contextHandler.getApiTarget(isWatchRequest);
     }
   }
 

src/main/proxy/ws-upgrade.ts

@@ -26,8 +26,8 @@
  */
 
 import * as WebSocket from "ws";
-import http from "http";
+import type http from "http";
-import net from "net";
+import type net from "net";
 import url from "url";
 import { NodeShellSession, LocalShellSession } from "../shell-session";
 import { ClusterManager } from "../cluster-manager";

src/main/resource-applier.ts

@@ -20,7 +20,7 @@
  */
 
 import type { Cluster } from "./cluster";
-import { KubernetesObject } from "@kubernetes/client-node";
+import type { KubernetesObject } from "@kubernetes/client-node";
 import { exec } from "child_process";
 import fs from "fs";
 import * as yaml from "js-yaml";

src/main/router.ts

@@ -21,10 +21,10 @@
 
 import Call from "@hapi/call";
 import Subtext from "@hapi/subtext";
-import http from "http";
+import type http from "http";
 import path from "path";
 import { readFile } from "fs-extra";
-import { Cluster } from "./cluster";
+import type { Cluster } from "./cluster";
 import { apiPrefix, appName, publicPath, isDevelopment, webpackDevServerPort } from "../common/vars";
 import { HelmApiRoute, KubeconfigRoute, MetricsRoute, PortForwardRoute, ResourceApplierApiRoute, VersionRoute } from "./routes";
 import logger from "./logger";

src/main/routes/helm-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { helmService } from "../helm/helm-service";
 import { respondJson, respondText } from "../utils/http-responses";
 import logger from "../logger";

src/main/routes/kubeconfig-route.ts

@@ -19,9 +19,9 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { CoreV1Api, V1Secret } from "@kubernetes/client-node";
 
 function generateKubeConfig(username: string, secret: V1Secret, cluster: Cluster) {

src/main/routes/metrics-route.ts

@@ -20,10 +20,10 @@
  */
 
 import _ from "lodash";
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
 import { Cluster, ClusterMetadataKey } from "../cluster";
-import { ClusterPrometheusMetadata } from "../../common/cluster-store";
+import type { ClusterPrometheusMetadata } from "../../common/cluster-store";
 import logger from "../logger";
 import { getMetrics } from "../k8s-request";
 

src/main/routes/port-forward-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { spawn, ChildProcessWithoutNullStreams } from "child_process";
 import { Kubectl } from "../kubectl";
 import { shell } from "electron";

src/main/routes/resource-applier-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson, respondText } from "../utils/http-responses";
 import { ResourceApplier } from "../resource-applier";
 

src/main/routes/version-route.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { LensApiRequest } from "../router";
+import type { LensApiRequest } from "../router";
 import { respondJson } from "../utils/http-responses";
 import { getAppVersion } from "../../common/utils";
 

src/main/shell-session/node-shell-session.ts

@@ -19,11 +19,11 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import * as WebSocket from "ws";
+import type * as WebSocket from "ws";
 import { v4 as uuid } from "uuid";
 import * as k8s from "@kubernetes/client-node";
-import { KubeConfig } from "@kubernetes/client-node";
+import type { KubeConfig } from "@kubernetes/client-node";
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { ShellOpenError, ShellSession } from "./shell-session";
 
 export class NodeShellSession extends ShellSession {

src/main/shell-session/shell-session.ts

@@ -19,9 +19,9 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { Cluster } from "../cluster";
+import type { Cluster } from "../cluster";
 import { Kubectl } from "../kubectl";
-import * as WebSocket from "ws";
+import type * as WebSocket from "ws";
 import shellEnv from "shell-env";
 import { app } from "electron";
 import { clearKubeconfigEnvVars } from "../utils/clear-kube-env-vars";

src/main/tray.ts

@@ -25,7 +25,7 @@ import { Menu, Tray } from "electron";
 import { autorun } from "mobx";
 import { showAbout } from "./menu";
 import { checkForUpdates, isAutoUpdateEnabled } from "./app-updater";
-import { WindowManager } from "./window-manager";
+import type { WindowManager } from "./window-manager";
 import { preferencesURL } from "../renderer/components/+preferences/preferences.route";
 import logger from "./logger";
 import { isDevelopment, isWindows, productName } from "../common/vars";

src/main/utils/get-port.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import { Readable } from "stream";
+import type { Readable } from "stream";
 import URLParse from "url-parse";
 
 interface GetPortArgs {

src/main/utils/http-responses.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import http from "http";
+import type http from "http";
 
 export function respondJson(res: http.ServerResponse, content: any, status = 200) {
   respond(res, JSON.stringify(content), "application/json", status);

src/migrations/cluster-store/snap.ts

@@ -22,7 +22,7 @@
 // Fix embedded kubeconfig paths under snap config
 
 import { migration } from "../migration-wrapper";
-import { ClusterModel } from "../../common/cluster-store";
+import type { ClusterModel } from "../../common/cluster-store";
 import { getAppVersion } from "../../common/utils/app-version";
 import fs from "fs";
 

src/migrations/hotbar-store/5.0.0-alpha.0.ts

@@ -20,7 +20,7 @@
  */
 
 // Cleans up a store that had the state related data stored
-import { Hotbar } from "../../common/hotbar-store";
+import type { Hotbar } from "../../common/hotbar-store";
 import { ClusterStore } from "../../common/cluster-store";
 import { migration } from "../migration-wrapper";
 import { v4 as uuid } from "uuid";

src/migrations/hotbar-store/5.0.0-alpha.2.ts

@@ -20,7 +20,7 @@
  */
 
 // Cleans up a store that had the state related data stored
-import { Hotbar } from "../../common/hotbar-store";
+import type { Hotbar } from "../../common/hotbar-store";
 import { migration } from "../migration-wrapper";
 import * as uuid from "uuid";
 

src/migrations/migration-wrapper.ts

@@ -19,7 +19,7 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-import Config from "conf";
+import type Config from "conf";
 import { isTestEnv } from "../common/vars";
 
 export interface MigrationOpts {

src/renderer/api/__tests__/crd.test.ts

@@ -20,7 +20,7 @@
  */
 
 import { CustomResourceDefinition } from "../endpoints";
-import { IKubeObjectMetadata } from "../kube-object";
+import type { IKubeObjectMetadata } from "../kube-object";
 
 describe("Crds", () => {
   describe("getVersion", () => {

src/renderer/api/catalog-entity.ts

@@ -21,7 +21,7 @@
 
 import { navigate } from "../navigation";
 import { commandRegistry } from "../../extensions/registries";
-import { CatalogEntity } from "../../common/catalog";
+import type { CatalogEntity } from "../../common/catalog";
 
 export {
   CatalogCategory,

src/renderer/api/endpoints/configmap.api.ts

@@ -20,7 +20,7 @@
  */
 
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";
 

src/renderer/api/endpoints/cron-job.api.ts

@@ -21,7 +21,7 @@
 
 import moment from "moment";
 import { KubeObject } from "../kube-object";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { formatDuration } from "../../utils/formatDuration";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/endpoints/daemon-set.api.ts

@@ -20,7 +20,7 @@
  */
 
 import get from "lodash/get";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/endpoints/helm-releases.api.ts

@@ -25,9 +25,9 @@ import { autobind, formatDuration } from "../../utils";
 import capitalize from "lodash/capitalize";
 import { apiBase } from "../index";
 import { helmChartStore } from "../../components/+apps-helm-charts/helm-chart.store";
-import { ItemObject } from "../../item.store";
+import type { ItemObject } from "../../item.store";
 import { KubeObject } from "../kube-object";
-import { JsonApiData } from "../json-api";
+import type { JsonApiData } from "../json-api";
 
 interface IReleasePayload {
   name: string;

src/renderer/api/endpoints/job.api.ts

@@ -22,9 +22,9 @@
 import get from "lodash/get";
 import { autobind } from "../../utils";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { KubeApi } from "../kube-api";
-import { JsonApiParams } from "../json-api";
+import type { JsonApiParams } from "../json-api";
 
 @autobind()
 export class Job extends WorkloadKubeObject {
@@ -106,11 +106,7 @@ export class Job extends WorkloadKubeObject {
   getCondition() {
     // Type of Job condition could be only Complete or Failed
     // https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#jobcondition-v1-batch
-    const { conditions } = this.status;
+    return this.status.conditions?.find(({ status }) => status === "True");
-
-    if (!conditions) return;
-
-    return conditions.find(({ status }) => status === "True");
   }
 
   getImages() {

src/renderer/api/endpoints/metrics.api.ts

@@ -132,11 +132,11 @@ export function normalizeMetrics(metrics: IMetrics, frames = 60): IMetrics {
   return metrics;
 }
 
-export function isMetricsEmpty(metrics: { [key: string]: IMetrics }) {
+export function isMetricsEmpty(metrics: Record<string, IMetrics>) {
   return Object.values(metrics).every(metric => !metric?.data?.result?.length);
 }
 
-export function getItemMetrics(metrics: { [key: string]: IMetrics }, itemName: string): { [key: string]: IMetrics } {
+export function getItemMetrics(metrics: Record<string, IMetrics>, itemName: string): Record<string, IMetrics> | void {
   if (!metrics) return;
   const itemMetrics = { ...metrics };
 
@@ -153,7 +153,7 @@ export function getItemMetrics(metrics: { [key: string]: IMetrics }, itemName: s
   return itemMetrics;
 }
 
-export function getMetricLastPoints(metrics: { [key: string]: IMetrics }) {
+export function getMetricLastPoints(metrics: Record<string, IMetrics>) {
   const result: Partial<{ [metric: string]: number }> = {};
 
   Object.keys(metrics).forEach(metricName => {

src/renderer/api/endpoints/persistent-volume-claims.api.ts

@@ -22,7 +22,7 @@
 import { KubeObject } from "../kube-object";
 import { autobind } from "../../utils";
 import { IMetrics, metricsApi } from "./metrics.api";
-import { Pod } from "./pods.api";
+import type { Pod } from "./pods.api";
 import { KubeApi } from "../kube-api";
 
 export class PersistentVolumeClaimsApi extends KubeApi<PersistentVolumeClaim> {

src/renderer/api/endpoints/persistent-volume.api.ts

@@ -61,7 +61,7 @@ export class PersistentVolume extends KubeObject {
     };
   };
 
-  status: {
+  status?: {
     phase: string;
     reason?: string;
   };
@@ -79,9 +79,7 @@ export class PersistentVolume extends KubeObject {
   }
 
   getStatus() {
-    if (!this.status) return;
+    return this.status?.phase || "-";
-
-    return this.status.phase || "-";
   }
 
   getStorageClass(): string {

src/renderer/api/endpoints/replica-set.api.ts

@@ -22,7 +22,7 @@
 import get from "lodash/get";
 import { autobind } from "../../utils";
 import { WorkloadKubeObject } from "../workload-kube-object";
-import { IPodContainer, Pod } from "./pods.api";
+import type { IPodContainer, Pod } from "./pods.api";
 import { KubeApi } from "../kube-api";
 
 export class ReplicaSetApi extends KubeApi<ReplicaSet> {

src/renderer/api/endpoints/resource-applier.api.ts

@@ -21,7 +21,7 @@
 
 import jsYaml from "js-yaml";
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { apiBase } from "../index";
 import { apiManager } from "../api-manager";
 

src/renderer/api/endpoints/resource-quota.api.ts

@@ -21,7 +21,7 @@
 
 import { KubeObject } from "../kube-object";
 import { KubeApi } from "../kube-api";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 
 export interface IResourceQuotaValues {
   [quota: string]: string;

src/renderer/api/endpoints/secret.api.ts

@@ -20,7 +20,7 @@
  */
 
 import { KubeObject } from "../kube-object";
-import { KubeJsonApiData } from "../kube-json-api";
+import type { KubeJsonApiData } from "../kube-json-api";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";
 

src/renderer/api/endpoints/stateful-set.api.ts

@@ -20,7 +20,7 @@
  */
 
 import get from "lodash/get";
-import { IPodContainer } from "./pods.api";
+import type { IPodContainer } from "./pods.api";
 import { IAffinity, WorkloadKubeObject } from "../workload-kube-object";
 import { autobind } from "../../utils";
 import { KubeApi } from "../kube-api";

src/renderer/api/kube-api.ts

@@ -30,7 +30,7 @@ import { apiKube } from "./index";
 import { createKubeApiURL, parseKubeApi } from "./kube-api-parse";
 import { IKubeObjectConstructor, KubeObject, KubeStatus } from "./kube-object";
 import byline from "byline";
-import { IKubeWatchEvent } from "./kube-watch-api";
+import type { IKubeWatchEvent } from "./kube-watch-api";
 import { ReadableWebToNodeStream } from "../utils/readableStream";
 import { KubeJsonApi, KubeJsonApiData } from "./kube-json-api";
 import { noop } from "../utils";
@@ -306,7 +306,7 @@ export class KubeApi<T extends KubeObject = any> {
   }
 
   protected parseResponse(data: unknown, namespace?: string): T | T[] | null {
-    if (!data) return;
+    if (!data) return null;
     const KubeObjectConstructor = this.objectConstructor;
 
     // process items list response, check before single item since there is overlap

src/renderer/api/kube-object.ts

@@ -22,11 +22,11 @@
 // Base class for all kubernetes objects
 
 import moment from "moment";
-import { KubeJsonApiData, KubeJsonApiDataList, KubeJsonApiListMetadata, KubeJsonApiMetadata } from "./kube-json-api";
+import type { KubeJsonApiData, KubeJsonApiDataList, KubeJsonApiListMetadata, KubeJsonApiMetadata } from "./kube-json-api";
 import { autobind, formatDuration } from "../utils";
-import { ItemObject } from "../item.store";
+import type { ItemObject } from "../item.store";
 import { apiKube } from "./index";
-import { JsonApiParams } from "./json-api";
+import type { JsonApiParams } from "./json-api";
 import { resourceApplierApi } from "./endpoints/resource-applier.api";
 import { hasOptionalProperty, hasTypedProperty, isObject, isString, bindPredicate, isTypedArray, isRecord } from "../../common/utils/type-narrowing";
 

src/renderer/api/kube-watch-api.ts

@@ -28,8 +28,8 @@ import type { ClusterContext } from "../components/context";
 import plimit from "p-limit";
 import { comparer, IReactionDisposer, observable, reaction, when } from "mobx";
 import { autobind, noop } from "../utils";
-import { KubeApi } from "./kube-api";
+import type { KubeApi } from "./kube-api";
-import { KubeJsonApiData } from "./kube-json-api";
+import type { KubeJsonApiData } from "./kube-json-api";
 import { isDebugging, isProduction } from "../../common/vars";
 
 export interface IKubeWatchEvent<T = KubeJsonApiData> {

src/renderer/api/terminal-api.ts

@@ -108,7 +108,7 @@ export class TerminalApi extends WebSocketApi {
 
   @autobind()
   protected _onReady(data: string) {
-    if (!data) return;
+    if (!data) return true;
     this.isReady = true;
     this.onReady.emit();
     this.onData.removeListener(this._onReady);

src/renderer/components/+apps-helm-charts/helm-charts.tsx

@@ -22,11 +22,11 @@
 import "./helm-charts.scss";
 
 import React, { Component } from "react";
-import { RouteComponentProps } from "react-router";
+import type { RouteComponentProps } from "react-router";
 import { observer } from "mobx-react";
 import { helmChartsURL, IHelmChartsRouteParams } from "./helm-charts.route";
 import { helmChartStore } from "./helm-chart.store";
-import { HelmChart } from "../../api/endpoints/helm-charts.api";
+import type { HelmChart } from "../../api/endpoints/helm-charts.api";
 import { HelmChartDetails } from "./helm-chart-details";
 import { navigation } from "../../navigation";
 import { ItemListLayout } from "../item-object-list/item-list-layout";

src/renderer/components/+apps-releases/release-menu.tsx

@@ -20,7 +20,7 @@
  */
 
 import React from "react";
-import { HelmRelease } from "../../api/endpoints/helm-releases.api";
+import type { HelmRelease } from "../../api/endpoints/helm-releases.api";
 import { autobind, cssNames } from "../../utils";
 import { releaseStore } from "./release.store";
 import { MenuActions, MenuActionsProps } from "../menu/menu-actions";
@@ -56,7 +56,7 @@ export class HelmReleaseMenu extends React.Component<Props> {
   renderContent() {
     const { release, toolbar } = this.props;
 
-    if (!release) return;
+    if (!release) return null;
     const hasRollback = release && release.getRevision() > 1;
 
     return (

src/renderer/components/+apps-releases/release.store.ts

@@ -24,7 +24,7 @@ import { action, observable, reaction, when } from "mobx";
 import { autobind } from "../../utils";
 import { createRelease, deleteRelease, HelmRelease, IReleaseCreatePayload, IReleaseUpdatePayload, listReleases, rollbackRelease, updateRelease } from "../../api/endpoints/helm-releases.api";
 import { ItemStore } from "../../item.store";
-import { Secret } from "../../api/endpoints";
+import type { Secret } from "../../api/endpoints";
 import { secretsStore } from "../+config-secrets/secrets.store";
 import { namespaceStore } from "../+namespaces/namespace.store";
 import { Notifications } from "../notifications";
@@ -146,8 +146,6 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
   }
 
   async removeSelectedItems() {
-    if (!this.selectedItems.length) return;
-
     return Promise.all(this.selectedItems.map(this.remove));
   }
 }

src/renderer/components/+apps-releases/releases.tsx

@@ -24,10 +24,10 @@ import "./releases.scss";
 import React, { Component } from "react";
 import kebabCase from "lodash/kebabCase";
 import { disposeOnUnmount, observer } from "mobx-react";
-import { RouteComponentProps } from "react-router";
+import type { RouteComponentProps } from "react-router";
 import { releaseStore } from "./release.store";
 import { IReleaseRouteParams, releaseURL } from "./release.route";
-import { HelmRelease } from "../../api/endpoints/helm-releases.api";
+import type { HelmRelease } from "../../api/endpoints/helm-releases.api";
 import { ReleaseDetails } from "./release-details";
 import { ReleaseRollbackDialog } from "./release-rollback-dialog";
 import { navigation } from "../../navigation";

src/renderer/components/+catalog/catalog-add-button.tsx

@@ -26,7 +26,7 @@ import { Icon } from "../icon";
 import { disposeOnUnmount, observer } from "mobx-react";
 import { observable, reaction } from "mobx";
 import { autobind } from "../../../common/utils";
-import { CatalogCategory, CatalogEntityAddMenuContext, CatalogEntityContextMenu } from "../../api/catalog-entity";
+import type { CatalogCategory, CatalogEntityAddMenuContext, CatalogEntityContextMenu } from "../../api/catalog-entity";
 import { EventEmitter } from "events";
 import { navigate } from "../../navigation";
 

src/renderer/components/+catalog/catalog-entity.store.ts

@@ -21,7 +21,7 @@
 
 import { action, computed, IReactionDisposer, observable, reaction } from "mobx";
 import { catalogEntityRegistry } from "../../api/catalog-entity-registry";
-import { CatalogEntity, CatalogEntityActionContext } from "../../api/catalog-entity";
+import type { CatalogEntity, CatalogEntityActionContext } from "../../api/catalog-entity";
 import { ItemObject, ItemStore } from "../../item.store";
 import { autobind } from "../../utils";
 import { CatalogCategory } from "../../../common/catalog";

src/renderer/components/+cluster/cluster-issues.tsx

@@ -30,7 +30,7 @@ import { Table, TableCell, TableHead, TableRow } from "../table";
 import { nodesStore } from "../+nodes/nodes.store";
 import { eventStore } from "../+events/event.store";
 import { autobind, cssNames, prevDefault } from "../../utils";
-import { ItemObject } from "../../item.store";
+import type { ItemObject } from "../../item.store";
 import { Spinner } from "../spinner";
 import { ThemeStore } from "../../theme.store";
 import { lookupApiLink } from "../../api/kube-api";

src/renderer/components/+cluster/cluster-metrics.tsx

@@ -23,7 +23,7 @@ import "./cluster-metrics.scss";
 
 import React from "react";
 import { observer } from "mobx-react";
-import { ChartOptions, ChartPoint } from "chart.js";
+import type { ChartOptions, ChartPoint } from "chart.js";
 import { clusterOverviewStore, MetricType } from "./cluster-overview.store";
 import { BarChart } from "../chart";
 import { bytesToUnits } from "../../utils";

src/renderer/components/+config-autoscalers/hpa-details.tsx

@@ -100,7 +100,7 @@ export class HpaDetails extends React.Component<Props> {
   render() {
     const { object: hpa } = this.props;
 
-    if (!hpa) return;
+    if (!hpa) return null;
     const { scaleTargetRef } = hpa.spec;
 
     return (

src/renderer/components/+config-autoscalers/hpa.tsx

@@ -23,10 +23,10 @@ import "./hpa.scss";
 
 import React from "react";
 import { observer } from "mobx-react";
-import { RouteComponentProps } from "react-router";
+import type { RouteComponentProps } from "react-router";
 import { KubeObjectListLayout } from "../kube-object";
-import { IHpaRouteParams } from "./hpa.route";
+import type { IHpaRouteParams } from "./hpa.route";
-import { HorizontalPodAutoscaler } from "../../api/endpoints/hpa.api";
+import type { HorizontalPodAutoscaler } from "../../api/endpoints/hpa.api";
 import { hpaStore } from "./hpa.store";
 import { Badge } from "../badge";
 import { cssNames } from "../../utils";