diff --git a/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts b/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts index fe997e62fb..db9c262279 100644 --- a/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts +++ b/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts @@ -9,19 +9,17 @@ import processCheckingForUpdatesInjectable from "../../../main/process-checking- import showApplicationWindowInjectable from "../../../../../main/start-main-application/lens-window/show-application-window.injectable"; import updatingIsEnabledInjectable from "../../../main/updating-is-enabled/updating-is-enabled.injectable"; import isMacInjectable from "../../../../../common/vars/is-mac.injectable"; +// import showSuccessNotificationInjectable from "../../../../../renderer/components/notifications/show-success-notification.injectable"; const checkForUpdatesMenuItemInjectable = getInjectable({ id: "check-for-updates-menu-item", instantiate: (di) => { - const processCheckingForUpdates = di.inject( - processCheckingForUpdatesInjectable, - ); - + const processCheckingForUpdates = di.inject(processCheckingForUpdatesInjectable,); const showApplicationWindow = di.inject(showApplicationWindowInjectable); - const updatingIsEnabled = di.inject(updatingIsEnabledInjectable); const isMac = di.inject(isMacInjectable); + // const showSuccessNotification = di.inject(showSuccessNotificationInjectable); return { kind: "clickable-menu-item" as const, @@ -31,11 +29,16 @@ const checkForUpdatesMenuItemInjectable = getInjectable({ label: "Check for updates", isShown: updatingIsEnabled, - onClick: () => { - // Todo: implement using async/await - processCheckingForUpdates("application-menu").then(() => - showApplicationWindow(), - ); + onClick: async () => { + const { updateIsReadyToBeInstalled } = await processCheckingForUpdates("application-menu"); + + if (updateIsReadyToBeInstalled) { + await showApplicationWindow(); + } else { + // showSuccessNotification( + // `You're all good\n\nYou've got the latest version of Lens\nthanks for staying on the ball.`, + // ); + } }, }; }, diff --git a/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts b/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts index e904abaa99..4b1a45ae14 100644 --- a/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts +++ b/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts @@ -16,6 +16,7 @@ import processCheckingForUpdatesInjectable from "../../../../main/process-checki import { withErrorSuppression } from "../../../../../../common/utils/with-error-suppression/with-error-suppression"; import { pipeline } from "@ogre-tools/fp"; import withErrorLoggingInjectable from "../../../../../../common/utils/with-error-logging/with-error-logging.injectable"; +// import showSuccessNotificationInjectable from "../../../../../../renderer/components/notifications/show-success-notification.injectable"; const checkForUpdatesTrayItemInjectable = getInjectable({ id: "check-for-updates-tray-item", @@ -29,6 +30,7 @@ const checkForUpdatesTrayItemInjectable = getInjectable({ const checkingForUpdatesState = di.inject(updatesAreBeingDiscoveredInjectable); const processCheckingForUpdates = di.inject(processCheckingForUpdatesInjectable); const withErrorLoggingFor = di.inject(withErrorLoggingInjectable); + // const showSuccessNotification = di.inject(showSuccessNotificationInjectable); return { id: "check-for-updates", @@ -63,6 +65,10 @@ const checkForUpdatesTrayItemInjectable = getInjectable({ if (updateIsReadyToBeInstalled) { await showApplicationWindow(); + } else { + // showSuccessNotification( + // `You're all good\n\nYou've got the latest version of Lens\nthanks for staying on the ball.`, + // ); } },