hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Simplify the implementation

Browse Source 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
This commit is contained in:
Lauri Nevala 2020-09-18 09:47:16 +03:00
parent b8890e55cf
commit 47f9456921
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/renderer/components/+user-management-service-accounts/service-accounts-details.tsx
View File

@ -39,9 +39,9 @@ export class ServiceAccountsDetails extends React.Component<Props> {
}); });
this.secrets = await Promise.all(secrets); this.secrets = await Promise.all(secrets);
const imagePullSecrets = serviceAccount.getImagePullSecrets().map(async({ name }) => { const imagePullSecrets = serviceAccount.getImagePullSecrets().map(async({ name }) => {
return secretsStore.load({ name, namespace }).catch(_err => { return null }); return secretsStore.load({ name, namespace }).catch(_err => { return this.generateDummySecretObject(name) });
}); });
this.imagePullSecrets = (await Promise.all(imagePullSecrets)).filter(secret => !!secret) this.imagePullSecrets = (await Promise.all(imagePullSecrets))
}) })
renderSecrets() { renderSecrets() {
@ -54,20 +54,12 @@ export class ServiceAccountsDetails extends React.Component<Props> {
) )
} }
renderImagePullSecrets(imagePullSecretNames: { name: string; }[]) { renderImagePullSecrets() {
const { imagePullSecrets } = this; const { imagePullSecrets } = this;
if (!imagePullSecrets) { if (!imagePullSecrets) {
return <Spinner center/> return <Spinner center/>
} }
const secrets = imagePullSecretNames.map(({name}) => { return this.renderSecretLinks(imagePullSecrets)
let secret = imagePullSecrets.find((secret) => secret.getName() === name)
if (!secret) {
secret = this.generateDummySecretObject(name)
}
return secret
})
return this.renderSecretLinks(secrets)
} }
renderSecretLinks(secrets: Secret[]) { renderSecretLinks(secrets: Secret[]) {
@ -125,7 +117,7 @@ export class ServiceAccountsDetails extends React.Component<Props> {
} }
{imagePullSecrets.length > 0 && {imagePullSecrets.length > 0 &&
<DrawerItem name={<Trans>ImagePullSecrets</Trans>} className="links"> <DrawerItem name={<Trans>ImagePullSecrets</Trans>} className="links">
{this.renderImagePullSecrets(imagePullSecrets)} {this.renderImagePullSecrets()}
</DrawerItem> </DrawerItem>
} }