mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Add +/- buttons in scale deployment popup screen (#1191)
* Add @testing-library/jest-dom and @testing-library/react for writing test cases * Make eslint check __mocks__/*.ts files * Mock electron.ipcRenderer.on to prevent errors in React compoment test cases * Mock <Trans /> from @lingui/macro as a component simplely returns children components * Use optional chaining operator (?.) to avoid TypeError: Cannot read property 'replicas' of undefined * Add jest-fetch-mock for mocking global.fetch, activate for all test cases in jest.setup.ts * Add basic tests for <DeploymentScaleDialog /> to ensure it initialises/renders without errors * Add +/- button for changing desired replicas, and its test cases * Adjust the styles of +/- buttons container to make sure it aligns with the slider * Refactor after rebase from master * Use var defined in vars.scss * Add flex align-center to slider-container and remove margin-top: -4px * Use <Icon /> to replace <i/> * Add flex gaps to plus-minus-container Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
This commit is contained in:
10 files changed
+414
-11
No files matched your search
@@ -10,7 +10,7 @@ export class DeploymentApi extends KubeApi<Deployment> {
|
||||
getReplicas(params: { namespace: string; name: string }): Promise<number> {
|
||||
return this.request
|
||||
.get(this.getScaleApiUrl(params))
|
||||
.then(({ status }: any) => status.replicas)
|
||||
.then(({ status }: any) => status?.replicas)
|
||||
}
|
||||
|
||||
scale(params: { namespace: string; name: string }, replicas: number) {
|
||||
|
||||
Reference in new issue
Block a user