From 4a3f08d798dd535b6b6e1749f562c38a715b7acd Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Thu, 23 Mar 2023 11:37:10 +0300 Subject: [PATCH] Fix Check for updates menu item title capitalisation (#7396) * Check for updates -> Check for Updates Signed-off-by: Alex Andreev * Revert debugging changes Signed-off-by: Alex Andreev * Adding ellipsis to every Check for Updates items Signed-off-by: Alex Andreev --------- Signed-off-by: Alex Andreev --- .../main/check-for-updates-menu-item.injectable.ts | 2 +- .../installing-update-using-tray.test.ts | 8 ++++---- .../tray-items/check-for-updates-tray-item.injectable.ts | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts b/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts index fe997e62fb..97b9acf9f8 100644 --- a/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts +++ b/packages/core/src/features/application-update/child-features/application-update-using-application-menu/main/check-for-updates-menu-item.injectable.ts @@ -28,7 +28,7 @@ const checkForUpdatesMenuItemInjectable = getInjectable({ id: "check-for-updates", parentId: isMac ? "mac" : "help", orderNumber: isMac ? 20 : 50, - label: "Check for updates", + label: "Check for Updates...", isShown: updatingIsEnabled, onClick: () => { diff --git a/packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts b/packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts index d5caa63149..f18f288469 100644 --- a/packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts +++ b/packages/core/src/features/application-update/child-features/application-update-using-tray/installing-update-using-tray.test.ts @@ -146,7 +146,7 @@ describe("installing update using tray", () => { it("name of tray item for checking updates indicates that checking is happening", () => { expect( builder.tray.get("check-for-updates")?.label, - ).toBe("Checking for updates..."); + ).toBe("Checking for Updates..."); }); it("user cannot install update yet", () => { @@ -177,7 +177,7 @@ describe("installing update using tray", () => { it("name of tray item for checking updates no longer indicates that checking is happening", () => { expect( builder.tray.get("check-for-updates")?.label, - ).toBe("Check for updates"); + ).toBe("Check for Updates..."); }); it("renders", () => { @@ -241,7 +241,7 @@ describe("installing update using tray", () => { it("name of tray item for checking updates no longer indicates that downloading is happening", () => { expect( builder.tray.get("check-for-updates")?.label, - ).toBe("Check for updates"); + ).toBe("Check for Updates..."); }); it("renders", () => { @@ -269,7 +269,7 @@ describe("installing update using tray", () => { it("name of tray item for checking updates no longer indicates that downloading is happening", () => { expect( builder.tray.get("check-for-updates")?.label, - ).toBe("Check for updates"); + ).toBe("Check for Updates..."); }); it("renders", () => { diff --git a/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts b/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts index e904abaa99..3f05ddb71e 100644 --- a/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts +++ b/packages/core/src/features/application-update/child-features/application-update-using-tray/main/tray-items/check-for-updates-tray-item.injectable.ts @@ -47,10 +47,10 @@ const checkForUpdatesTrayItemInjectable = getInjectable({ } if (checkingForUpdatesState.value.get()) { - return "Checking for updates..."; + return "Checking for Updates..."; } - return "Check for updates"; + return "Check for Updates..."; }), enabled: computed(() => !checkingForUpdatesState.value.get() && !downloadingUpdateState.value.get()),