From 4a9d4610d5cc2fb4a61d001f80f270cd52ddda87 Mon Sep 17 00:00:00 2001
From: Lauri Nevala <lauri.nevala@gmail.com>
Date: Thu, 25 Feb 2021 16:00:10 +0200
Subject: [PATCH] Display warning notification if invalid kubeconfig detected

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
---
 src/common/cluster-store.ts                   |  8 +++-
 src/common/ipc/index.ts                       |  1 +
 src/common/ipc/invalid-kubeconfig/index.ts    |  3 ++
 src/main/index.ts                             |  7 ++-
 .../components/dock/create-resource.tsx       |  2 +-
 .../notifications/notifications.tsx           |  5 ++-
 src/renderer/ipc/index.tsx                    |  2 +
 .../ipc/invalid-kubeconfig-handler.tsx        | 44 +++++++++++++++++++
 8 files changed, 66 insertions(+), 6 deletions(-)
 create mode 100644 src/common/ipc/invalid-kubeconfig/index.ts
 create mode 100644 src/renderer/ipc/invalid-kubeconfig-handler.tsx

diff --git a/src/common/cluster-store.ts b/src/common/cluster-store.ts
index 2eae7da6a8..74dc7e29af 100644
--- a/src/common/cluster-store.ts
+++ b/src/common/cluster-store.ts
@@ -11,7 +11,7 @@ import { appEventBus } from "./event-bus";
 import { dumpConfigYaml } from "./kube-helpers";
 import { saveToAppFiles } from "./utils/saveToAppFiles";
 import { KubeConfig } from "@kubernetes/client-node";
-import { handleRequest, requestMain, subscribeToBroadcast, unsubscribeAllFromBroadcast } from "./ipc";
+import { broadcastMessage, handleRequest, requestMain, subscribeToBroadcast, unsubscribeAllFromBroadcast, InvalidKubeconfigChannel } from "./ipc";
 import _ from "lodash";
 import move from "array-move";
 import type { WorkspaceId } from "./workspace-store";
@@ -372,3 +372,9 @@ export function getHostedClusterId() {
 export function getHostedCluster(): Cluster {
   return clusterStore.getById(getHostedClusterId());
 }
+
+export function reportDeadClusters() {
+  clusterStore.clustersList.filter(cluster => cluster.isDead).forEach(cluster => {
+    broadcastMessage(InvalidKubeconfigChannel, cluster.id);
+  });
+}
diff --git a/src/common/ipc/index.ts b/src/common/ipc/index.ts
index a34890472e..c5e864dc75 100644
--- a/src/common/ipc/index.ts
+++ b/src/common/ipc/index.ts
@@ -1,3 +1,4 @@
 export * from "./ipc";
+export * from "./invalid-kubeconfig";
 export * from "./update-available";
 export * from "./type-enforced-ipc";
diff --git a/src/common/ipc/invalid-kubeconfig/index.ts b/src/common/ipc/invalid-kubeconfig/index.ts
new file mode 100644
index 0000000000..9e8e7921d7
--- /dev/null
+++ b/src/common/ipc/invalid-kubeconfig/index.ts
@@ -0,0 +1,3 @@
+export const InvalidKubeconfigChannel = "invalid-kubeconfig";
+
+export type InvalidKubeConfigArgs = [clusterId: string];
diff --git a/src/main/index.ts b/src/main/index.ts
index c98595fa35..05cefd9461 100644
--- a/src/main/index.ts
+++ b/src/main/index.ts
@@ -15,7 +15,7 @@ import { getFreePort } from "./port";
 import { mangleProxyEnv } from "./proxy-env";
 import { registerFileProtocol } from "../common/register-protocol";
 import logger from "./logger";
-import { clusterStore } from "../common/cluster-store";
+import { clusterStore, reportDeadClusters } from "../common/cluster-store";
 import { userStore } from "../common/user-store";
 import { workspaceStore } from "../common/workspace-store";
 import { appEventBus } from "../common/event-bus";
@@ -128,7 +128,10 @@ app.on("ready", async () => {
 
   logger.info("🖥️  Starting WindowManager");
   windowManager = WindowManager.getInstance<WindowManager>(proxyPort);
-  windowManager.whenLoaded.then(() => startUpdateChecking());
+  windowManager.whenLoaded.then(() => {
+    startUpdateChecking();
+    reportDeadClusters();
+  });
 
   logger.info("🧩 Initializing extensions");
 
diff --git a/src/renderer/components/dock/create-resource.tsx b/src/renderer/components/dock/create-resource.tsx
index 8ee859d2cf..01e6002309 100644
--- a/src/renderer/components/dock/create-resource.tsx
+++ b/src/renderer/components/dock/create-resource.tsx
@@ -52,7 +52,7 @@ export class CreateResource extends React.Component<Props> {
     );
 
     if (errors.length) {
-      errors.forEach(Notifications.error);
+      errors.forEach(error => Notifications.error(error));
       if (!createdResources.length) throw errors[0];
     }
     const successMessage = (
diff --git a/src/renderer/components/notifications/notifications.tsx b/src/renderer/components/notifications/notifications.tsx
index 0c1ac692cf..206102b1a3 100644
--- a/src/renderer/components/notifications/notifications.tsx
+++ b/src/renderer/components/notifications/notifications.tsx
@@ -21,11 +21,12 @@ export class Notifications extends React.Component {
     });
   }
 
-  static error(message: NotificationMessage) {
+  static error(message: NotificationMessage, customOpts: Partial<Notification> = {}) {
     notificationsStore.add({
       message,
       timeout: 10000,
-      status: NotificationStatus.ERROR
+      status: NotificationStatus.ERROR,
+      ...customOpts
     });
   }
 
diff --git a/src/renderer/ipc/index.tsx b/src/renderer/ipc/index.tsx
index b9644f7404..544cefbf78 100644
--- a/src/renderer/ipc/index.tsx
+++ b/src/renderer/ipc/index.tsx
@@ -5,6 +5,7 @@ import { Notifications, notificationsStore } from "../components/notifications";
 import { Button } from "../components/button";
 import { isMac } from "../../common/vars";
 import * as uuid from "uuid";
+import { invalidKubeconfigHandler } from "./invalid-kubeconfig-handler";
 
 function sendToBackchannel(backchannel: string, notificationId: string, data: BackchannelArg): void {
   notificationsStore.remove(notificationId);
@@ -58,4 +59,5 @@ export function registerIpcHandlers() {
     listener: UpdateAvailableHandler,
     verifier: areArgsUpdateAvailableFromMain,
   });
+  onCorrect(invalidKubeconfigHandler);
 }
diff --git a/src/renderer/ipc/invalid-kubeconfig-handler.tsx b/src/renderer/ipc/invalid-kubeconfig-handler.tsx
new file mode 100644
index 0000000000..783376b880
--- /dev/null
+++ b/src/renderer/ipc/invalid-kubeconfig-handler.tsx
@@ -0,0 +1,44 @@
+import React from "react";
+import { ipcRenderer, IpcRendererEvent, shell } from "electron";
+import { clusterStore } from "../../common/cluster-store";
+import { InvalidKubeConfigArgs, InvalidKubeconfigChannel } from "../../common/ipc/invalid-kubeconfig";
+import { Notifications, notificationsStore } from "../components/notifications";
+import { Button } from "../components/button";
+
+export const invalidKubeconfigHandler = {
+  source: ipcRenderer,
+  channel: InvalidKubeconfigChannel,
+  listener: InvalidKubeconfigListener,
+  verifier: (args: [unknown]): args is InvalidKubeConfigArgs  => {
+    return args.length === 1;
+  },
+};
+
+function InvalidKubeconfigListener(event: IpcRendererEvent, ...[clusterId]: InvalidKubeConfigArgs): void {
+  const notificationId = `invalid-kubeconfig:${clusterId}`;
+  const cluster = clusterStore.getById(clusterId);
+
+  Notifications.error(
+    (
+      <div className="flex column gaps">
+        <b>Cluster with invalid Kubeconfig Detected!</b>
+        <p>Cluster <b>{cluster.name}</b> has invalid <a href="#" onClick={(e) => { e.preventDefault(); shell.showItemInFolder(cluster.kubeConfigPath); }}>Kubeconfig</a> and cannot be displayed.
+        Please fix the Kubeconfig or remove the cluster. </p>
+        <p>Do you want to remove the cluster now?</p>
+        <div className="flex gaps row align-left box grow">
+          <Button active outlined label="Remove" onClick={()=> {
+            clusterStore.removeById(clusterId);
+            notificationsStore.remove(notificationId);
+          }} />
+          <Button active outlined label="Cancel" onClick={() => notificationsStore.remove(notificationId)} />
+        </div>
+      </div>
+    ),
+    {
+      id: notificationId,
+      timeout: 0
+    }
+  );
+}
+
+