From 4b20013b1b17a568d01aa0b96b4c8b2d5f5d2e50 Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Fri, 10 Jun 2022 10:14:51 +0300 Subject: [PATCH] Show visible message instead of throwing and error in Extensions Signed-off-by: Alex Andreev --- src/renderer/components/+preferences/extensions.tsx | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/renderer/components/+preferences/extensions.tsx b/src/renderer/components/+preferences/extensions.tsx index 143a1da549..d990874588 100644 --- a/src/renderer/components/+preferences/extensions.tsx +++ b/src/renderer/components/+preferences/extensions.tsx @@ -16,7 +16,7 @@ import rendererExtensionsInjectable from "../../../extensions/renderer-extension interface Dependencies { preferenceItems: IComputedValue; - extensionName: string; + extensionName: string | undefined; } const NonInjectedExtensions = ({ preferenceItems, extensionName }: Dependencies) => ( @@ -27,6 +27,9 @@ const NonInjectedExtensions = ({ preferenceItems, extensionName }: Dependencies) {" "} preferences + {!extensionName && ( +
No extension found
+ )} {preferenceItems.get().map((preferenceItem, index) => ( ( const extensions = di.inject(rendererExtensionsInjectable); const extension = extensions.get().find((extension) => extension.sanitizedExtensionId === extensionId); - if (!extension) { - throw new Error(`Extension ${extensionId} not found`); - } + // if (!extension) { + // throw new Error(`Extension ${extensionId} not found`); + // } return { preferenceItems: di.inject(extensionsPreferenceItemsInjectable, pathParameters), - extensionName: extension.manifest.name, + extensionName: extension?.manifest.name, }; }, },