From 4b3fad57cb698bd1295c793edf1eed0e514189c1 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Thu, 19 Jan 2023 05:17:50 -0800 Subject: [PATCH] Fix extension API version being specified by library user (#6974) Signed-off-by: Sebastian Malton Signed-off-by: Sebastian Malton --- ...tension-api-version.global-override-for-injectable.ts | 9 +++++++++ src/common/vars/extension-api-version.injectable.ts | 7 ++++--- 2 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 src/common/vars/extension-api-version.global-override-for-injectable.ts diff --git a/src/common/vars/extension-api-version.global-override-for-injectable.ts b/src/common/vars/extension-api-version.global-override-for-injectable.ts new file mode 100644 index 0000000000..6d473eb1de --- /dev/null +++ b/src/common/vars/extension-api-version.global-override-for-injectable.ts @@ -0,0 +1,9 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ + +import { getGlobalOverride } from "../test-utils/get-global-override"; +import extensionApiVersionInjectable from "./extension-api-version.injectable"; + +export default getGlobalOverride(extensionApiVersionInjectable, () => "6.0.0"); diff --git a/src/common/vars/extension-api-version.injectable.ts b/src/common/vars/extension-api-version.injectable.ts index 9b84cf1177..d4ddb92f00 100644 --- a/src/common/vars/extension-api-version.injectable.ts +++ b/src/common/vars/extension-api-version.injectable.ts @@ -4,15 +4,16 @@ */ import { getInjectable } from "@ogre-tools/injectable"; import { SemVer } from "semver"; -import applicationInformationToken from "./application-information-token"; +import packageJson from "../../../package.json"; const extensionApiVersionInjectable = getInjectable({ id: "extension-api-version", - instantiate: (di) => { - const { major, minor, patch } = new SemVer(di.inject(applicationInformationToken).version); + instantiate: () => { + const { major, minor, patch } = new SemVer(packageJson.version); return `${major}.${minor}.${patch}`; }, + causesSideEffects: true, }); export default extensionApiVersionInjectable;