From 4b6bfc1232a1ba31cc5fbfc23019748cb5cfb6b2 Mon Sep 17 00:00:00 2001 From: Juho Heikka Date: Tue, 21 Feb 2023 09:24:01 +0200 Subject: [PATCH] Remove unnecessary return Signed-off-by: Juho Heikka --- ...-path-to-legacy-package-json.injectable.ts | 4 +-- .../get-path-to-legacy-package-json.test.ts | 34 ------------------- 2 files changed, 1 insertion(+), 37 deletions(-) delete mode 100644 packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.test.ts diff --git a/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.injectable.ts b/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.injectable.ts index 421bdf9e37..668d010afa 100644 --- a/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.injectable.ts +++ b/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.injectable.ts @@ -15,9 +15,7 @@ const getPathToLegacyPackageJson = getInjectable({ const directoryForUserData = di.inject(directoryForUserDataInjectable); const joinPaths = di.inject(joinPathsInjectable); - return (extensionName: string) => { - return joinPaths(directoryForUserData, "node_modules", extensionName, "package.json"); - }; + return (extensionName: string) => joinPaths(directoryForUserData, "node_modules", extensionName, "package.json"); }, }); diff --git a/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.test.ts b/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.test.ts deleted file mode 100644 index 0e2485188f..0000000000 --- a/packages/core/src/extensions/extension-loader/file-system-provisioner-store/get-path-to-legacy-package-json.test.ts +++ /dev/null @@ -1,34 +0,0 @@ -/** - * Copyright (c) OpenLens Authors. All rights reserved. - * Licensed under MIT License. See LICENSE in root directory for more information. - */ -import directoryForUserDataInjectable from "../../../common/app-paths/directory-for-user-data/directory-for-user-data.injectable"; -import { getDiForUnitTesting } from "../../../main/getDiForUnitTesting"; -import type { GetPathToLegacyPackageJson } from "./get-path-to-legacy-package-json.injectable"; -import getPathToLegacyPackageJsonInjectable from "./get-path-to-legacy-package-json.injectable"; - -describe("get-legacy-path-for-extension-name", () => { - let getPathToLegacyPackageJson: GetPathToLegacyPackageJson; - - beforeEach(() => { - const di = getDiForUnitTesting({ doGeneralOverrides: true }); - const directoryForExtensionDataMock = jest.fn().mockReturnValue("/path/to/user/data"); - - di.override(directoryForUserDataInjectable, directoryForExtensionDataMock); - getPathToLegacyPackageJson = di.inject(getPathToLegacyPackageJsonInjectable); - }); - - describe("given extension name", () => { - it("given some extension returns path for package.json in user data directory", () => { - const pathToExtensionPackageJson = getPathToLegacyPackageJson("some-extension"); - - expect(pathToExtensionPackageJson).toEqual("/path/to/user/data/node_modules/some-extension/package.json"); - }); - - it("given some other extension returns path for package.json in user data directory", () => { - const pathToExtensionPackageJson = getPathToLegacyPackageJson("some-other-extension"); - - expect(pathToExtensionPackageJson).toEqual("/path/to/user/data/node_modules/some-other-extension/package.json"); - }); - }); -});