From 4ec7b64c36d133148ea8bd59348c5e99c43db2c1 Mon Sep 17 00:00:00 2001
From: Lauri Nevala <lauri.nevala@gmail.com>
Date: Tue, 23 Feb 2021 09:42:05 +0200
Subject: [PATCH] Fine tuning

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
---
 src/main/shell-session.ts                            |  2 +-
 src/renderer/components/+preferences/preferences.tsx | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/main/shell-session.ts b/src/main/shell-session.ts
index 4b90ec401e..5c77a038c4 100644
--- a/src/main/shell-session.ts
+++ b/src/main/shell-session.ts
@@ -111,7 +111,7 @@ export class ShellSession extends EventEmitter {
       env["SystemRoot"] = process.env.SystemRoot;
       env["PTYSHELL"] = shell || "powershell.exe";
       env["PATH"] = pathStr;
-    } else if(typeof(shell) != "undefined") {
+    } else if(shell !== undefined) {
       env["PTYSHELL"] = shell;
       env["PATH"] = pathStr;
     } else {
diff --git a/src/renderer/components/+preferences/preferences.tsx b/src/renderer/components/+preferences/preferences.tsx
index c5c95bb040..365208bd05 100644
--- a/src/renderer/components/+preferences/preferences.tsx
+++ b/src/renderer/components/+preferences/preferences.tsx
@@ -6,6 +6,7 @@ import { action, computed, observable } from "mobx";
 import { Icon } from "../icon";
 import { Select, SelectOption } from "../select";
 import { userStore } from "../../../common/user-store";
+import { isWindows } from "../../../common/vars";
 import { HelmRepo, repoManager } from "../../../main/helm/helm-repo-manager";
 import { Input } from "../input";
 import { Checkbox } from "../checkbox";
@@ -110,6 +111,15 @@ export class Preferences extends React.Component {
   render() {
     const { preferences } = userStore;
     const header = <h2>Preferences</h2>;
+    let defaultShell = process.env.SHELL || process.env.PTYSHELL;
+
+    if (!defaultShell) {
+      if (isWindows) {
+        defaultShell = "powershell.exe";
+      } else {
+        defaultShell = "System default shell";
+      }
+    }
 
     return (
       <PageLayout showOnTop className="Preferences" header={header}>
@@ -134,7 +144,7 @@ export class Preferences extends React.Component {
         <h2>Terminal Shell</h2>
         <Input
           theme="round-black"
-          placeholder={process.env.SHELL || process.env.PTYSHELL}
+          placeholder={defaultShell}
           value={this.shell}
           onChange={v => this.shell = v}
           onBlur={() => preferences.shell = this.shell}