From 5198cb6f279cd412395db4a9af80511d54f36d26 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Thu, 6 Apr 2023 14:18:32 -0400 Subject: [PATCH] chore: Fix unit tests failing due to bug in cycle detection Signed-off-by: Sebastian Malton --- packages/core/src/main/getDiForUnitTesting.ts | 11 ++++++----- packages/core/src/renderer/getDiForUnitTesting.tsx | 4 +++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/core/src/main/getDiForUnitTesting.ts b/packages/core/src/main/getDiForUnitTesting.ts index d4a1cc48a7..d128bb901c 100644 --- a/packages/core/src/main/getDiForUnitTesting.ts +++ b/packages/core/src/main/getDiForUnitTesting.ts @@ -24,18 +24,19 @@ import waitUntilBundledExtensionsAreLoadedInjectable from "./start-main-applicat import initializeClusterManagerInjectable from "./cluster/initialize-manager.injectable"; import type { GlobalOverride } from "@k8slens/test-utils"; import { getOverrideFsWithFakes } from "../test-utils/override-fs-with-fakes"; -import { - setLegacyGlobalDiForExtensionApi, -} from "../extensions/as-legacy-globals-for-extension-api/legacy-global-di-for-extension-api"; +import { setLegacyGlobalDiForExtensionApi } from "../extensions/as-legacy-globals-for-extension-api/legacy-global-di-for-extension-api"; import { registerMobX } from "@ogre-tools/injectable-extension-for-mobx"; import { registerFeature } from "@k8slens/feature-core"; import { messagingFeature, testUtils as messagingTestUtils } from "@k8slens/messaging"; export function getDiForUnitTesting() { - const di = createContainer("main"); + const environment = "main"; + const di = createContainer(environment, { + detectCycles: false, + }); registerMobX(di); - setLegacyGlobalDiForExtensionApi(di, "main"); + setLegacyGlobalDiForExtensionApi(di, environment); runInAction(() => { registerFeature(di, messagingFeature, messagingTestUtils.messagingFeatureForUnitTesting); diff --git a/packages/core/src/renderer/getDiForUnitTesting.tsx b/packages/core/src/renderer/getDiForUnitTesting.tsx index ec389e1b10..ff87ceafbd 100644 --- a/packages/core/src/renderer/getDiForUnitTesting.tsx +++ b/packages/core/src/renderer/getDiForUnitTesting.tsx @@ -22,7 +22,9 @@ import { messagingFeature, testUtils as messagingTestUtils } from "@k8slens/mess export const getDiForUnitTesting = () => { const environment = "renderer"; - const di = createContainer(environment); + const di = createContainer(environment, { + detectCycles: false, + }); registerMobX(di); registerInjectableReact(di);