From 51b21347daefe086c5cbc16760e5fbe905c18993 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Thu, 24 Sep 2020 18:14:57 +0300 Subject: [PATCH] cleanup proxy upgrade handler (#963) Signed-off-by: Jari Kolehmainen --- src/main/lens-proxy.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/main/lens-proxy.ts b/src/main/lens-proxy.ts index dbd4f90c9e..dfb7de7867 100644 --- a/src/main/lens-proxy.ts +++ b/src/main/lens-proxy.ts @@ -53,11 +53,7 @@ export class LensProxy { if (req.url.startsWith(`${apiPrefix}?`)) { this.handleWsUpgrade(req, socket, head) } else { - if (req.headers.upgrade?.startsWith("SPDY")) { - this.handleSpdyProxy(proxy, req, socket, head) - } else { - socket.end() - } + this.handleProxyUpgrade(proxy, req, socket, head) } }) spdyProxy.on("error", (err) => { @@ -66,7 +62,7 @@ export class LensProxy { return spdyProxy } - protected async handleSpdyProxy(proxy: httpProxy, req: http.IncomingMessage, socket: net.Socket, head: Buffer) { + protected async handleProxyUpgrade(proxy: httpProxy, req: http.IncomingMessage, socket: net.Socket, head: Buffer) { const cluster = this.clusterManager.getClusterForRequest(req) if (cluster) { const proxyUrl = await cluster.contextHandler.resolveAuthProxyUrl() + req.url.replace(apiKubePrefix, "")