From 51c4965749655d9a0353941224c26fca035cbe5a Mon Sep 17 00:00:00 2001 From: Lauri Nevala Date: Tue, 28 Jul 2020 17:58:49 +0300 Subject: [PATCH] Fix invalid error callback on fs.chmod calls (#615) Signed-off-by: Lauri Nevala --- build/download_kubectl.ts | 4 +++- src/main/kubectl.ts | 4 +++- src/main/lens-binary.ts | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/build/download_kubectl.ts b/build/download_kubectl.ts index 708c1c843c..a697552aa8 100644 --- a/build/download_kubectl.ts +++ b/build/download_kubectl.ts @@ -79,7 +79,9 @@ class KubectlDownloader { return new Promise((resolve, reject) => { file.on("close", () => { console.log("kubectl binary download closed") - fs.chmod(this.path, 0o755, () => {}) + fs.chmod(this.path, 0o755, (err) => { + if (err) reject(err); + }) resolve() }) stream.pipe(file) diff --git a/src/main/kubectl.ts b/src/main/kubectl.ts index dbd9e8fb14..d395ac95a0 100644 --- a/src/main/kubectl.ts +++ b/src/main/kubectl.ts @@ -210,7 +210,9 @@ export class Kubectl { }) file.on("close", () => { logger.debug("kubectl binary download closed") - fs.chmod(this.path, 0o755, null) + fs.chmod(this.path, 0o755, (err) => { + if (err) reject(err); + }) resolve() }) stream.pipe(file) diff --git a/src/main/lens-binary.ts b/src/main/lens-binary.ts index beeeda3704..74a92a69a3 100644 --- a/src/main/lens-binary.ts +++ b/src/main/lens-binary.ts @@ -170,7 +170,9 @@ export class LensBinary { return new Promise((resolve, reject) => { file.on("close", () => { logger.debug(`${this.originalBinaryName} binary download closed`) - if (!this.tarPath) fs.chmod(binaryPath, 0o755, null) + if (!this.tarPath) fs.chmod(binaryPath, 0o755, (err) => { + if (err) reject(err); + }) resolve() }) stream.pipe(file)