mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Fix removal of langci from repo (#2204)
- Move all strings of the form {`...`} to use just ""
- Fix RoleBindingDetails not rendering the name of the role binding
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
1 parent
83d7e4550c
commit
5258aab0d2
35 files changed
+78
-78
No files matched your search
@@ -205,7 +205,7 @@ export class AddRoleBindingDialog extends React.Component<Props> {
|
||||
<Select
|
||||
key={this.selectedRoleId}
|
||||
themeName="light"
|
||||
placeholder={`Select role..`}
|
||||
placeholder="Select role.."
|
||||
isDisabled={this.isEditing}
|
||||
options={this.roleOptions}
|
||||
value={this.selectedRoleId}
|
||||
@@ -224,7 +224,7 @@ export class AddRoleBindingDialog extends React.Component<Props> {
|
||||
!this.useRoleForBindingName && (
|
||||
<Input
|
||||
autoFocus
|
||||
placeholder={`Name`}
|
||||
placeholder="Name"
|
||||
disabled={this.isEditing}
|
||||
value={this.bindingName}
|
||||
onChange={v => this.bindingName = v}
|
||||
@@ -239,7 +239,7 @@ export class AddRoleBindingDialog extends React.Component<Props> {
|
||||
<Select
|
||||
isMulti
|
||||
themeName="light"
|
||||
placeholder={`Select service accounts`}
|
||||
placeholder="Select service accounts"
|
||||
autoConvertOptions={false}
|
||||
options={this.serviceAccountOptions}
|
||||
onChange={(opts: BindingSelectOption[]) => {
|
||||
|
||||
@@ -117,8 +117,8 @@ export class RoleBindingDetails extends React.Component<Props> {
|
||||
<AddRemoveButtons
|
||||
onAdd={() => AddRoleBindingDialog.open(roleBinding)}
|
||||
onRemove={selectedSubjects.length ? this.removeSelectedSubjects : null}
|
||||
addTooltip="Add bindings to {name}"
|
||||
removeTooltip="Remove selected bindings from ${name}"
|
||||
addTooltip={`Add bindings to ${roleRef.name}`}
|
||||
removeTooltip={`Remove selected bindings from ${roleRef.name}`}
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
|
||||
Reference in new issue
Block a user