hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix dropdown items readability in Dock (#7209)

Browse Source 
* Remove Select's outlined theme

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Updating snapshots

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

---------

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2023-02-22 14:47:05 +03:00 committed by GitHub
parent c09c7125e5
commit 52660ef75c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 34 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
packages/core/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap
View File

@ -3031,7 +3031,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -3108,7 +3108,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -3234,7 +3234,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Select__menu-portal css-1no2yl0-MenuPortal" class="Select__menu-portal css-1no2yl0-MenuPortal"
> >
<div <div
class="theme-outlined install-chart-version-select-for-some-first-tab-id-options Select__menu css-1nmdiq5-menu" class="theme-dark install-chart-version-select-for-some-first-tab-id-options Select__menu css-1nmdiq5-menu"
id="react-select-install-chart-version-select-for-some-first-tab-id-listbox" id="react-select-install-chart-version-select-for-some-first-tab-id-listbox"
> >
<div <div
@ -4073,7 +4073,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -4148,7 +4148,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -5089,7 +5089,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -5164,7 +5164,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -6100,7 +6100,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -6175,7 +6175,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -7111,7 +7111,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -7186,7 +7186,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -8144,7 +8144,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -8219,7 +8219,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -8347,7 +8347,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
class="Select__menu-portal css-1no2yl0-MenuPortal" class="Select__menu-portal css-1no2yl0-MenuPortal"
> >
<div <div
class="NamespaceSelectMenu theme-outlined install-chart-namespace-select-for-some-first-tab-id-options Select__menu css-1nmdiq5-menu" class="NamespaceSelectMenu theme-dark install-chart-namespace-select-for-some-first-tab-id-options Select__menu css-1nmdiq5-menu"
id="react-select-install-chart-namespace-select-for-some-first-tab-id-listbox" id="react-select-install-chart-namespace-select-for-some-first-tab-id-listbox"
> >
<div <div
@ -9186,7 +9186,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -9261,7 +9261,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -10197,7 +10197,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -10272,7 +10272,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -13798,7 +13798,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -13873,7 +13873,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -15957,7 +15957,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -16034,7 +16034,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -17022,7 +17022,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -17097,7 +17097,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -18033,7 +18033,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -18108,7 +18108,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -19044,7 +19044,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -19119,7 +19119,7 @@ exports[`installing helm chart from new tab given tab for installing chart was n
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"

4
packages/core/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-previously-opened-tab.test.ts.snap
View File

@ -1133,7 +1133,7 @@ exports[`installing helm chart from previously opened tab given tab for installi
Version Version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -1208,7 +1208,7 @@ exports[`installing helm chart from previously opened tab given tab for installi
Namespace Namespace
</span> </span>
<div <div
class="Select theme-outlined NamespaceSelect css-b62m3t-container" class="Select theme-dark NamespaceSelect css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"

4
packages/core/src/features/helm-charts/upgrade-chart/__snapshots__/upgrade-chart-new-tab.test.ts.snap
View File

@ -4103,7 +4103,7 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
Upgrade version Upgrade version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"
@ -5098,7 +5098,7 @@ exports[`New Upgrade Helm Chart Dock Tab given a namespace is selected when navi
Upgrade version Upgrade version
</span> </span>
<div <div
class="Select theme-outlined chart-version css-b62m3t-container" class="Select theme-dark chart-version css-b62m3t-container"
> >
<span <span
class="css-1f43avz-a11yText-A11yText" class="css-1f43avz-a11yText-A11yText"

1
packages/core/src/renderer/components/dock/create-resource/view.tsx
View File

@ -142,7 +142,6 @@ class NonInjectedCreateResource extends React.Component<CreateResourceProps & De
options={this.props.createResourceTemplates.get()} options={this.props.createResourceTemplates.get()}
formatGroupLabel={group => group.label} formatGroupLabel={group => group.label}
menuPlacement="top" menuPlacement="top"
themeName="outlined"
onChange={(option) => { onChange={(option) => {
if (option) { if (option) {
this.props.createResourceTabStore.setData(this.tabId, option.value); this.props.createResourceTabStore.setData(this.tabId, option.value);

2
packages/core/src/renderer/components/dock/install-chart/view.tsx
View File

@ -93,14 +93,12 @@ const NonInjectedInstallChart = observer(
options={version.options.get()} options={version.options.get()}
onChange={(changed) => version.onChange(changed?.value)} onChange={(changed) => version.onChange(changed?.value)}
menuPlacement="top" menuPlacement="top"
themeName="outlined"
id={`install-chart-version-select-for-${tabId}`} id={`install-chart-version-select-for-${tabId}`}
/> />
<span>Namespace</span> <span>Namespace</span>
<NamespaceSelect <NamespaceSelect
showIcons={false} showIcons={false}
menuPlacement="top" menuPlacement="top"
themeName="outlined"
value={namespace.value.get()} value={namespace.value.get()}
onChange={namespace.onChange} onChange={namespace.onChange}
id={`install-chart-namespace-select-for-${tabId}`} id={`install-chart-namespace-select-for-${tabId}`}

1
packages/core/src/renderer/components/dock/upgrade-chart/view.tsx
View File

@ -81,7 +81,6 @@ export class NonInjectedUpgradeChart extends React.Component<UpgradeChartProps &
id="char-version-input" id="char-version-input"
className="chart-version" className="chart-version"
menuPlacement="top" menuPlacement="top"
themeName="outlined"
value={model.version.value.get()} value={model.version.value.get()}
options={model.versionOptions.get()} options={model.versionOptions.get()}
onChange={model.version.set} onChange={model.version.set}

21
packages/core/src/renderer/components/select/select.scss
View File

@ -43,10 +43,6 @@ html {
} }
} }
&__value-container {
margin-bottom: 1px;
}
&__single-value { &__single-value {
color: var(--textColorSecondary); color: var(--textColorSecondary);
overflow: visible; overflow: visible;
@ -93,6 +89,8 @@ html {
&__option { &__option {
white-space: nowrap; white-space: nowrap;
cursor: pointer; cursor: pointer;
border-radius: 3px;
padding: 6px 8px;
&:active { &:active {
background: var(--primary); background: var(--primary);
@ -179,21 +177,6 @@ html {
} }
} }
&.theme-outlined {
.Select__control {
box-shadow: 0 0 0 1px var(--colorVague);
color: var(--primary);
.Select__value-container {
padding: 0 $padding * 0.5;
}
.Select__dropdown-indicator {
padding: 3px;
}
}
}
&.theme-lens { &.theme-lens {
:hover { :hover {
&.Select__control { &.Select__control {