From 53dc2c853d315285852b79b97eff98e37044e8ad Mon Sep 17 00:00:00 2001 From: Janne Savolainen Date: Tue, 16 Nov 2021 07:46:32 +0200 Subject: [PATCH] Fix incorrect typing in test Signed-off-by: Janne Savolainen --- src/extensions/registries/base-registry.ts | 6 +++++- src/extensions/registries/kube-object-menu-registry.ts | 4 ++-- .../components/kube-object-menu/kube-object-menu.test.tsx | 4 ++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/extensions/registries/base-registry.ts b/src/extensions/registries/base-registry.ts index 9b596172c9..b76762671a 100644 --- a/src/extensions/registries/base-registry.ts +++ b/src/extensions/registries/base-registry.ts @@ -24,7 +24,11 @@ import { action, observable, makeObservable } from "mobx"; import { Singleton } from "../../common/utils"; import { LensExtension } from "../lens-extension"; -export class BaseRegistry extends Singleton { +export interface IBaseRegistry { + add(items: T | T[], extension?: LensExtension): () => void; +} + +export class BaseRegistry extends Singleton implements IBaseRegistry { private items = observable.map([], { deep: false }); constructor() { diff --git a/src/extensions/registries/kube-object-menu-registry.ts b/src/extensions/registries/kube-object-menu-registry.ts index a6ce70322b..58cd4ffc28 100644 --- a/src/extensions/registries/kube-object-menu-registry.ts +++ b/src/extensions/registries/kube-object-menu-registry.ts @@ -20,7 +20,7 @@ */ import type React from "react"; -import { BaseRegistry } from "./base-registry"; +import { BaseRegistry, IBaseRegistry } from "./base-registry"; export interface KubeObjectMenuComponents { MenuItem: React.ComponentType; @@ -32,7 +32,7 @@ export interface KubeObjectMenuRegistration { components: KubeObjectMenuComponents; } -export interface IKubeObjectMenuRegistry { +export interface IKubeObjectMenuRegistry extends IBaseRegistry { getItemsForKind(kind: string, apiVersion: string): any; } diff --git a/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx b/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx index 2d9ba02fe5..34c1c64407 100644 --- a/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx +++ b/src/renderer/components/kube-object-menu/kube-object-menu.test.tsx @@ -292,7 +292,7 @@ const addDynamicMenuItem = ({ apiVersions, kind, }: { - di: any; + di: IConfigurableDependencyInjectionContainer; apiVersions: string[]; kind: string; }) => { @@ -304,7 +304,7 @@ const addDynamicMenuItem = ({ components: { MenuItem: MenuItemComponent }, }; - const kubeObjectMenuRegistry: KubeObjectMenuRegistry = di.inject( + const kubeObjectMenuRegistry = di.inject( kubeObjectMenuRegistryInjectable, );