mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Fix PieChart tooltips (#5223)
* Add tooltipLabels field to ChartData Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Use tooltipLabels in ClusterPieCharts for pods Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Check for tooltipLabels field to assign tooltip text Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Use tooltipLabels inside overview charts Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Expand workload overview charts to fit tooltips Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Move tooltipLabels into chart datasets Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Move tooltipLabels prop to PieCharts Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Little clean up Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Getting back id field to PieChartData interface Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Id fix Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * More clean up Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
1 parent
423ffd44dc
commit
542cbe9ebf
4 files changed
+40
-19
No files matched your search
@@ -13,10 +13,4 @@
|
||||
--workload-status-failed: #{$pod-status-failed-color};
|
||||
--workload-status-terminated: #{$pod-status-terminated-color};
|
||||
--workload-status-unknown: #{$pod-status-unknown-color};
|
||||
|
||||
.PieChart {
|
||||
.chart-container {
|
||||
width: 110px
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -8,9 +8,9 @@ import "./overview-workload-status.scss";
|
||||
import React from "react";
|
||||
import capitalize from "lodash/capitalize";
|
||||
import { observer } from "mobx-react";
|
||||
import type { DatasetTooltipLabel, PieChartData } from "../chart";
|
||||
import { PieChart } from "../chart";
|
||||
import { cssVar } from "../../utils";
|
||||
import type { ChartData } from "chart.js";
|
||||
import { ThemeStore } from "../../theme.store";
|
||||
|
||||
export interface OverviewWorkloadStatusProps {
|
||||
@@ -27,7 +27,7 @@ export class OverviewWorkloadStatus extends React.Component<OverviewWorkloadStat
|
||||
}
|
||||
|
||||
const cssVars = cssVar(this.elem);
|
||||
const chartData: Required<ChartData> = {
|
||||
const chartData: Required<PieChartData> = {
|
||||
labels: [],
|
||||
datasets: [],
|
||||
};
|
||||
@@ -43,10 +43,12 @@ export class OverviewWorkloadStatus extends React.Component<OverviewWorkloadStat
|
||||
} else {
|
||||
const data: number[] = [];
|
||||
const backgroundColor: string[] = [];
|
||||
const tooltipLabels: DatasetTooltipLabel[] = [];
|
||||
|
||||
for (const [status, value] of statuses) {
|
||||
data.push(value);
|
||||
backgroundColor.push(cssVars.get(`--workload-status-${status.toLowerCase()}`).toString());
|
||||
tooltipLabels.push(percent => `${capitalize(status)}: ${percent}`);
|
||||
chartData.labels.push(`${capitalize(status)}: ${value}`);
|
||||
}
|
||||
|
||||
@@ -54,6 +56,7 @@ export class OverviewWorkloadStatus extends React.Component<OverviewWorkloadStat
|
||||
data,
|
||||
backgroundColor,
|
||||
label: "Status",
|
||||
tooltipLabels,
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user