Fix PieChart tooltips (#5223)

* Add tooltipLabels field to ChartData

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Use tooltipLabels in ClusterPieCharts for pods

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Check for tooltipLabels field to assign tooltip text

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Use tooltipLabels inside overview charts

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Expand workload overview charts to fit tooltips

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Move tooltipLabels into chart datasets

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Move tooltipLabels prop to PieCharts

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Little clean up

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Getting back id field to PieChartData interface

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Id fix

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* More clean up

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev authored and GitHub committed 2022-04-11 15:21:18 +03:00
1 parent 423ffd44dc
commit 542cbe9ebf
4 files changed
+40 -19

No files matched your search

+27 -7
View File
@@ -16,6 +16,17 @@ import { ThemeStore } from "../../theme.store";
export interface PieChartProps extends ChartProps {
}
export interface PieChartData extends ChartJS.ChartData {
datasets?: PieChartDataSets[];
}
export type DatasetTooltipLabel = (percent: string) => string | string;
interface PieChartDataSets extends ChartJS.ChartDataSets {
id?: string;
tooltipLabels?: DatasetTooltipLabel[];
}
@observer
export class PieChart extends React.Component<PieChartProps> {
render() {
@@ -28,15 +39,24 @@ export class PieChart extends React.Component<PieChartProps> {
mode: "index",
callbacks: {
title: () => "",
label: (tooltipItem, data) => {
const dataset: any = data["datasets"][tooltipItem.datasetIndex];
const metaData = Object.values<{ total: number }>(dataset["_meta"])[0];
const percent = Math.round((dataset["data"][tooltipItem["index"]] / metaData.total) * 100);
const label = dataset["label"];
label: (tooltipItem, data: PieChartData) => {
const dataset = data.datasets[tooltipItem.datasetIndex];
const datasetData = dataset.data as number[];
const total = datasetData.reduce((acc, cur) => acc + cur, 0);
const percent = Math.round((datasetData[tooltipItem.index] as number / total) * 100);
const percentLabel = isNaN(percent) ? "N/A" : `${percent}%`;
const tooltipLabel = dataset.tooltipLabels?.[tooltipItem.index];
let tooltip = `${dataset.label}: ${percentLabel}`;
if (isNaN(percent)) return `${label}: N/A`;
if (tooltipLabel) {
if (typeof tooltipLabel === "function") {
tooltip = tooltipLabel(percentLabel);
} else {
tooltip = tooltipLabel;
}
}
return `${label}: ${percent}%`;
return tooltip;
},
},
filter: ({ datasetIndex, index }, { datasets }) => {