hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Drop support for adding telemetry by tagging

Browse Source 
This was not used, and would make development of future feature more difficult.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
This commit is contained in:
Iku-turso 2023-03-02 15:00:37 +02:00
parent 6df01ba468
commit 556fa8dd33
2 changed files with 3 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
packages/core/src/features/telemetry/emit-telemetry-from-specific-function-calls.test.ts
View File

@ -28,18 +28,15 @@ describe("emit-telemetry-from-specific-function-calls", () => {
di.override(emitEventInjectable, () => emitEventMock); di.override(emitEventInjectable, () => emitEventMock);
}); });
describe("given instances of white-listed, non-white-listed and tagged functions", () => { describe("given instances of white-listed, non-white-listed", () => {
let whiteListedFunctionMock: jest.Mock; let whiteListedFunctionMock: jest.Mock;
let nonWhiteListedFunctionMock: jest.Mock; let nonWhiteListedFunctionMock: jest.Mock;
let taggedFunctionMock: jest.Mock;
let injectedWhiteListedFunction: jest.Mock; let injectedWhiteListedFunction: jest.Mock;
let injectedNonWhiteListedFunction: jest.Mock; let injectedNonWhiteListedFunction: jest.Mock;
let injectedTaggedFunction: jest.Mock;
beforeEach(() => { beforeEach(() => {
whiteListedFunctionMock = jest.fn(); whiteListedFunctionMock = jest.fn();
nonWhiteListedFunctionMock = jest.fn(); nonWhiteListedFunctionMock = jest.fn();
taggedFunctionMock = jest.fn();
const whiteListedInjectable = getInjectable({ const whiteListedInjectable = getInjectable({
id: "some-white-listed-function", id: "some-white-listed-function",
@ -51,28 +48,19 @@ describe("emit-telemetry-from-specific-function-calls", () => {
instantiate: () => nonWhiteListedFunctionMock, instantiate: () => nonWhiteListedFunctionMock,
}); });
const taggedInjectable = getInjectable({
id: "some-tagged-function",
instantiate: () => taggedFunctionMock,
tags: ["emit-telemetry"],
});
runInAction(() => { runInAction(() => {
di.register(whiteListedInjectable); di.register(whiteListedInjectable, nonWhiteListedInjectable);
di.register(nonWhiteListedInjectable);
di.register(taggedInjectable);
}); });
injectedWhiteListedFunction = di.inject(whiteListedInjectable); injectedWhiteListedFunction = di.inject(whiteListedInjectable);
injectedNonWhiteListedFunction = di.inject(nonWhiteListedInjectable); injectedNonWhiteListedFunction = di.inject(nonWhiteListedInjectable);
injectedTaggedFunction = di.inject(taggedInjectable);
}); });
it("telemetry is not emitted yet", () => { it("telemetry is not emitted yet", () => {
expect(emitEventMock).not.toHaveBeenCalled(); expect(emitEventMock).not.toHaveBeenCalled();
}); });
describe("when the white-listed function is called", () => { describe("when the white-listed function is called with parameters", () => {
beforeEach(() => { beforeEach(() => {
injectedWhiteListedFunction("some-arg", "some-other-arg"); injectedWhiteListedFunction("some-arg", "some-other-arg");
}); });
@ -126,21 +114,6 @@ describe("emit-telemetry-from-specific-function-calls", () => {
expect(emitEventMock).not.toHaveBeenCalled(); expect(emitEventMock).not.toHaveBeenCalled();
}); });
}); });
describe("when the tagged, but not white-listed function is called", () => {
beforeEach(() => {
injectedTaggedFunction("some-arg", "some-other-arg");
});
it("telemetry is emitted in event bus", () => {
expect(emitEventMock).toHaveBeenCalledWith({
destination: "auto-capture",
action: "telemetry-from-business-action",
name: "some-tagged-function",
params: { args: ["some-arg", "some-other-arg"] },
});
});
});
}); });
}); });
}); });

1
packages/core/src/features/telemetry/renderer/telemetry-decorator.injectable.ts
View File

@ -63,7 +63,6 @@ const telemetryDecoratorInjectable = getInjectable({
const shouldEmitTelemetryFor = const shouldEmitTelemetryFor =
(whiteList: string[]) => (injectable: Injectable<any, any, any>) => (whiteList: string[]) => (injectable: Injectable<any, any, any>) =>
injectable.tags?.includes("emit-telemetry") ||
whiteList.includes(injectable.id); whiteList.includes(injectable.id);
export default telemetryDecoratorInjectable; export default telemetryDecoratorInjectable;