From 55ce80ea3fd4e0ba9711ea0726d7b641bc5ea326 Mon Sep 17 00:00:00 2001 From: Jari Kolehmainen Date: Tue, 4 May 2021 15:21:47 +0300 Subject: [PATCH] fix tests Signed-off-by: Jari Kolehmainen --- src/main/__test__/cluster.test.ts | 6 ----- src/main/__test__/kubeconfig-manager.test.ts | 24 ++++++++++---------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/src/main/__test__/cluster.test.ts b/src/main/__test__/cluster.test.ts index 5854a593a2..9227280941 100644 --- a/src/main/__test__/cluster.test.ts +++ b/src/main/__test__/cluster.test.ts @@ -31,14 +31,8 @@ jest.mock("request-promise-native"); import { Console } from "console"; import mockFs from "mock-fs"; import { Cluster } from "../cluster"; -import { ContextHandler } from "../context-handler"; -import { V1ResourceAttributes } from "@kubernetes/client-node"; -import { apiResources } from "../../common/rbac"; -import request from "request-promise-native"; import { Kubectl } from "../kubectl"; -const mockedRequest = request as jest.MockedFunction; - console = new Console(process.stdout, process.stderr); // fix mockFS describe("create clusters", () => { diff --git a/src/main/__test__/kubeconfig-manager.test.ts b/src/main/__test__/kubeconfig-manager.test.ts index 148c41c589..cc78fdf82f 100644 --- a/src/main/__test__/kubeconfig-manager.test.ts +++ b/src/main/__test__/kubeconfig-manager.test.ts @@ -31,10 +31,14 @@ import fse from "fs-extra"; import { loadYaml } from "@kubernetes/client-node"; import { Console } from "console"; import * as path from "path"; +import { LensProxy } from "../proxy/lens-proxy"; console = new Console(process.stdout, process.stderr); // fix mockFS describe("kubeconfig manager tests", () => { + let cluster: Cluster; + let contextHandler: ContextHandler; + beforeEach(() => { const mockOpts = { "minikube-config.yml": JSON.stringify({ @@ -61,6 +65,14 @@ describe("kubeconfig manager tests", () => { }; mockFs(mockOpts); + + cluster = new Cluster({ + id: "foo", + contextName: "minikube", + kubeConfigPath: "minikube-config.yml", + }); + contextHandler = jest.fn() as any; + jest.spyOn(KubeconfigManager.prototype, "resolveProxyUrl", "get").mockReturnValue("http://127.0.0.1:9191/foo"); }); afterEach(() => { @@ -68,12 +80,6 @@ describe("kubeconfig manager tests", () => { }); it("should create 'temp' kube config with proxy", async () => { - const cluster = new Cluster({ - id: "foo", - contextName: "minikube", - kubeConfigPath: "minikube-config.yml", - }); - const contextHandler = new ContextHandler(cluster); const kubeConfManager = new KubeconfigManager(cluster, contextHandler); expect(logger.error).not.toBeCalled(); @@ -89,12 +95,6 @@ describe("kubeconfig manager tests", () => { }); it("should remove 'temp' kube config on unlink and remove reference from inside class", async () => { - const cluster = new Cluster({ - id: "foo", - contextName: "minikube", - kubeConfigPath: "minikube-config.yml", - }); - const contextHandler = new ContextHandler(cluster); const kubeConfManager = new KubeconfigManager(cluster, contextHandler); const configPath = await kubeConfManager.getPath();