hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix getExtensionPageUrl on Windows (#1609)

Browse Source 
* Fix getExtensionPageUrl on Windows

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>

* Use path.posix.join() instead

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>

* Fix lint issues

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
This commit is contained in:
Lauri Nevala 2020-12-02 13:09:47 +02:00 committed by GitHub
parent c22d569fe2
commit 57d6dfa4b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/extensions/registries/page-registry.ts
View File

@ -44,7 +44,7 @@ export function getExtensionPageUrl<P extends object>({ extensionId, pageId = ""
const extensionBaseUrl = compile(`/extension/:name`)({ const extensionBaseUrl = compile(`/extension/:name`)({
name: sanitizeExtensionName(extensionId), // compile only with extension-id first and define base path name: sanitizeExtensionName(extensionId), // compile only with extension-id first and define base path
}); });
const extPageRoutePath = path.join(extensionBaseUrl, pageId); // page-id might contain route :param-s, so don't compile yet const extPageRoutePath = path.posix.join(extensionBaseUrl, pageId);
if (params) { if (params) {
return compile(extPageRoutePath)(params); // might throw error when required params not passed return compile(extPageRoutePath)(params); // might throw error when required params not passed

1
webpack.extensions.ts
View File

@ -6,6 +6,7 @@ import { sassCommonVars } from "./src/common/vars";
export default function (): webpack.Configuration { export default function (): webpack.Configuration {
const entry = "./src/extensions/extension-api.ts"; const entry = "./src/extensions/extension-api.ts";
const outDir = "./src/extensions/npm/extensions/dist"; const outDir = "./src/extensions/npm/extensions/dist";
return { return {
// Compile for Electron for renderer process // Compile for Electron for renderer process
// see <https://webpack.js.org/configuration/target/> // see <https://webpack.js.org/configuration/target/>

1
webpack.main.ts
View File

@ -8,6 +8,7 @@ import * as vars from "./src/common/vars";
export default function (): webpack.Configuration { export default function (): webpack.Configuration {
console.info("WEBPACK:main", vars); console.info("WEBPACK:main", vars);
return { return {
context: __dirname, context: __dirname,
target: "electron-main", target: "electron-main",

1
webpack.renderer.ts
View File

@ -17,6 +17,7 @@ export function webpackLensRenderer({ showVars = true } = {}): webpack.Configura
if (showVars) { if (showVars) {
console.info("WEBPACK:renderer", vars); console.info("WEBPACK:renderer", vars);
} }
return { return {
context: __dirname, context: __dirname,
target: "electron-renderer", target: "electron-renderer",