From 58ffb8e3e45aff6bc659b55154526ee451c1370e Mon Sep 17 00:00:00 2001 From: Jim Ehrismann <40840436+jim-docker@users.noreply.github.com> Date: Tue, 11 Jan 2022 09:35:55 -0500 Subject: [PATCH] ensure old, saved port-forwards get loaded (#4668) Signed-off-by: Jim Ehrismann --- src/renderer/port-forward/port-forward.store.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/port-forward/port-forward.store.ts b/src/renderer/port-forward/port-forward.store.ts index e19371a65e..e914fff7d5 100644 --- a/src/renderer/port-forward/port-forward.store.ts +++ b/src/renderer/port-forward/port-forward.store.ts @@ -47,14 +47,14 @@ export class PortForwardStore extends ItemStore { const savedPortForwards = this.storage.get(); // undefined on first load - if (Array.isArray(savedPortForwards)) { + if (Array.isArray(savedPortForwards) && savedPortForwards.length > 0) { logger.info("[PORT-FORWARD-STORE] starting saved port-forwards"); // add the disabled ones await Promise.all(savedPortForwards.filter(pf => pf.status === "Disabled").map(addPortForward)); - // add the active ones and check if they started successfully - const results = await Promise.allSettled(savedPortForwards.filter(pf => pf.status === "Active").map(addPortForward)); + // add the active ones (assume active if the status is undefined, for backward compatibilty) and check if they started successfully + const results = await Promise.allSettled(savedPortForwards.filter(pf => !pf.status || pf.status === "Active").map(addPortForward)); for (const result of results) { if (result.status === "rejected" || result.value.status === "Disabled") {